Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Peter Ross <pross@xvid.org>
To: ffmpeg-devel@ffmpeg.org
Subject: [FFmpeg-devel] [PATCHv3 1/8] avcodec/g728_template: do_hybrid_window() template
Date: Mon, 9 Jun 2025 20:06:02 +1000
Message-ID: <04afb984e03a08909f1df886ff4d44b0201ad7f0.1749463495.git.pross@xvid.org> (raw)
In-Reply-To: <cover.1749463495.git.pross@xvid.org>


[-- Attachment #1.1: Type: text/plain, Size: 6174 bytes --]

intended for use by RealAudio 2.0 (28.8k) and G.728 decoders.
---
 libavcodec/g728_template.c | 65 ++++++++++++++++++++++++++++++++++++++
 libavcodec/ra288.c         | 50 ++---------------------------
 2 files changed, 68 insertions(+), 47 deletions(-)
 create mode 100644 libavcodec/g728_template.c

diff --git a/libavcodec/g728_template.c b/libavcodec/g728_template.c
new file mode 100644
index 0000000000..b60122ee37
--- /dev/null
+++ b/libavcodec/g728_template.c
@@ -0,0 +1,65 @@
+/*
+ * G.728 / RealAudio 2.0 (28.8K) decoder
+ *
+ * This file is part of FFmpeg.
+ *
+ * FFmpeg is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option) any later version.
+ *
+ * FFmpeg is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with FFmpeg; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+ */
+
+static void convolve(float *tgt, const float *src, int len, int n)
+{
+    for (; n >= 0; n--)
+        tgt[n] = ff_scalarproduct_float_c(src, src - n, len);
+
+}
+
+/**
+ * Hybrid window filtering, see blocks 36 and 49 of the G.728 specification.
+ *
+ * @param order   filter order
+ * @param n       input length
+ * @param non_rec number of non-recursive samples
+ * @param out     filter output
+ * @param hist    pointer to the input history of the filter
+ * @param out     pointer to the non-recursive part of the output
+ * @param out2    pointer to the recursive part of the output
+ * @param window  pointer to the windowing function table
+ */
+static void do_hybrid_window(void (*vector_fmul)(float *dst, const float *src0, const float *src1, int len),
+                             int order, int n, int non_rec, float *out,
+                             float *hist, float *out2, const float *window)
+{
+    int i;
+    float buffer1[MAX_BACKWARD_FILTER_ORDER + 1];
+    float buffer2[MAX_BACKWARD_FILTER_ORDER + 1];
+    LOCAL_ALIGNED(32, float, work, [FFALIGN(MAX_BACKWARD_FILTER_ORDER +
+                                            MAX_BACKWARD_FILTER_LEN   +
+                                            MAX_BACKWARD_FILTER_NONREC, 16)]);
+
+    av_assert2(order>=0);
+
+    vector_fmul(work, window, hist, FFALIGN(order + n + non_rec, 16));
+
+    convolve(buffer1, work + order    , n      , order);
+    convolve(buffer2, work + order + n, non_rec, order);
+
+    for (i=0; i <= order; i++) {
+        out2[i] = out2[i] * ATTEN + buffer1[i];
+        out [i] = out2[i]         + buffer2[i];
+    }
+
+    /* Multiply by the white noise correcting factor (WNCF). */
+    *out *= 257.0 / 256.0;
+}
diff --git a/libavcodec/ra288.c b/libavcodec/ra288.c
index aa499506b7..a1ee3f7eba 100644
--- a/libavcodec/ra288.c
+++ b/libavcodec/ra288.c
@@ -37,6 +37,8 @@
 #define MAX_BACKWARD_FILTER_ORDER  36
 #define MAX_BACKWARD_FILTER_LEN    40
 #define MAX_BACKWARD_FILTER_NONREC 35
+#define ATTEN 0.5625
+#include "g728_template.c"
 
 #define RA288_BLOCK_SIZE        5
 #define RA288_BLOCKS_PER_FRAME 32
@@ -87,13 +89,6 @@ static av_cold int ra288_decode_init(AVCodecContext *avctx)
     return 0;
 }
 
-static void convolve(float *tgt, const float *src, int len, int n)
-{
-    for (; n >= 0; n--)
-        tgt[n] = ff_scalarproduct_float_c(src, src - n, len);
-
-}
-
 static void decode(RA288Context *ractx, float gain, int cb_coef)
 {
     int i;
@@ -131,45 +126,6 @@ static void decode(RA288Context *ractx, float gain, int cb_coef)
     ff_celp_lp_synthesis_filterf(block, ractx->sp_lpc, buffer, 5, 36);
 }
 
-/**
- * Hybrid window filtering, see blocks 36 and 49 of the G.728 specification.
- *
- * @param order   filter order
- * @param n       input length
- * @param non_rec number of non-recursive samples
- * @param out     filter output
- * @param hist    pointer to the input history of the filter
- * @param out     pointer to the non-recursive part of the output
- * @param out2    pointer to the recursive part of the output
- * @param window  pointer to the windowing function table
- */
-static void do_hybrid_window(RA288Context *ractx,
-                             int order, int n, int non_rec, float *out,
-                             float *hist, float *out2, const float *window)
-{
-    int i;
-    float buffer1[MAX_BACKWARD_FILTER_ORDER + 1];
-    float buffer2[MAX_BACKWARD_FILTER_ORDER + 1];
-    LOCAL_ALIGNED(32, float, work, [FFALIGN(MAX_BACKWARD_FILTER_ORDER +
-                                            MAX_BACKWARD_FILTER_LEN   +
-                                            MAX_BACKWARD_FILTER_NONREC, 16)]);
-
-    av_assert2(order>=0);
-
-    ractx->vector_fmul(work, window, hist, FFALIGN(order + n + non_rec, 16));
-
-    convolve(buffer1, work + order    , n      , order);
-    convolve(buffer2, work + order + n, non_rec, order);
-
-    for (i=0; i <= order; i++) {
-        out2[i] = out2[i] * 0.5625 + buffer1[i];
-        out [i] = out2[i]          + buffer2[i];
-    }
-
-    /* Multiply by the white noise correcting factor (WNCF). */
-    *out *= 257.0 / 256.0;
-}
-
 /**
  * Backward synthesis filter, find the LPC coefficients from past speech data.
  */
@@ -180,7 +136,7 @@ static void backward_filter(RA288Context *ractx,
 {
     float temp[MAX_BACKWARD_FILTER_ORDER+1];
 
-    do_hybrid_window(ractx, order, n, non_rec, temp, hist, rec, window);
+    do_hybrid_window(ractx->vector_fmul, order, n, non_rec, temp, hist, rec, window);
 
     if (!compute_lpc_coefs(temp, order, lpc, 0, 1, 1))
         ractx->vector_fmul(lpc, lpc, tab, FFALIGN(order, 16));
-- 
2.47.2

-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2025-06-09 10:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-09 10:05 [FFmpeg-devel] [PATCHv3 0/8] G.728 decoding Peter Ross
2025-06-09 10:06 ` Peter Ross [this message]
2025-06-09 21:56   ` [FFmpeg-devel] [PATCHv3 1/8] avcodec/g728_template: do_hybrid_window() template Tomas Härdin
2025-06-09 10:06 ` [FFmpeg-devel] [PATCHv3 2/8] avcodec/g728_template: make hist parameter constant Peter Ross
2025-06-09 10:06 ` [FFmpeg-devel] [PATCHv3 3/8] avcodec/lpc_functions: compute_lpc_coefs: add starting lpc order and err cache parameters Peter Ross
2025-06-09 10:07 ` [FFmpeg-devel] [PATCHv3 4/8] avcodec/g728dec: G.728 decoder Peter Ross
2025-06-09 10:07 ` [FFmpeg-devel] [PATCHv3 5/8] avformat/g728dec: raw G.728 demuxer Peter Ross
2025-06-09 10:08 ` [FFmpeg-devel] [PATCHv3 6/8] avformat/riff: G.728 muxing and demuxing Peter Ross
2025-06-09 10:08 ` [FFmpeg-devel] [PATCHv3 7/8] avformat/aiff: " Peter Ross
2025-06-09 22:25   ` Andreas Rheinhardt
2025-06-10  0:07     ` compn
2025-06-10  0:29     ` Peter Ross
2025-06-11 14:45       ` compn
2025-06-09 10:08 ` [FFmpeg-devel] [PATCHv3 8/8] avformat/rtp: " Peter Ross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=04afb984e03a08909f1df886ff4d44b0201ad7f0.1749463495.git.pross@xvid.org \
    --to=pross@xvid.org \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git