From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 39DAE40251 for ; Sun, 20 Feb 2022 00:05:15 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3E43468AE86; Sun, 20 Feb 2022 02:05:13 +0200 (EET) Received: from mail-vk1-f179.google.com (mail-vk1-f179.google.com [209.85.221.179]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 31AA468A58C for ; Sun, 20 Feb 2022 02:05:05 +0200 (EET) Received: by mail-vk1-f179.google.com with SMTP id f12so6768091vkl.2 for ; Sat, 19 Feb 2022 16:05:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=ur2JrSyKQGc98WJT8la633cz7nNDdqOzDGMRnfaCdIk=; b=Vsurc4kKz9E5vzSkAXzqlAHJ1LlKYS6FUUDvId+bMQsvb4XTSE5qY5idWsVkEfrlkE eCEbmcahlf0QAFX4YjLnU8rkOtmqU3NBcgi8GzqmFj41M6eBDsUkNhaXCjEOULqtaqjB xriLIox0iNuIOE0YJGZoNrBy5/ocIWpFpLP6EYdIHqtMisbwsZqv+SA0j7ewR2sZRoCu s0wt/gBQPYtEZz4RZef/DC+JKFhDcZz6HE2CPNGfIfcfgqBTN0A6nzlys7NzKPKxXmPb EnD439gxNf6i6WPnxXf0phlDZdnib6GmrrPY2G7IcwCMgtonGOPpflOhI65XM1yNxTd1 /v4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=ur2JrSyKQGc98WJT8la633cz7nNDdqOzDGMRnfaCdIk=; b=Y08tbUTTIiS68Hx3dQMHGMCssi98DvFNrXO5s+54On0ZnYxDUFR9VjAJl5t1hRbyAP zKc3maleXqF4NSfJ5qh5nJG/Cuy8jZHTLwtyNVcCGesX6iaB48diSzMuajKMfcmfQszD NJNcIEDo3kkvVhg4126u/QLmjybdNuR4QI1Wi+5nEbak8BRy1mcuU+FPBOasNXLzMilp wtQoiuGtodldzSw08QlV/T2abAx4qDz8z8gNMUpw/uIpsFHlpXTHeiN7SD5+1ueo+309 2L8abdIthoAGlwf1Fhbdh7JlGZ9hXfaq9ffVE2PRaRpzaOf4EIMTsuSy5iSxb0JtpPr1 XEGw== X-Gm-Message-State: AOAM531YfmlzUSlpApd6yw3UsF14eNp1GGOqoP1qq1VDIdtDZ2AC9yRT 4qcF1b8zAUAttrnSsmXO6N0XkEzK8LUKtA== X-Google-Smtp-Source: ABdhPJzMbRcOinGQ3ZaQZokEyag+JHibgK+Q1PBrwM9A41Pl8xSE6kVUstjjreAg38PSI0NPuKVDug== X-Received: by 2002:a05:6122:8ca:b0:325:ff0a:2e95 with SMTP id 10-20020a05612208ca00b00325ff0a2e95mr6080155vkg.9.1645315504047; Sat, 19 Feb 2022 16:05:04 -0800 (PST) Received: from [192.168.1.5] ([75.115.109.114]) by smtp.gmail.com with ESMTPSA id j6sm2457005uae.4.2022.02.19.16.05.03 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 19 Feb 2022 16:05:03 -0800 (PST) Message-ID: <041a5df3-7ede-9e4b-f77b-b0a5e9346ed2@gmail.com> Date: Sat, 19 Feb 2022 19:05:02 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220219214153.2719-1-qyot27@gmail.com> <20220219214153.2719-2-qyot27@gmail.com> From: Stephen Hutchinson In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/avisynth: make sure framedata variable is initialized X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2/19/22 5:45 PM, Andreas Rheinhardt wrote: > Stephen Hutchinson: >> Addresses Coverity issue 1500290 >> >> Signed-off-by: Stephen Hutchinson >> --- >> libavformat/avisynth.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/libavformat/avisynth.c b/libavformat/avisynth.c >> index 03489f180f..cfb7b2a783 100644 >> --- a/libavformat/avisynth.c >> +++ b/libavformat/avisynth.c >> @@ -244,7 +244,8 @@ static int avisynth_create_stream_video(AVFormatContext *s, AVStream *st) >> AviSynthContext *avs = s->priv_data; >> const AVS_Map *avsmap; >> AVS_VideoFrame *frame; >> - int framedata, error; >> + int framedata = 0; >> + int error; >> int planar = 0; // 0: packed, 1: YUV, 2: Y8, 3: Planar RGB, 4: YUVA, 5: Planar RGBA >> >> st->codecpar->codec_type = AVMEDIA_TYPE_VIDEO; > > Looking at the naming in > https://github.com/AviSynth/AviSynthPlus/blob/master/avs_core/core/avisynth_c.cpp#L828 > makes me believe that this variable is actually a frame number. If so, > it is misnamed and this could be fixed easily by just removing this > variable. Am I right? > It seems so. I think I was just going off of the way avs_get_frame was used in avisynth_read_packet_video (as I was also trying to see whether some of the other properties* should be read per-frame from within read_packet_video), but there's no need to do that with the simpler ones in avisynth_create_stream_video. *related to timestamps or to HDR mastering information, but I'm thinking that's going to require adding an entire function to the demuxer to be able to set side metadata (at least for the HDR stuff, anyway). _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".