From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id CE99247958 for ; Sat, 28 Oct 2023 13:04:49 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C324F68CB31; Sat, 28 Oct 2023 16:04:46 +0300 (EEST) Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BAE1F68C987 for ; Sat, 28 Oct 2023 16:04:40 +0300 (EEST) Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-9c603e2354fso606130966b.1 for ; Sat, 28 Oct 2023 06:04:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698498280; x=1699103080; darn=ffmpeg.org; h=subject:content-language:to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=xSDWBxVlTaskHeQeBCNyo1uhG7rPCLbVcHIjGskQhqM=; b=BWDozPFUGIdqicng0HJqzHERtJZtzYlSkju+nWsHTk/gNXhXXjK7Jd4EKrCG2uDrGU gkdzMJpP8Sey1yvQrW+KlooiyLARIi4KGj1N0NluxL7aQa80E03PNZ33PuHAwsKzhuNv Lj5Iw8+sAZMztjiJX6ngJ58CeyzMD19fSptfAEiibonMW+011X+8IhyV2C7b7CHIA5cy xULGVSxRuQYYv2LWpa2XcBv2adZ0fhgmKsHluZZyve1StqXhqf8X/eEN2LhXoBwUAKwM OjTthcTepS1GYFUG5+asSXBPlfQOFlqWfj56DsdS4H7WjK/I28LfkKsIrQRYxssnoWkP 8YOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698498280; x=1699103080; h=subject:content-language:to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xSDWBxVlTaskHeQeBCNyo1uhG7rPCLbVcHIjGskQhqM=; b=nHXhd1Y3btLExEui6033tgKLxr1kUPQniP6lwjePeF8eJ4AVv7vyQzyuPORfRMhDld Vtc+EQ6uqz7gRHK+PW0scbGAb5zyHmGWe1DxocVrN/bTPUVfig4g8gjt05D2YMDjw57m FYpzoKTjEFGb8UDAtufzth/4wBSCC7/zHDJxr87IGEOfCXuGrGV+YHzqIg4TBdHcrX39 OateQZHX6UY7TGXXUyw0xcGXwFLQEuKoLNjDg7rZ/WM1PVphEsdC4t/oh3KFKcxJLSVT aInccRITXiNVfQxjAsDFaKo6+i70swPfNxnO34xXco3nB/TErfjD9C3nlp2ksMCuiWU1 OHfw== X-Gm-Message-State: AOJu0Yy/E8UYdukmZojLgM8V+mcrPddKWsI/w10aTbrmNZtlNq3lxPj0 MxUhS7xu1BQganCzTjVMaO89q0KPBw4Exw== X-Google-Smtp-Source: AGHT+IFSRLqdb+3X7UUpst6S7vfHzgSRo4kklkN09+zHew3YhUCWBS16JglwWGCSuWLuQQO5PjMopg== X-Received: by 2002:a17:907:3e9f:b0:9b6:3be9:a8f with SMTP id hs31-20020a1709073e9f00b009b63be90a8fmr5478419ejc.20.1698498279837; Sat, 28 Oct 2023 06:04:39 -0700 (PDT) Received: from [192.168.8.101] (apn-78-30-66-254.dynamic.gprs.plus.pl. [78.30.66.254]) by smtp.googlemail.com with ESMTPSA id y4-20020a170906470400b009ad778a68c5sm2760023ejq.60.2023.10.28.06.04.39 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 28 Oct 2023 06:04:39 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------KU7ryRdsaW6jIZC6yUhZulha" Message-ID: <03aae8d1-edc7-4bb8-b2c8-23ac49c665c0@gmail.com> Date: Sat, 28 Oct 2023 15:04:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: WooDzu To: ffmpeg-devel@ffmpeg.org Content-Language: en-US Subject: [FFmpeg-devel] [PATCH] libavformat: increase MAX_URL_SIZE X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: This is a multi-part message in MIME format. --------------KU7ryRdsaW6jIZC6yUhZulha Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit With the rise of object storage, like S3, it is not uncommon to generate long pre-signed URLs. When a pre-signed URL is generated using a short-lived credentials it may include a query parameter called X-Amz-Security-Token that is 4kB on its own. The current MAX_URL_SIZE will trim the URL with no any errors or warnings and the request will fail with a http 400 error. Signed-off-by: Piotr Gasiorowski --- libavformat/internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/internal.h b/libavformat/internal.h index 7702986c9c..d6465bad7c 100644 --- a/libavformat/internal.h +++ b/libavformat/internal.h @@ -27,7 +27,7 @@ #include "avformat.h" -#define MAX_URL_SIZE 4096 +#define MAX_URL_SIZE 8192 /** size of probe buffer, for guessing file type from file contents */ #define PROBE_BUF_MIN 2048 -- 2.39.2 (Apple Git-143) --------------KU7ryRdsaW6jIZC6yUhZulha Content-Type: text/x-patch; charset=UTF-8; name="0001-libavformat-increase-MAX_URL_SIZE.patch" Content-Disposition: attachment; filename="0001-libavformat-increase-MAX_URL_SIZE.patch" Content-Transfer-Encoding: base64 RnJvbSBiZmMwZGMzZTY4ZjFkMWNlYzMzMDg0YmJlYTBkZDg3ZTE5ZDMyNWQ1IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQaW90ciBHYXNpb3Jvd3NraSA8cGlvdHJAbHdrcy5j b20+CkRhdGU6IFNhdCwgMjggT2N0IDIwMjMgMTQ6MDA6MzggKzAyMDAKU3ViamVjdDogW1BB VENIXSBsaWJhdmZvcm1hdDogaW5jcmVhc2UgTUFYX1VSTF9TSVpFCgpXaXRoIHRoZSByaXNl IG9mIG9iamVjdCBzdG9yYWdlLCBsaWtlIFMzLCBpdCBpcyBub3QgdW5jb21tb24gdG8gZ2Vu ZXJhdGUKbG9uZyBwcmUtc2lnbmVkIFVSTHMuIFdoZW4gYSBwcmUtc2lnbmVkIFVSTCBpcyBn ZW5lcmF0ZWQgdXNpbmcgYQpzaG9ydC1saXZlZCBjcmVkZW50aWFscyBpdCBtYXkgaW5jbHVk ZSBhIHF1ZXJ5IHBhcmFtZXRlciBjYWxsZWQKWC1BbXotU2VjdXJpdHktVG9rZW4gdGhhdCBp cyA0a0Igb24gaXRzIG93bi4KVGhlIGN1cnJlbnQgTUFYX1VSTF9TSVpFIHdpbGwgdHJpbSB0 aGUgVVJMIHdpdGggbm8gYW55IGVycm9ycyBvcgp3YXJuaW5ncyBhbmQgdGhlIHJlcXVlc3Qg d2lsbCBmYWlsIHdpdGggYSBodHRwIDQwMCBlcnJvci4KClNpZ25lZC1vZmYtYnk6IFBpb3Ry IEdhc2lvcm93c2tpIDxwaW90ckBsd2tzLmNvbT4KLS0tCiBsaWJhdmZvcm1hdC9pbnRlcm5h bC5oIHwgMiArLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9u KC0pCgpkaWZmIC0tZ2l0IGEvbGliYXZmb3JtYXQvaW50ZXJuYWwuaCBiL2xpYmF2Zm9ybWF0 L2ludGVybmFsLmgKaW5kZXggNzcwMjk4NmM5Yy4uZDY0NjViYWQ3YyAxMDA2NDQKLS0tIGEv bGliYXZmb3JtYXQvaW50ZXJuYWwuaAorKysgYi9saWJhdmZvcm1hdC9pbnRlcm5hbC5oCkBA IC0yNyw3ICsyNyw3IEBACiAKICNpbmNsdWRlICJhdmZvcm1hdC5oIgogCi0jZGVmaW5lIE1B WF9VUkxfU0laRSA0MDk2CisjZGVmaW5lIE1BWF9VUkxfU0laRSA4MTkyCiAKIC8qKiBzaXpl IG9mIHByb2JlIGJ1ZmZlciwgZm9yIGd1ZXNzaW5nIGZpbGUgdHlwZSBmcm9tIGZpbGUgY29u dGVudHMgKi8KICNkZWZpbmUgUFJPQkVfQlVGX01JTiAyMDQ4Ci0tIAoyLjM5LjIgKEFwcGxl IEdpdC0xNDMpCgo= --------------KU7ryRdsaW6jIZC6yUhZulha Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --------------KU7ryRdsaW6jIZC6yUhZulha--