From: Lynne via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Lynne <dev@lynne.ee>
Subject: Re: [FFmpeg-devel] [PATCH 6/6] aacdec_usac, aacsbr: implement SBR support for USAC
Date: Mon, 17 Jun 2024 21:01:16 +0200
Message-ID: <036e660f-83b9-4c23-8df8-f91514a93b85@lynne.ee> (raw)
In-Reply-To: <171860975126.28895.10121911707227811924@lain.khirnov.net>
[-- Attachment #1.1.1.1: Type: text/plain, Size: 532 bytes --]
On 17/06/2024 09:35, Anton Khirnov wrote:
> No tests?
Tests for this particular part are tricky. We still have the SBR issue
where we add a single sample of delay to the output, which the reference
samples and their decodings do not. Adding a test would mean modifying
the samples in a way where we would not be able to use them after fixing
this (in addition to all the other regular AAC samples with SBR we have
that would become irrelevant).
My plan is to fix this after this patch, as its a troublesome topic.
[-- Attachment #1.1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 637 bytes --]
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-06-17 19:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-16 8:54 [FFmpeg-devel] [PATCH 1/6] aacdec_usac: apply specification fix M55715 Lynne via ffmpeg-devel
2024-06-16 8:54 ` [FFmpeg-devel] [PATCH 2/6] aac: expose ff_aac_sample_rate_idx() in aac.h Lynne via ffmpeg-devel
2024-06-16 8:54 ` [FFmpeg-devel] [PATCH 3/6] aacdec_ac: fix an overread Lynne via ffmpeg-devel
2024-06-16 8:54 ` [FFmpeg-devel] [PATCH 4/6] aacdec_usac: rename noise_scale to noise_bands Lynne via ffmpeg-devel
2024-06-16 8:54 ` [FFmpeg-devel] [PATCH 5/6] aacdec_usac: remove custom rate_idx and use standard variable for it Lynne via ffmpeg-devel
2024-06-16 8:54 ` [FFmpeg-devel] [PATCH 6/6] aacdec_usac, aacsbr: implement SBR support for USAC Lynne via ffmpeg-devel
2024-06-17 7:35 ` Anton Khirnov
2024-06-17 19:01 ` Lynne via ffmpeg-devel [this message]
2024-06-17 19:04 ` Lynne via ffmpeg-devel
2024-06-26 7:29 ` Anton Khirnov
2024-06-20 2:12 ` Lynne via ffmpeg-devel
2024-06-23 7:11 ` Lynne via ffmpeg-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=036e660f-83b9-4c23-8df8-f91514a93b85@lynne.ee \
--to=ffmpeg-devel@ffmpeg.org \
--cc=dev@lynne.ee \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git