From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8DBE242FAE for ; Mon, 14 Nov 2022 01:19:49 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D4BAB68BD2E; Mon, 14 Nov 2022 03:19:46 +0200 (EET) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4584A68BD1D for ; Mon, 14 Nov 2022 03:19:39 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668388784; x=1699924784; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=bYi/DNMWpHyj4cjyElYrsxZSVAZ03BHb4zpqU16aIZY=; b=Nwm5UY4RerWn3eGSNwikbO//P8llvjSRL4pwf5V1LUM9/qgRb1eQivIQ pSmKbfyOcpXMH8OD8Z/95VCuQ+F5pkWpmkeX0Lh0n9U34If+xZFh3w08o 4q5k8F2YKM6/G5GL2yUB+nWLIyxw1r+WPnoF9xMTvSt9mC7tAzMyMEvQr o6E80DggjDnCo9nwB7lT4v1OUCt2tsIqxRm7nTmtHm4Ko/GYkiQfwpNID 9A9yEpTMt/Ww/gOKUz4SYRdqt8NSjR8wtalETvw5x8utVx8aRYaAUWXbn ckbaTaY5X1ModldrL+xp+ELtvK0ixf4g9u7M/Hox1TlG9mYtjFYkOhGne g==; X-IronPort-AV: E=McAfee;i="6500,9779,10530"; a="373985834" X-IronPort-AV: E=Sophos;i="5.96,161,1665471600"; d="scan'208";a="373985834" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Nov 2022 17:19:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10530"; a="707117575" X-IronPort-AV: E=Sophos;i="5.96,161,1665471600"; d="scan'208";a="707117575" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga004.fm.intel.com with ESMTP; 13 Nov 2022 17:19:34 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sun, 13 Nov 2022 17:19:33 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Sun, 13 Nov 2022 17:19:33 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Sun, 13 Nov 2022 17:19:33 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UX8UgYP3tx4BnnT+RZJRLt/8Qf5DUyN0SWwLdFbQd7HB+OaON6qcaRDqCT3jJ8bCDczpQjXYPLiKhtReSWc5FKqNQbDK9qtGJyCrg36KixFwG+9LNJ/GIGSYVfsja9wqfZDyN1r2BNPjP4GHbeWjA7yHguqKnQWVNrQUaSb58b1esUYg6aF43kpmsuf1Z42nWbtj2vYrumkJf9B90ZQcl7RvDqZxRwBV33mMgmiywUiF77kTw1nhy7hD0Hvt/4JGQFpE/Tn086qZaQ7TMIIHEAAVOwy3YrdRQAPS/V8KnnDiEFiDSrjv+8i3t4e0eTpyQjxSVXujUUZlnzkAAMnVCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bYi/DNMWpHyj4cjyElYrsxZSVAZ03BHb4zpqU16aIZY=; b=Xo7p1EI9/u/usKVjk26Y0UeTpoAuhAS68Fx1RqWivD9cRk/yfXtPhhSq0w3GECo3NNWJLal/Jp2OZbJv07Zi3sM+FY8GHqF4XRrZLIX6KhJAu8JD62GUvTBU4UKsY5V/02KaISDGqEBSqJfyNw1KcqQNiq7VjTnbGF6NCasY+/kXDZ/yFkzyHTcQ7GN0fNza1BMeVbm65QMIrYVX4Tq6bU/6ss8iwTtFvBVSvefhDKIvKnADha+kgB3GL6oVk04uk6WpQ1g+KSdRjSn7E49W7egv+yUVB+xAGiaJ/DfqCnSzQ+PGYSqwCL5ekVgpT5wbhREQu5tlg+CK+3pLXWTigA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5030.namprd11.prod.outlook.com (2603:10b6:510:41::5) by DM4PR11MB6237.namprd11.prod.outlook.com (2603:10b6:8:a9::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17; Mon, 14 Nov 2022 01:19:32 +0000 Received: from PH0PR11MB5030.namprd11.prod.outlook.com ([fe80::2aa4:31ea:cc5e:5176]) by PH0PR11MB5030.namprd11.prod.outlook.com ([fe80::2aa4:31ea:cc5e:5176%4]) with mapi id 15.20.5813.017; Mon, 14 Nov 2022 01:19:31 +0000 From: "Wang, Fei W" To: "ffmpeg-devel@ffmpeg.org" , "Xiang, Haihao" Thread-Topic: [FFmpeg-devel] [PATCH v4 2/2] lavc/vaapi_decode: add support for HWACCEL_CAP_RESET_WITHOUT_UNINIT Thread-Index: AQHY82eIZeUXtt/dIEqy0KxPk7Rfq645GUqAgASOPwA= Date: Mon, 14 Nov 2022 01:19:31 +0000 Message-ID: <032d4e510af1f87b3afb09529e6c0b0110036750.camel@intel.com> References: <20221108114501.570349-1-fei.w.wang@intel.com> <20221108114501.570349-2-fei.w.wang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Evolution 3.36.5-0ubuntu1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5030:EE_|DM4PR11MB6237:EE_ x-ms-office365-filtering-correlation-id: f671b151-0ba8-4da8-196c-08dac5de48ad x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: q+WzIYK9gUN1OKtN6Vh2rZP7QsTAlUk6l3bEMo9188jraOqu0WyC9Qp4DBso41lwOKA9NW1JRgbGOBdLdiaERIKoiLPywUCYx5hb8SoNfT4dqwCVtCdmsftfQZSya3SvqxyWqJK5IGUoKV2QVhOlXGJP/JU+hPMUaGxkfle1MyX7j1JuG5c6W+DG3G4U09/ejVDchsD2QkQiSTR9GkTgKmpv+Dac7BfBvz3O5oMgadk8lsgNmYR7lyc2zrMXpkGy/oT44rngNYUJI9DdiiHx7yzyJw4BwVl6Y0A8OXp4rKMwveAYI+v5blitLsLHvqgm+P1XsaJLZQqCPfZB6XVvu7E3/TTppCKyuzoFBUUa2Ns9uTwDXFMoV+MtMwaKhztBTgUKse65ojxrsAQovasHC21XzF9OGtnwO87tVjDaxrzF/yPJ8KSRTHksSrJy5Qb7vvMc7goZBALfLhd5ZpOfT7ckWm8OZkpVr5toGXwuDJItS10BlpNCoFunA0dxLEbo5IV4PyyoYfSUekmTvzpe1tzyDEKbAEltMZDut7DFxWOg/ExLdgTqP9I7PNGynVH0eHcdKKZNnxUqxtCd1IvupEGuNl0dF9c3fXrsXNXZC53LEZyNf0kkTo2/M2uJclgVOo2GlffAlcPNHUrwkGBcYfl9LTpsJKKGjOanU1kfCdQKsV87bCZgrwaW5kVhHgvensuYtwVs9uPrdIho5yRMs50ycJZxvu7v0IBMZswK/GlH6WAQLe5AFkKDz9nVHTC7vZIfTsWBiLv8WyYUgz20nnDE6WPhQEntchjSBo7Nm3c= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5030.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(136003)(366004)(396003)(346002)(376002)(39860400002)(451199015)(478600001)(71200400001)(6506007)(6636002)(6486002)(966005)(110136005)(38070700005)(6512007)(26005)(82960400001)(316002)(38100700002)(86362001)(91956017)(122000001)(8936002)(8676002)(76116006)(66946007)(66556008)(66476007)(66446008)(64756008)(41300700001)(36756003)(2616005)(5660300002)(186003)(83380400001)(2906002)(4001150100001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?MXgrVEQ1S3diN0tqSGF5QjhyaWlzNE9rQWF6TVNZdnhiVko5YXdaMXo1QTlT?= =?utf-8?B?V2lpSHZyaU53REZXVHZVSElqMWh4VGJyUVhISUphRE9TMGg0NDh3SDFHQnVX?= =?utf-8?B?aFZYQURnb0RtSHcwOHcrR20xWjkrdC82c3Rkc2hTMEpYMXRwWjVkODF1RmFq?= =?utf-8?B?VnI3eXptb08wZzVoeHYvMmRCUktzMUhVRkovUm5hUDVxcmpQZmQvTURQalN3?= =?utf-8?B?WlVQZFFKcUJybG41TnhUYTcwR0U2NHRSclNQbEdXamxFNXIrU3pZYUZ4bkM3?= =?utf-8?B?T3ptVEszbmJkbzJxVEJzZDh6Y2dtQU40YWt5dmpIZDVYQ2V1YjlZeDFjc2pZ?= =?utf-8?B?N0J2QVNDTmEweHhhRXd0UVRWaUsrM3J5dFVRMzYrTkJ2Um1SeGpObDJjclJY?= =?utf-8?B?V3Y2ZnhyQ0xranBjdmszbmVXbkJhcWk4Q244UWZBaStueWhUTFlGODRsWHF1?= =?utf-8?B?SVVTV2s5KzZaSDdJS2M2cVhOSEp0bUNpeUpRZ1VWU28yc1hKelZKSGVaNTJw?= =?utf-8?B?aFVYZU9ZUkVVL2I3cWM3SXY0a0cxUDFoOGlhVEswSERpNGNSU2tnWWN3dWlr?= =?utf-8?B?SGJhdUd2ZXJRS1cySngyV010Y054T1o5SlNjNVBpYXB1RGNDSllLcVdmV1d4?= =?utf-8?B?ZXRYNjUwVVBOQzRISUpNcncxQWN4aGN4QnRoOWorZnB6WFRxWWVVQlUwRklw?= =?utf-8?B?K2JMUzlMbmVzRitvTDFPaVVQTGxjSXQrNkpGRlE3ZTFWUVJBWTlEQ1NjNm42?= =?utf-8?B?ck0rR3JtbFFxbUVvL3NIenkrdGxCQ3d1SFBvZXRXcHptZHZHWVdoRUhIdlQy?= =?utf-8?B?ck04TFkwcEFuOEM2UFRrdWpIRER2TXdRVDg0MldLSkVYM0hsVU8vUmFVeXJv?= =?utf-8?B?TDEzNWt0a2dZdUR6TVBrZlBid29ycjNNa3BCVXBrK2VZTk40MXN1dFVybGF4?= =?utf-8?B?eHF5S094ZXIrYkNWZkhPamE5OHc4Nm1lTXpjUHM3a1hpWXNSNVR6TDZFcytV?= =?utf-8?B?N09odXpDRW1BRzdVeWJCaW1sNlBFenlGR3VYS0psRmo0UjdWWldwWldocGtr?= =?utf-8?B?RTc3cmszMFo5eEpMMmhwdFByNzh1d0tWbWFDNXRZYUpBdEJWVVVSd2o1YVFM?= =?utf-8?B?Umx0dDUrcXlSMEY1Z3dyWjZkNDQveVhxYnF6MEsyamtnOFgvZkE4dTAyM2Y2?= =?utf-8?B?T21LbStJYW1YQmRqcHJpcHVrcVdSeGRyY1JBUk5PNTFXTEhSLzh2R2FDM2t3?= =?utf-8?B?VW1YSE8zS0Z6N3RKY0YxYUk0NC9Pa25sSWpXMlgxdzNTdnprd0szckFZcDdU?= =?utf-8?B?L01HSkFKNDl6VktPbjc4WnhuaGEyc2toYVplL25ycXlHa015UTQvR3c4cWh4?= =?utf-8?B?cmRvUTNnaDB6bDFMQTBFRkpiVjBoM2hsMjRWNW9Ed1lOYWJ6bDZNWnM3ZTR1?= =?utf-8?B?YUVOb0VRRDNDN1dUZDBJMEFSSURMSlR3ZW5TSnBadEZVV2h0SGhjbURIREJn?= =?utf-8?B?WXFWTGZ0OEpSNHN4am00ME44T1ArMnQ5OUx6d3d2R1NEY3d5NW5ub3l6cjAr?= =?utf-8?B?UEtXZjN3ekJFSnBZeDlFc1ptUThlY3NQTFRRSW1yQ1Z2WWl0UFJ6b3R6YVhk?= =?utf-8?B?NTY4bjZQc2JLdkNjWk9DeEQrTlBWU1UzTmFjYUorVnZGeUJRQXpZbDBTTTFV?= =?utf-8?B?TEZDWC9sN2hGRTBoVkRtbCtweSszRDBZTlZ0QWxhaGZkUnZwbnIyRFVjS1pP?= =?utf-8?B?UWpXeTBKY3lkMSs5cDdXWlg4MXBkSWFFVS9zZTdGSFc5YXJiQ0RZNFNCcVd1?= =?utf-8?B?TEpKQ1drNlZyMVNaMUh1SU5PWFBxUS8yR0prVks3NW9mV01KQW9XYng3MlN5?= =?utf-8?B?azFqbkVmQ2VFNlloVG9FS1UwUnVDM3VNV1F0OEJ0ZWZ2WlFweXFrV1FseHpM?= =?utf-8?B?N0ZDcE9lcXhyRFM3Mnpxc2hPWlRJU1NPYWRzTW1xQ29LdmVRVHhRakxNRlVa?= =?utf-8?B?djczTkNLMk00K3l2Z0pRbEx4TldHNzYxcHVra3BTVkg4TjlGdjVuRDJMR2x0?= =?utf-8?B?RXlENnp3ZmlOaUh5WTI4WE9wZUY5TWtPRy9zNWFTS1F0eXJHQXRtM29kNGZ6?= =?utf-8?B?U3BNVVUrTy9CZlNIKy8yeFNlMmszVlJXdnVCS2ppbk5lazV6YlNqOE9sRW5m?= =?utf-8?B?UWc9PQ==?= Content-ID: <61370F2AD568DE43B490B893F78DC9E3@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5030.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f671b151-0ba8-4da8-196c-08dac5de48ad X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Nov 2022 01:19:31.8749 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yimhO+iiOEfrbv+GyrWPHAyZez2So/J9/5YlSciWTotADri6opzD9gDIAjYow3iU6eFNsFY26DpTu+F+Y7UCmw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6237 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v4 2/2] lavc/vaapi_decode: add support for HWACCEL_CAP_RESET_WITHOUT_UNINIT X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, 2022-11-11 at 03:45 +0000, Xiang, Haihao wrote: > On Tue, 2022-11-08 at 19:45 +0800, Fei Wang wrote: > > This can fix vp9 decode image corruption when the frame size is > > change, > > but the pervious frames still be referenced. > > > > Surfaces don't need to be bound to vaContext only after VAAPI > > 1.0.0: > > https://github.com/intel/libva/commit/492b692005ccd0d8da190209d5b3ae7b7825f4b8 > > > > Signed-off-by: Fei Wang > > --- > > libavcodec/vaapi_decode.c | 41 ++++++++++++++++++++++------------- > > ---- > > libavcodec/vaapi_vp9.c | 4 ++++ > > 2 files changed, 27 insertions(+), 18 deletions(-) > > > > diff --git a/libavcodec/vaapi_decode.c b/libavcodec/vaapi_decode.c > > index 134f10eca5..618f3c3e0a 100644 > > --- a/libavcodec/vaapi_decode.c > > +++ b/libavcodec/vaapi_decode.c > > @@ -658,8 +658,10 @@ int ff_vaapi_decode_init(AVCodecContext > > *avctx) > > VAStatus vas; > > int err; > > > > - ctx->va_config = VA_INVALID_ID; > > - ctx->va_context = VA_INVALID_ID; > > + if (!ctx->va_config && !ctx->va_context) { > > + ctx->va_config = VA_INVALID_ID; > > + ctx->va_context = VA_INVALID_ID; > > + } > > 0 is valid for VA config and context, it is possible the underlying > driver > creates VA config and context with id 0. Fixed in V5. Thanks. Fei > > Thanks > Haihao > > > > > err = ff_decode_get_hw_frames_ctx(avctx, > > AV_HWDEVICE_TYPE_VAAPI); > > if (err < 0) > > @@ -670,24 +672,27 @@ int ff_vaapi_decode_init(AVCodecContext > > *avctx) > > ctx->device = ctx->frames->device_ctx; > > ctx->hwctx = ctx->device->hwctx; > > > > - err = vaapi_decode_make_config(avctx, ctx->frames->device_ref, > > - &ctx->va_config, NULL); > > - if (err) > > - goto fail; > > - > > - vas = vaCreateContext(ctx->hwctx->display, ctx->va_config, > > - avctx->coded_width, avctx->coded_height, > > - VA_PROGRESSIVE, > > - ctx->hwfc->surface_ids, > > - ctx->hwfc->nb_surfaces, > > - &ctx->va_context); > > - if (vas != VA_STATUS_SUCCESS) { > > - av_log(avctx, AV_LOG_ERROR, "Failed to create decode " > > - "context: %d (%s).\n", vas, vaErrorStr(vas)); > > - err = AVERROR(EIO); > > - goto fail; > > + if (ctx->va_config == VA_INVALID_ID) { > > + err = vaapi_decode_make_config(avctx, ctx->frames- > > >device_ref, > > + &ctx->va_config, NULL); > > + if (err) > > + goto fail; > > } > > > > + if (ctx->va_context == VA_INVALID_ID) { > > + vas = vaCreateContext(ctx->hwctx->display, ctx->va_config, > > + avctx->coded_width, avctx- > > >coded_height, > > + VA_PROGRESSIVE, > > + ctx->hwfc->surface_ids, > > + ctx->hwfc->nb_surfaces, > > + &ctx->va_context); > > + if (vas != VA_STATUS_SUCCESS) { > > + av_log(avctx, AV_LOG_ERROR, "Failed to create decode " > > + "context: %d (%s).\n", vas, vaErrorStr(vas)); > > + err = AVERROR(EIO); > > + goto fail; > > + } > > + } > > av_log(avctx, AV_LOG_DEBUG, "Decode context initialised: " > > "%#x/%#x.\n", ctx->va_config, ctx->va_context); > > > > diff --git a/libavcodec/vaapi_vp9.c b/libavcodec/vaapi_vp9.c > > index 776382f683..245b7a1b3a 100644 > > --- a/libavcodec/vaapi_vp9.c > > +++ b/libavcodec/vaapi_vp9.c > > @@ -181,5 +181,9 @@ const AVHWAccel ff_vp9_vaapi_hwaccel = { > > .uninit = ff_vaapi_decode_uninit, > > .frame_params = ff_vaapi_common_frame_params, > > .priv_data_size = sizeof(VAAPIDecodeContext), > > +#if VA_CHECK_VERSION(1, 0, 0) > > + .caps_internal = HWACCEL_CAP_ASYNC_SAFE | > > HWACCEL_CAP_RESET_WITHOUT_UNINIT, > > +#else > > .caps_internal = HWACCEL_CAP_ASYNC_SAFE, > > +#endif > > }; _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".