Re: [FFmpeg-devel] [PATCH v3 1/2] avcodec/libsvtav1: update avctx bit rate according to RC mode

From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v3 1/2] avcodec/libsvtav1: update avctx bit rate according to RC mode
Date: Mon, 9 May 2022 16:07:19 -0300
Message-ID: <032a0aab-af7a-36cc-61d6-94bf43f84d92@gmail.com> (raw)
In-Reply-To: <20220509184728.10265-1-jeebjp@gmail.com>

On 5/9/2022 3:47 PM, Jan Ekström wrote:
> This way we can filter out the default value for this member, which
> is nonzero. Bases on the current affairs that bit rate based rate
> control is nonzero in SVT-AV1.
> ---
>   libavcodec/libsvtav1.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c
> index b4112004ad..2c4ddd4641 100644
> --- a/libavcodec/libsvtav1.c
> +++ b/libavcodec/libsvtav1.c
> @@ -297,7 +297,8 @@ static int config_enc_params(EbSvtAv1EncConfiguration *param,
>           param->profile = FF_PROFILE_AV1_HIGH;
>       }
>   
> -    avctx->bit_rate                 = param->target_bit_rate;
> +    avctx->bit_rate = param->rate_control_mode > 0 ?
> +                      param->target_bit_rate : 0;
>   
>       return 0;
>   }

Set LGTM.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".