* [FFmpeg-devel] [PATCH] avcodec/hevc_ps: Fix UB 1 << 31
@ 2024-06-01 13:13 Andreas Rheinhardt
2024-06-01 15:01 ` Tomas Härdin
0 siblings, 1 reply; 3+ messages in thread
From: Andreas Rheinhardt @ 2024-06-01 13:13 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
libavcodec/hevc_ps.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/hevc_ps.c b/libavcodec/hevc_ps.c
index 7b486ce0af..1a459ad054 100644
--- a/libavcodec/hevc_ps.c
+++ b/libavcodec/hevc_ps.c
@@ -200,7 +200,7 @@ int ff_hevc_decode_short_term_rps(GetBitContext *gb, AVCodecContext *avctx,
}
for (unsigned i = 0; i < FF_ARRAY_ELEMS(used); i++)
- rps->used |= used[i] * (1 << i);
+ rps->used |= used[i] * (1U << i);
} else {
unsigned int nb_positive_pics;
--
2.40.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avcodec/hevc_ps: Fix UB 1 << 31
2024-06-01 13:13 [FFmpeg-devel] [PATCH] avcodec/hevc_ps: Fix UB 1 << 31 Andreas Rheinhardt
@ 2024-06-01 15:01 ` Tomas Härdin
2024-06-01 15:10 ` Andreas Rheinhardt
0 siblings, 1 reply; 3+ messages in thread
From: Tomas Härdin @ 2024-06-01 15:01 UTC (permalink / raw)
To: FFmpeg development discussions and patches
lör 2024-06-01 klockan 15:13 +0200 skrev Andreas Rheinhardt:
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
> libavcodec/hevc_ps.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/hevc_ps.c b/libavcodec/hevc_ps.c
> index 7b486ce0af..1a459ad054 100644
> --- a/libavcodec/hevc_ps.c
> +++ b/libavcodec/hevc_ps.c
> @@ -200,7 +200,7 @@ int ff_hevc_decode_short_term_rps(GetBitContext
> *gb, AVCodecContext *avctx,
> }
>
> for (unsigned i = 0; i < FF_ARRAY_ELEMS(used); i++)
> - rps->used |= used[i] * (1 << i);
> + rps->used |= used[i] * (1U << i);
Why not just (uint32_t)used[i] << i?
/Tomas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avcodec/hevc_ps: Fix UB 1 << 31
2024-06-01 15:01 ` Tomas Härdin
@ 2024-06-01 15:10 ` Andreas Rheinhardt
0 siblings, 0 replies; 3+ messages in thread
From: Andreas Rheinhardt @ 2024-06-01 15:10 UTC (permalink / raw)
To: ffmpeg-devel
Tomas Härdin:
> lör 2024-06-01 klockan 15:13 +0200 skrev Andreas Rheinhardt:
>> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
>> ---
>> libavcodec/hevc_ps.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/libavcodec/hevc_ps.c b/libavcodec/hevc_ps.c
>> index 7b486ce0af..1a459ad054 100644
>> --- a/libavcodec/hevc_ps.c
>> +++ b/libavcodec/hevc_ps.c
>> @@ -200,7 +200,7 @@ int ff_hevc_decode_short_term_rps(GetBitContext
>> *gb, AVCodecContext *avctx,
>> }
>>
>> for (unsigned i = 0; i < FF_ARRAY_ELEMS(used); i++)
>> - rps->used |= used[i] * (1 << i);
>> + rps->used |= used[i] * (1U << i);
>
> Why not just (uint32_t)used[i] << i?
>
Pondered doing that, but didn't want to change the code too much. But
I'll do it now given that you desired it.
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-06-01 15:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-06-01 13:13 [FFmpeg-devel] [PATCH] avcodec/hevc_ps: Fix UB 1 << 31 Andreas Rheinhardt
2024-06-01 15:01 ` Tomas Härdin
2024-06-01 15:10 ` Andreas Rheinhardt
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git