From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 2/2] avcodec/jpeg2000dec: jpeg2000 has its own lowres option
Date: Sat, 24 Jun 2023 17:56:33 -0300
Message-ID: <02dec62b-58bf-5d98-ceb8-4f6105255bf5@gmail.com> (raw)
In-Reply-To: <3d1d40b6c3d589d648f6386b1bc0ffa8ccabdf38.camel@haerdin.se>
On 6/24/2023 5:46 PM, Tomas Härdin wrote:
> lör 2023-06-24 klockan 19:54 +0200 skrev Paul B Mahol:
>> On Sat, Jun 24, 2023 at 12:53 PM Tomas Härdin <git@haerdin.se> wrote:
>>
>>> lör 2023-06-10 klockan 20:31 +0200 skrev Michael Niedermayer:
>>>> jpeg2000 overrides the global lowres variable with a lowres field
>>>> called reduction_factor
>>>> ffmpeg -lowres X causes the reduction_factor to be set
>>>> ffplay -lowres X causes both lowres and the reduction_factor to
>>>> be
>>>> set
>>>> ossfuss sets only lowres
>>>
>>> Why does jpeg2000dec have its own -lowres? Does lavc reset it
>>> somewhere
>>> to where the decoder can't make use of the avctx-level setting?
>>>
>>>
>> Libav removed lowres from avctx, but same was not done here.
>>
>> IMHO lowres is codec-specific thing and only codecs supporting it
>> should
>> have private option to change it.
>
> Enough codecs support lowres that marking support for it in codec caps
> may be worthwhile. Something to consider for the future.
There's AVCodec.max_lowres, which when not zero it means the decoder
supports lowres.
>
> /Tomas
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-06-24 20:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-10 18:31 [FFmpeg-devel] [PATCH 1/2] avcodec/jpeg2000dec: Check for reduction factor and image offset Michael Niedermayer
2023-06-10 18:31 ` [FFmpeg-devel] [PATCH 2/2] avcodec/jpeg2000dec: jpeg2000 has its own lowres option Michael Niedermayer
2023-06-24 10:53 ` Tomas Härdin
2023-06-24 17:54 ` Paul B Mahol
2023-06-24 20:46 ` Tomas Härdin
2023-06-24 20:56 ` James Almer [this message]
2023-09-04 19:00 ` Michael Niedermayer
2023-06-24 10:50 ` [FFmpeg-devel] [PATCH 1/2] avcodec/jpeg2000dec: Check for reduction factor and image offset Tomas Härdin
2023-06-24 19:51 ` Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02dec62b-58bf-5d98-ceb8-4f6105255bf5@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git