From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B4C724AE01 for ; Tue, 21 May 2024 16:50:28 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C4C6068D307; Tue, 21 May 2024 19:50:25 +0300 (EEST) Received: from shout02.mail.de (shout02.mail.de [62.201.172.25]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 63A8368D13B for ; Tue, 21 May 2024 19:50:19 +0300 (EEST) Received: from postfix01.mail.de (postfix01.bt.mail.de [10.0.121.125]) by shout02.mail.de (Postfix) with ESMTP id CF3DA240B38 for ; Tue, 21 May 2024 18:50:18 +0200 (CEST) Received: from smtp01.mail.de (smtp01.bt.mail.de [10.0.121.211]) by postfix01.mail.de (Postfix) with ESMTP id B701780292 for ; Tue, 21 May 2024 18:50:18 +0200 (CEST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp01.mail.de (Postfix) with ESMTPSA id 6DD6E24185B for ; Tue, 21 May 2024 18:50:18 +0200 (CEST) Message-ID: <028394bd-36ce-4e49-9d31-aa608bdbd677@mail.de> Date: Tue, 21 May 2024 18:50:16 +0200 MIME-Version: 1.0 To: James Zern via ffmpeg-devel References: <20240417192012.22436-1-thilo.borgmann@mail.de> <3c5c17dd-1a52-477d-ad4f-3796044174a5@mail.de> Content-Language: en-US In-Reply-To: X-purgate: clean X-purgate: This mail is considered clean (visit http://www.eleven.de for further information) X-purgate-type: clean X-purgate-Ad: Categorized by eleven eXpurgate (R) http://www.eleven.de X-purgate: This mail is considered clean (visit http://www.eleven.de for further information) X-purgate: clean X-purgate-size: 1264 X-purgate-ID: 154282::1716310218-05DBE670-306CC99C/0/0 Subject: Re: [FFmpeg-devel] [PATCH v12 0/8] [WIP] webp: add support for animated WebP decoding X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Thilo Borgmann via ffmpeg-devel Reply-To: FFmpeg development discussions and patches Cc: Thilo Borgmann Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Hi, [...] >>> Tests mostly work for me. There are a few images (that I reported >>> earlier) that give: >> >> thanks for testing! >> >> >>> Canvas change detected. The output will be damaged. Use -threads 1 >>> to try decoding with best effort. >>> They don't animate without that option and with it render incorrectly. >> >> That issue yields from the canvas frame being the synchronization object >> (ThreadFrame) - doing so prevents the canvas size changed mid-stream. >> _Maybe_ this can be fixed switching the whole frame multithreading away >> from ThreadFrame to sth else, not sure though and no experience with the >> alternatives (AVExecutor?). Maybe Andreas can predict if it's >> worth/valid to change that whole part of it? I'm not against putting >> more effort into it to get it right. I could fix 488x488.webp and have an almost identical output to libwebp. 488x488.webp features an ARGB canvas and has both, ARGB & YUVA420P p-frames. Do you have more files with other variations of canvas & p-frames? If they at all exist... e.g. canvas YUV and p-frames RGB? Pinged Meta as well for real-world samples. Will take some more days until I get feedback. Will then post the next iteration... Thanks, Thilo _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".