Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Thilo Borgmann via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: James Zern via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
Cc: Thilo Borgmann <thilo.borgmann@mail.de>
Subject: Re: [FFmpeg-devel] [PATCH v12 0/8] [WIP] webp: add support for animated WebP decoding
Date: Tue, 21 May 2024 18:50:16 +0200
Message-ID: <028394bd-36ce-4e49-9d31-aa608bdbd677@mail.de> (raw)
In-Reply-To: <CABWgkX+BY5nMT5O_bxYTjH4HAEMP5SxZNjTQPRXmc8_+cerMWg@mail.gmail.com>

Hi,

[...]
>>> Tests mostly work for me. There are a few images (that I reported
>>> earlier) that give:
>>
>> thanks for testing!
>>
>>
>>>     Canvas change detected. The output will be damaged. Use -threads 1
>>> to try decoding with best effort.
>>> They don't animate without that option and with it render incorrectly.
>>
>> That issue yields from the canvas frame being the synchronization object
>> (ThreadFrame) - doing so prevents the canvas size changed mid-stream.
>> _Maybe_ this can be fixed switching the whole frame multithreading away
>> from ThreadFrame to sth else, not sure though and no experience with the
>> alternatives (AVExecutor?). Maybe Andreas can predict if it's
>> worth/valid to change that whole part of it? I'm not against putting
>> more effort into it to get it right.

I could fix 488x488.webp and have an almost identical output to libwebp.

488x488.webp features an ARGB canvas and has both, ARGB & YUVA420P 
p-frames.

Do you have more files with other variations of canvas & p-frames? If 
they at all exist... e.g. canvas YUV and p-frames RGB?

Pinged Meta as well for real-world samples. Will take some more days 
until I get feedback. Will then post the next iteration...

Thanks,
Thilo
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2024-05-21 16:50 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-17 19:19 Thilo Borgmann via ffmpeg-devel
2024-04-17 19:19 ` [FFmpeg-devel] [PATCH v12 1/8] avcodec/webp: remove unused definitions Thilo Borgmann via ffmpeg-devel
2024-04-17 19:19 ` [FFmpeg-devel] [PATCH v12 2/8] avcodec/webp: separate VP8 decoding Thilo Borgmann via ffmpeg-devel
2024-04-17 19:19 ` [FFmpeg-devel] [PATCH v12 3/8] avcodec/bsf: Add awebp2webp bitstream filter Thilo Borgmann via ffmpeg-devel
2024-04-17 19:37   ` Thilo Borgmann via ffmpeg-devel
2024-04-17 19:20 ` [FFmpeg-devel] [PATCH v12 4/8] libavcodec/webp: add support for animated WebP Thilo Borgmann via ffmpeg-devel
2024-04-17 19:20 ` [FFmpeg-devel] [PATCH v12 5/8] avcodec/webp: make init_canvas_frame static Thilo Borgmann via ffmpeg-devel
2024-04-17 19:20 ` [FFmpeg-devel] [PATCH v12 6/8] libavformat/webp: add WebP demuxer Thilo Borgmann via ffmpeg-devel
2024-04-17 19:20 ` [FFmpeg-devel] [PATCH v12 7/8] fate: add test for animated WebP Thilo Borgmann via ffmpeg-devel
2024-04-17 19:20 ` [FFmpeg-devel] [PATCH v12 8/8] avcodec/webp: export XMP metadata Thilo Borgmann via ffmpeg-devel
2024-04-17 22:52 ` [FFmpeg-devel] [PATCH v12 0/8] [WIP] webp: add support for animated WebP decoding James Zern via ffmpeg-devel
2024-04-18 18:21   ` Thilo Borgmann via ffmpeg-devel
2024-04-18 19:38     ` James Zern via ffmpeg-devel
2024-05-21 16:50       ` Thilo Borgmann via ffmpeg-devel [this message]
2024-05-23  2:31         ` James Zern via ffmpeg-devel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=028394bd-36ce-4e49-9d31-aa608bdbd677@mail.de \
    --to=ffmpeg-devel@ffmpeg.org \
    --cc=thilo.borgmann@mail.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git