From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7011846876 for ; Thu, 22 Jun 2023 16:42:51 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E5B1B68C123; Thu, 22 Jun 2023 19:42:48 +0300 (EEST) Received: from mail-oa1-f46.google.com (mail-oa1-f46.google.com [209.85.160.46]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 48A4868BB90 for ; Thu, 22 Jun 2023 19:42:43 +0300 (EEST) Received: by mail-oa1-f46.google.com with SMTP id 586e51a60fabf-1a1fa977667so7281764fac.1 for ; Thu, 22 Jun 2023 09:42:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687452161; x=1690044161; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ItONdkCv2zrnZzJiUwOy5pwXlDKApQxxTLNW3CwPI18=; b=dfV7LyxCI1CzXP4JtsWM93ZTX6YwX2fPUOjp/TGkbQjAGPiX21eqINmInSeJ2MIbMT ziWsxw+EaqxKG5XL5TJDAOgeGt5R6l4ZzjkvB2ICFLs6aDsWvGh5vt9MrwytPwh85TfM 0ZHcdSCjcWlzx627uLowErrPXhXEB89tb8C9I75Mk6JuIUaIZB5TLrdIMr+Ge8Lfua1I OutEjfzMI0rYZnrjwScjh/6bD3lKC0Cj+R5EJgZcP9jXzialzpv/idQIl4HSO69zPGzn 3RweUJe4cKwjFjfeO4flIm7oHScWPnpuVvwI+J0UwXdciYIY9nqtDCx5/6bcudP+9T7A czcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687452161; x=1690044161; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ItONdkCv2zrnZzJiUwOy5pwXlDKApQxxTLNW3CwPI18=; b=hWkCZoG6T388EowCdGmqiQq7ldgB+rXu8pVg/hg6wA+jd/SH2rE54mFdh0ZHUTXKo3 TkPjvbce1KC5Y+cv9rAz4DzWpNrMr9P7LXEz6kw7eDHJP34YfowrvzzFe3nJG4Fd/SqR hUHJcSQiMbP2ZoOY3xOF/9BCD5CpTpbOBOSWFu7NBw1do8Vwi+7XTVz5buK4xbcw+r7O DTrUG1JaEUwU0R72aBtBmPQepB52tCvm7fpDaH59YBjFJOjbXzSwArvES+ofaOmfnFKl E9ZcBQSXI0jTNR9R60UgHfifBMOPxOsQNm2JA8OEcS8sK8iSaagiGMuL8rx798/cSCnk L25Q== X-Gm-Message-State: AC+VfDyyun3kLI+QU6iP0iULiqxE7LegbJCrEjzlhtw8hjH3HrgK6jZO a2IPTAHDCEQsGGtAg+K6Nn7A3vgyf18= X-Google-Smtp-Source: ACHHUZ4Z3aZMDBgo3LpFpaWi5nl9KASwaav0RWMnfPtHfCbTKQCK1blvWKyCIyNXhN4icp6d3tACgw== X-Received: by 2002:a05:6870:c799:b0:19f:9f91:fa4a with SMTP id dy25-20020a056870c79900b0019f9f91fa4amr16855800oab.55.1687452161328; Thu, 22 Jun 2023 09:42:41 -0700 (PDT) Received: from [192.168.0.12] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id z12-20020a056870738c00b00172ac40356csm4318209oam.50.2023.06.22.09.42.40 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Jun 2023 09:42:40 -0700 (PDT) Message-ID: <020f7a32-60c4-22c4-19e9-9c25fef3b108@gmail.com> Date: Thu, 22 Jun 2023 13:42:39 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20230618222805.4054410-1-michael@niedermayer.cc> <20230622134328.GA3250409@pb2> <6f1c5b3a-99cb-c2e2-41fd-da0a1273b9fe@gmail.com> <20230622150527.GC3250409@pb2> <8e1965cc-9479-5fd1-0b0b-dbbe6a26cf36@gmail.com> <20230622162625.GD3250409@pb2> From: James Almer In-Reply-To: <20230622162625.GD3250409@pb2> Subject: Re: [FFmpeg-devel] [PATCH v2] avformat: add Software Defined Radio support X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 6/22/2023 1:26 PM, Michael Niedermayer wrote: > On Thu, Jun 22, 2023 at 12:10:06PM -0300, James Almer wrote: >> On 6/22/2023 12:05 PM, Michael Niedermayer wrote: >>> On Thu, Jun 22, 2023 at 10:55:44AM -0300, James Almer wrote: >>>> On 6/22/2023 10:43 AM, Michael Niedermayer wrote: >>>>> On Mon, Jun 19, 2023 at 12:28:05AM +0200, Michael Niedermayer wrote: >>>>>> Signed-off-by: Michael Niedermayer >>>>>> --- >>>>>> configure | 4 + >>>>>> doc/demuxers.texi | 71 ++ >>>>>> libavformat/Makefile | 2 + >>>>>> libavformat/allformats.c | 2 + >>>>>> libavformat/sdrdemux.c | 1739 ++++++++++++++++++++++++++++++++++++++ >>>>>> 5 files changed, 1818 insertions(+) >>>>>> create mode 100644 libavformat/sdrdemux.c >>>>> >>>>> Ill post a v3 later today or tomorrow that makes this work with the RTL-SDR Blog V3 >>>> >>>> Shouldn't the SDR "demuxer" be in libavdevice? Being AVFMT_NOFILE and pretty >>>> much a capture device, it seems to me that's the proper place. >>>> I guess the problem arises with the sdrfile demuxer, which shares code with >>>> the other one. >>> >>> I have no oppinon on this. I can move it to libavdevice if people prefer. >>> do people prefer libavdevice for this ? >> >> I do. It's a capture device and depends on an external library to interface >> with hardware. And like i said, you can keep the file demuxer in lavf, where >> it does fit. > > anyone objects if i move sdrfile then too into libavdevice ? because its the > same code basically. Otherwise it would have to be some sort of #include of c > file accross libs It does not belong in lavd. The doxy in avdevice.h states "the (de)muxers in libavdevice are of the AVFMT_NOFILE type". And you can make the common code avpriv_ since both libraries are basically version locked. There's no need to duplicate it, but if you prefer that, you can indeed do an #include c file using the SHLIBOBJS list in Makefile which will trigger on shared builds. > > >> >>> >>> >>> personally i think libavdevice should be merged with libavformat. >> >> It's been suggested plenty of times. Anton attempted to at least kickstart >> it once, but his plan was shot down. >> No one has tried anything ever since. > > How was it shut down ? > 1. sent patch > 2. apply it > I think it should be done with the next major ABI bump > > thx > > [...] > > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".