From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D165646276 for ; Thu, 11 May 2023 14:00:01 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1CED168BDBC; Thu, 11 May 2023 16:59:59 +0300 (EEST) Received: from mail-oa1-f52.google.com (mail-oa1-f52.google.com [209.85.160.52]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C05BD68BDBC for ; Thu, 11 May 2023 16:59:52 +0300 (EEST) Received: by mail-oa1-f52.google.com with SMTP id 586e51a60fabf-190d4f2f943so6783466fac.3 for ; Thu, 11 May 2023 06:59:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683813590; x=1686405590; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=4QcqSAImFLs54yoyHvrv2oXT050VFf1bNoes+mceMtA=; b=N2w2ByypxnpSQ4pUyqaQLyyQ/yEE9kmFUYJcQUTg19UtHLiInkbcMB5rm78xX1xH1V cn6wC4IThQ5RdXJokjw648FuiITYHZaV/zcRKWYqXCAhlj5t/EYZULutL3vDir0+fIWn rwfa3ndd6uc7Sl0kDOKjy3Z4dBeybsHJXJTCXWkJdYlSC8V0OC6BMg25BT3/qsQzlTsE NmvrYx3utOtMIKobZoo42B6H2v2oue3TaMqvRFmZ0sIgmYrV0095r1w2SQeKyO0IwmQF Q99qLu6dFIRug6cpse+ga/J/Z64/xO1wjdYjSJTzT61Kx7cmVCwpO9azfW+yukaBijc+ Qeqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683813590; x=1686405590; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4QcqSAImFLs54yoyHvrv2oXT050VFf1bNoes+mceMtA=; b=HnoXIp/o+bFJgAiOaJBEwQX+X7b2l0cVk/Q24hYic/OiFvMrwyfcAZlnw7t5K5lqId iRZBATvxJ0YI7SVjzqffw7TUoTwVTxrKvb6SQodX237v0mwyYaKUrB2EQlrK1tJdsN3g egJUQbAGJK+774VB5Qne75wIJOYBLnhfz3BtzOVSUWbXyAj/rlF7Fehkz97V4VN6uT4I gIWVLbdTnLE3DWt/ydoaecksj8qSuOK7eCSeMwgXs1qpau5uL0/05WoyB+1iux2vTvld yyH9gF7K3ukLyySqXt+oAFBlk/GBQTWKNoDaIyIGeiMavWUtUgzXCutmPC8pN0OlY6ut 2XSQ== X-Gm-Message-State: AC+VfDx2fZAn7qhqi+l+lW6qOzn6ewZdXJ2K+f2E73rV1/kWNxC8hpCb vNpu3T1XxhiZGQhPpDn7SPEt1P+T3KY= X-Google-Smtp-Source: ACHHUZ6qJigiufN2WLPGaq5VuorjvkT1T0KRiRUvz1txZe44zXX4qO/MdbVhB8AsKTTFkqmvtMn6Gg== X-Received: by 2002:a05:6870:a4c1:b0:192:7e57:f247 with SMTP id k1-20020a056870a4c100b001927e57f247mr11988462oal.9.1683813590343; Thu, 11 May 2023 06:59:50 -0700 (PDT) Received: from [192.168.0.12] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id ec17-20020a0568708c1100b001964eef39ebsm1887761oab.40.2023.05.11.06.59.49 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 May 2023 06:59:49 -0700 (PDT) Message-ID: <0207d5e7-127e-ea16-8711-897bde81b83a@gmail.com> Date: Thu, 11 May 2023 11:00:07 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 To: ffmpeg-devel@ffmpeg.org References: <20230510202912.658437-1-ccom@randomderp.com> Content-Language: en-US From: James Almer In-Reply-To: <20230510202912.658437-1-ccom@randomderp.com> Subject: Re: [FFmpeg-devel] [PATCH] libavcodec/libsvtav1: Allow -1 for preset option X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 5/10/2023 5:29 PM, Christopher Degawa wrote: > Currently, the -1 (MR) preset is disallowed as it's taken as the preset > option not set, and the only way to access it was through svtav1-params. > > Signed-off-by: Christopher Degawa > --- > libavcodec/libsvtav1.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c > index 9174e2753c..952ed0e1e7 100644 > --- a/libavcodec/libsvtav1.c > +++ b/libavcodec/libsvtav1.c > @@ -170,7 +170,7 @@ static int config_enc_params(EbSvtAv1EncConfiguration *param, > param->look_ahead_distance = svt_enc->la_depth; > #endif > > - if (svt_enc->enc_mode >= 0) > + if (svt_enc->enc_mode >= -1) > param->enc_mode = svt_enc->enc_mode; > > if (avctx->bit_rate) { > @@ -593,7 +593,7 @@ static const AVOption options[] = { > { "high", NULL, 0, AV_OPT_TYPE_CONST, { .i64 = 1 }, 0, 0, VE, "tier" }, > #endif > { "preset", "Encoding preset", > - OFFSET(enc_mode), AV_OPT_TYPE_INT, { .i64 = -1 }, -1, MAX_ENC_PRESET, VE }, > + OFFSET(enc_mode), AV_OPT_TYPE_INT, { .i64 = -2 }, -2, MAX_ENC_PRESET, VE }, > > FF_AV1_PROFILE_OPTS Applied. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".