From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1D38F48B32 for ; Sat, 3 Feb 2024 10:00:55 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E5CD068D09E; Sat, 3 Feb 2024 12:00:51 +0200 (EET) Received: from glom.nmugroup.com (unknown [193.183.80.6]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B85F468CE0E for ; Sat, 3 Feb 2024 12:00:45 +0200 (EET) Received: from localhost (localhost [127.0.0.1]) by glom.nmugroup.com (Postfix) with ESMTP id 1E7FD542907F for ; Sat, 3 Feb 2024 11:00:35 +0100 (CET) Received: from debian.lan (unknown [IPv6:2a00:66c0:a::72c]) (Authenticated sender: git01) by glom.nmugroup.com (Postfix) with ESMTPSA id CBEF954288C9 for ; Sat, 3 Feb 2024 11:00:34 +0100 (CET) Message-ID: <0181f3c1559fca8731853f00fa8c0ed5f7acd7d3.camel@haerdin.se> From: Tomas =?ISO-8859-1?Q?H=E4rdin?= To: FFmpeg development discussions and patches Date: Sat, 03 Feb 2024 11:00:34 +0100 In-Reply-To: References: User-Agent: Evolution 3.46.4-2 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: support of 2 fields in 1 AVPacket X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: fre 2024-02-02 klockan 16:55 +0100 skrev Jerome Martinez: > Before this patch, the FFmpeg MXF parser correctly detects content > with > 2 fields in 1 AVPacket as e.g. interlaced 720x486 but the FFmpeg JPEG > 2000 decoder reads the JPEG 2000 SIZ header without understanding > that > the indicated height is the height of 1 field only so overwrites the > frame size info with e.g. 720x243, and also completely discards the > second frame, which lead to the decoding of only half of the stored > content as "progressive" 720x243 flagged interlaced. Is the decoder really the right place to do this? Surely this happens with more codecs than just j2k. Isnt it also a parser's job to do this kind of stuff? The logic that scans the packet for two SOI markers shouldn't be necessary if the relevant information is carried over from the MXF demuxer. It also makes the j2k decoder harder to ||ize. You might also need the StoredF2Offset /Tomas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".