From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id F08D345421 for ; Tue, 28 Feb 2023 11:56:39 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4B37868034D; Tue, 28 Feb 2023 13:56:36 +0200 (EET) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4884A68A5F7 for ; Tue, 28 Feb 2023 13:56:30 +0200 (EET) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 31SBuTa5004055-31SBuTa6004055; Tue, 28 Feb 2023 13:56:29 +0200 Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187]) by mail9.parnet.fi (Postfix) with ESMTPS id 6F675A143A; Tue, 28 Feb 2023 13:56:29 +0200 (EET) Date: Tue, 28 Feb 2023 13:56:29 +0200 (EET) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: Message-ID: <01648d-12d4-e4ab-38b0-113152f5143@martin.st> References: MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM Subject: Re: [FFmpeg-devel] [PATCH] libavcodec/hevc: reuse scale_store on idct32x32_neon X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: xufuji456 <839789740@qq.com> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, 24 Feb 2023, xufuji456 wrote: > --- > libavcodec/arm/hevcdsp_idct_neon.S | 18 ++---------------- > 1 file changed, 2 insertions(+), 16 deletions(-) > > diff --git a/libavcodec/arm/hevcdsp_idct_neon.S b/libavcodec/arm/hevcdsp_idct_neon.S > index 75795e6a6a..41ca3b83a8 100644 > --- a/libavcodec/arm/hevcdsp_idct_neon.S > +++ b/libavcodec/arm/hevcdsp_idct_neon.S > @@ -876,28 +876,14 @@ function func_tr_32x4_\name > movrel r9, trans + 32 > vld1.s16 {q0}, [r9, :128]! > vld1.s16 {q1}, [r9, :128] > - > - bl tr_block1 > - > add r4, sp, #2048 > - vld1.s16 {q14-q15}, [r4, :128]! > - butterfly32 q14, q10, q15, q11 > - scale32 d22, d23, d20, d21, q1, q14, q10, q15, \shift > - > - vld1.s16 {q14-q15}, [r4, :128]! > - butterfly32 q14, q12, q15, q13 > - scale32 d2, d3, d28, d29, q1, q14, q12, q15, \shift > > - transpose8_4x4 d22, d20, d2, d28 > - transpose8_4x4 d29, d3, d21, d23 > + bl tr_block1 > mov r1, r11 > mov r2, #64 > mov r8, #-64 > add r3, r11, #(56 + 3 * 64) > - store16 d22, d23, d20, d21, d2, d3, d28, d29, r8 > - > - @ reload multiplication coefficiens to q1 > - vld1.s16 {q1}, [r9, :128] > + scale_store \shift > > bl tr_block2 > add r1, r11, #8 > -- > 2.32.0 (Apple Git-132) LGTM, thanks - pushed now. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".