From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 31BF147908 for ; Fri, 27 Oct 2023 13:02:37 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9444A68CB11; Fri, 27 Oct 2023 16:02:35 +0300 (EEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 83DA468C713 for ; Fri, 27 Oct 2023 16:02:29 +0300 (EEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20231027130229euoutp01420f3f7c66bc25525214ad6a483cc20d~R_Hy5Q6X10767407674euoutp01B for ; Fri, 27 Oct 2023 13:02:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20231027130229euoutp01420f3f7c66bc25525214ad6a483cc20d~R_Hy5Q6X10767407674euoutp01B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1698411749; bh=YU17fAfQRItv2DgEEBUML2mc+QsA7nf0lX5c5WVMN5Y=; h=From:To:In-Reply-To:Subject:Date:References:From; b=FZjb5+KjYfSO/oy3UcPAHH2TxZtjfMk+4plUiaic7lssYfaUaWvUNfBoypysvmLFT 9Lesn89UMXs3ZZGYjwCPzM5yPwU7utTyQIklQv5YtutMSfvk69uoOWWa1BVl77tOeM DI9+yp6sJbjkHamtg3WBW+JTU0BhWj0hw0gaZxDo= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20231027130228eucas1p155e28dc537f584c790ab6e385f0ac5e9~R_Hytblex2895828958eucas1p10 for ; Fri, 27 Oct 2023 13:02:28 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 21.44.11320.4E4BB356; Fri, 27 Oct 2023 14:02:28 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20231027130228eucas1p21319185d46fd528b51cbf49f5c058add~R_HyU94b92202522025eucas1p2d for ; Fri, 27 Oct 2023 13:02:28 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20231027130228eusmtrp1f60f280f5f4487c77310edadf6dc1624~R_HyUOyXi1352313523eusmtrp1d for ; Fri, 27 Oct 2023 13:02:28 +0000 (GMT) X-AuditID: cbfec7f4-993ff70000022c38-5a-653bb4e48b2e Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id B8.40.10549.4E4BB356; Fri, 27 Oct 2023 14:02:28 +0100 (BST) Received: from AMDN5164 (unknown [106.210.132.171]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20231027130228eusmtip2d15a41f3e7d4625b1f290edc0e2ddf18~R_HyAxEpF0211702117eusmtip2p for ; Fri, 27 Oct 2023 13:02:28 +0000 (GMT) From: "Dawid Kozinski/Multimedia \(PLT\) /SRPOL/Staff Engineer/Samsung Electronics" To: "'FFmpeg development discussions and patches'" In-Reply-To: <20231012232759.5352-3-michael@niedermayer.cc> Date: Fri, 27 Oct 2023 15:02:27 +0200 Message-ID: <013f01da08d5$d6920140$83b603c0$@samsung.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQGwSlkZIpKz3g0iSxrKrYb1T+oWTQF9paygAZFZ7PWwmJ7TUA== Content-Language: pl X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrNIsWRmVeSWpSXmKPExsWy7djPc7pPtlinGrzrMLD49ukMswOjx59F m1kCGKO4bFJSczLLUov07RK4Mm6eu8RWsEKi4ue86YwNjCfEuxg5OSQETCQOTf7I2sXIxSEk sIJR4nj3XTYIZxKTxMX+LkYIZyKTxLZzE5hhWq78PMkMkVjOKDF/0lWoqjYmiad7/oJVsQnk STz+vBbMFhHwkehev54VxOYUsJbY9247C4gtLOAisevNYXYQm0VAVeJLbxNYDa+ApcTdkzcZ IWxBiZMzn4DVMwvoSTw7NQvK1pZYtvA11EUKEj+fLmOF2OUksejGbjaIGhGJG49awI6TEJjI IfHqwjoWiAYXiR+Ld0DZwhKvjm9hh7BlJE5P7gGKcwDZxRKH+h0gzBqJQz/SISqsJd42HmeE sB0lOh4fgqrmk7jxVhBiK5/EpG3TmSHCvBIdbUIQpopEX6cYRKOUxNNlc5gnMCrNQvLiLCQv zkLy4iwkryxgZFnFKJ5aWpybnlpslJdarlecmFtcmpeul5yfu4kRmB5O/zv+ZQfj8lcf9Q4x MnEwHmKU4GBWEuGN9LFIFeJNSaysSi3Kjy8qzUktPsQozcGiJM6rmiKfKiSQnliSmp2aWpBa BJNl4uCUamAKnyog35uq0Fej+HhZ7QqtM9YOzi46Aie+bm1ZXXhzfUPlLc2AlhK+iXMbH1Sl rlhXKqo+Q3jmuU+ZQgW699xsdgpYJ9++ry75RYvvbtvl4zcfJT3Zz727P2Th5+gqnd6Eh/l6 XzuNpr1Y5m3DPEGrcHXfZqmJ+aGruzmEvaKV7Gv+fZ56REV4L6et37TXDx+dXvj3yQzPmfa3 VpRrKOlWbVl7Qqnn56wXh5sPfvM99VPx8fMj85/XPSwzZt7dIRFYeNpuRuO8oPyKtLiYmpMp qjaGlzlNO6ZbO+c1TXPufLJyb0RHwGMVvfurg3TXfJGfsjfskcvEB36dJ+fny+1XXvPo2Uwh 1+idnhy7BTYrsRRnJBpqMRcVJwIAmXZR4n4DAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpgkeLIzCtJLcpLzFFi42I5/e/4Pd0nW6xTDVbOE7H49ukMswOjx59F m1kCGKP0bIryS0tSFTLyi0tslaINLYz0DC0t9IxMLPUMjc1jrYxMlfTtbFJSczLLUov07RL0 MmYsnctecECw4s/EVtYGxp18XYycHBICJhJXfp5k7mLk4hASWMoocXjxdmaIhJTE0qWLGCFs YYk/17rYIIpamCR2NJxkA0mwCeRIrJ09kQnEFhHwkehev54Vomg3o0RfwxywIk4Ba4l977az gNjCAi4Su94cZgexWQRUJb70NrGC2LwClhJ3T95khLAFJU7OfAJWzyxgILFk4S8mCFtbYtnC 11DXKUj8fLqMFWKxk8SiG7vZIGpEJG48amGcwCg0C8moWUhGzUIyahaSlgWMLKsYRVJLi3PT c4sN9YoTc4tL89L1kvNzNzECo2LbsZ+bdzDOe/VR7xAjEwfjIUYJDmYlEd5IH4tUId6UxMqq 1KL8+KLSnNTiQ4ymQL9NZJYSTc4HxmVeSbyhmYGpoYmZpYGppZmxkjivZ0FHopBAemJJanZq akFqEUwfEwenVAPTLL8U4VlV9jk8Z07r/5ioe8q63rr5zKPCtmnr2dkExE+EqNw/YRmxc6vu x86QtC8SgY7X5O52bPl//8R20WA5p97vYj6aUrpzD51O3F0zxYK/ZW+C1vzF9x8INd9MfO6x /nKhy76QOzIvN+t82p2uMaH732njjzGH5nF07/LLZl/2V6t6WwWHbAPv7pU/ztm5dBceS+Fw D+yq1DgjtTovbF7+7k1r60NrynQOHJd/YaPwV9hyndiWLZPXdp19J5Tlfp1fr27x/L9ruey3 1Bhuyc39JGrx4Uzc/GNPyyL9z5ZOPveFcd1kK7H0k7t/KMZWRXZGnbwi6BcglLR17pKvNp4q otLF8sszqnnDZXKVWIozEg21mIuKEwG97uZFEwMAAA== X-CMS-MailID: 20231027130228eucas1p21319185d46fd528b51cbf49f5c058add X-Msg-Generator: CA X-RootMTR: 20231012232829eucas1p1c53b05760758a881bfeca2caf8bb3e2a X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20231012232829eucas1p1c53b05760758a881bfeca2caf8bb3e2a References: <20231012232759.5352-1-michael@niedermayer.cc> <20231012232759.5352-3-michael@niedermayer.cc> Subject: Re: [FFmpeg-devel] [PATCH 3/3] avcodec/evc_parse: Check tid X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of > Michael Niedermayer > Sent: pi=B1tek, 13 pa=BCdziernika 2023 01:28 > To: FFmpeg development discussions and patches > Subject: [FFmpeg-devel] [PATCH 3/3] avcodec/evc_parse: Check tid > = > The check is based on not infinite looping. It is likely a more strict check can be > done > = > Fixes: Infinite loop > Fixes: 62473/clusterfuzz-testcase-minimized- > ffmpeg_BSF_EVC_FRAME_MERGE_fuzzer-5719883750703104 > Fixes: 62765/clusterfuzz-testcase-minimized-ffmpeg_dem_EVC_fuzzer- > 6448531252314112 > = > Found-by: continuous fuzzing process > https://protect2.fireeye.com/v1/url?k=3D06e4faf3-676fefea-06e571bc- > 74fe485cbfec-11816a289a0e9c00&q=3D1&e=3D16696cd9-38c1-42d0-9196- > 8ad7c6d1d0d6&u=3Dhttps%3A%2F%2Fgithub.com%2Fgoogle%2Foss- > fuzz%2Ftree%2Fmaster%2Fprojects%2Fffmpeg > Signed-off-by: Michael Niedermayer > --- > libavcodec/evc_parse.c | 3 +++ > 1 file changed, 3 insertions(+) > = > diff --git a/libavcodec/evc_parse.c b/libavcodec/evc_parse.c index > 255706ce61..43b8dabf8b 100644 > --- a/libavcodec/evc_parse.c > +++ b/libavcodec/evc_parse.c > @@ -174,6 +174,9 @@ int ff_evc_derive_poc(const EVCParamSets *ps, const > EVCParserSliceHeader *sh, > } else { > int SubGopLength =3D 1 << sps->log2_sub_gop_length; > = > + if (tid > (SubGopLength > 1 ? 1 + av_log2(SubGopLength - 1) : 0)) > + return AVERROR_INVALIDDATA; > + > if (tid =3D=3D 0) { > poc->PicOrderCntVal =3D poc->prevPicOrderCntVal + SubGopLength; > poc->DocOffset =3D 0; > -- Looks good > 2.17.1 > = > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://protect2.fireeye.com/v1/url?k=3D63dfcc8a-0254d993-63de47c5- > 74fe485cbfec-e9d44b0bcc16ae00&q=3D1&e=3D16696cd9-38c1-42d0-9196- > 8ad7c6d1d0d6&u=3Dhttps%3A%2F%2Fffmpeg.org%2Fmailman%2Flistinfo%2Fffmp > eg-devel > = > To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org > with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".