From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id CF6114710F for ; Wed, 27 Sep 2023 02:16:42 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C664268CAC3; Wed, 27 Sep 2023 05:16:39 +0300 (EEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9DBB168CA95 for ; Wed, 27 Sep 2023 05:16:33 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695780998; x=1727316998; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=hhUoy0AKdIgQm4DlJAThsDLie9j+4tRcJVB934Hc/Bk=; b=bhjMWiksgZ5DXX+/hlcDOLo7p12R4npZO7gJPTIVqMvPgFCTdsH1p98k 9RizpCfbOIkyxIOOSrMBxmsMBBlfrkeCIQ0MmbTyNv8SUkyDZyMa1l3N6 4OyBRuzkk5gjgQ0C1zNYjGHCzVfClwcqgbJhRRq69mna7jrY2E4MmvPkI r/zRdqY+ksnO/XGVGBlb8JWqvyfkSbqOn+v0NjoFBG7H1M5yt4iQD5IUW RaAmkBSNJ7AH7O/0JEzQx9Q3Tp9GZDi9h5fPTYAvcalzW6HUBSLysKxug jVLSUzCls75WoIuR77g5q8PqwNId3UefkK2dhoXtSb0V3yjUXigIUjsOb g==; X-IronPort-AV: E=McAfee;i="6600,9927,10845"; a="378992918" X-IronPort-AV: E=Sophos;i="6.03,179,1694761200"; d="scan'208";a="378992918" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Sep 2023 19:16:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10845"; a="839246131" X-IronPort-AV: E=Sophos;i="6.03,179,1694761200"; d="scan'208";a="839246131" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by FMSMGA003.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 26 Sep 2023 19:16:30 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Tue, 26 Sep 2023 19:16:29 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Tue, 26 Sep 2023 19:16:29 -0700 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.174) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Tue, 26 Sep 2023 19:16:27 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VO+lcSFezWIXCEwowgXKaQOdpJH80oc8gyOX82G+mzElRohSzuHcfNRSHR4knX79cDeUPD3Dc4Q2RAF6V4lSZi3hAH4gq/dhyIGi5tliAgBf93FcPXVos/KYDrOxbzUY+ct74ywN0kXm60VgljmqJXuoVR+BlpuwBIVc5bMZVxsGnEOHmDLoJsay6yK1jwYMNbSfGjd56KSsB21arHbWvRy2EzdGjXTL66C6KD0CP0G836uv0Buoluav2DijHG/EtiekMBsDPb64BsRJ0RMDqr+d5pDy+CjEzivGkt/EirM0+R11cuFATyhTpsbpjaNIg0kBrX05XCImRntKDr8jbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hhUoy0AKdIgQm4DlJAThsDLie9j+4tRcJVB934Hc/Bk=; b=ftSjrt+GOECkNA2GoF1G3VPFatM9T/9NMzHxEMteqBb4bAU8xrpT6j87e76j2kHHv1lvS0Z6kUxo7EhM6mK0l+1IeoGSofkBbzThYCSoGo/uBTSuW3AImtct26a73xzvDMDG3+g7GpCxy8/S6Gfzj9dtmn9pK5asLOucpd994Tksp6ru+II2ontw5StC25cqgLnHIYvt9z4RaT5t1yQ/QbKysnOWZ2VJN8aG8ymcHY3PmNxUxdQzumS1WQ3rpvCX5Pdutj46lcXvt+P+T1xYbMqglH1ncZAoBgDG3R1UXSUTY2QnDWKBv9rSwVllS/BWfwzeyFGPiafb/B/NtI0bWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5030.namprd11.prod.outlook.com (2603:10b6:510:41::5) by DM6PR11MB4529.namprd11.prod.outlook.com (2603:10b6:5:2ae::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.28; Wed, 27 Sep 2023 02:16:25 +0000 Received: from PH0PR11MB5030.namprd11.prod.outlook.com ([fe80::e32:a93a:6648:16d7]) by PH0PR11MB5030.namprd11.prod.outlook.com ([fe80::e32:a93a:6648:16d7%7]) with mapi id 15.20.6813.017; Wed, 27 Sep 2023 02:16:25 +0000 From: "Wang, Fei W" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH v2] cbs_av1: Make fake OBU size length field a write option Thread-Index: AQHZ8LiarvIZPRon80S+/dAh8EqaUrAt77uA Date: Wed, 27 Sep 2023 02:16:24 +0000 Message-ID: <013e7b6892980fd764dcf83e6972173f55296358.camel@intel.com> References: <82270518-8c7a-d360-ba1a-e2ceca913302@jkqxz.net> In-Reply-To: <82270518-8c7a-d360-ba1a-e2ceca913302@jkqxz.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Evolution 3.36.5-0ubuntu1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5030:EE_|DM6PR11MB4529:EE_ x-ms-office365-filtering-correlation-id: 80be9414-4cc5-4a5d-fc7d-08dbbeffbf88 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fgVhUIt3O9hijSFQvegfBJ8N71YVowG16utmzsaZmh4i0Nif1lJT1UTcAVTE7ZnqZw/ekATnSOehHAiXvk0VjdQRXQCF5VNSmypZDfFYBify1MFELtEbBDBillX7lVAoHG5tMRjzyMiXvBTbrRJPA3N14hIr2Rp7xTMAWNZFxNQHranihVQnntQb21BGg2oYvEbncb+UkfJsXTwb2ZuE4gfFA7M6JZsr7/Opq67l9Yv5ZrbJQAcqXNNd0Ydej/M0wwdmq8GJ8/QY/54I9vlf/cNaxzc1AfwtbctxTRO1SMDi8XPZ+3olwWiOZqwxfLlG4bBAHMvJ5/cCay2m0mrWlFUKPPpKTzSg0kUKQPkyM04Z2sHbZ7JzZ9vRGm8QDtLKxUDpMoREBOYDntuNDsrcYIvSxn0YaKvRibnQhU4PBH7MSNp56JOMSChZ2e6wi6wEzTTrEuHMPRIVf5X6x91+b9bEPDSAxbI//xMIA/oQfceYPazmfFPbGy91ululHMedjT14niQbJwla2t4SqiVdwuu1qN2puNe/0mu6Vk2EjPICY80aLkVXZapbpNIh0Y0tr66Gsj7U2Fb3xMv1Q4Sq1TlOYBUilqZsaKqw7I1xIV2cjNNZ5RSBLyqKWxdgV4KA x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5030.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(346002)(39860400002)(366004)(376002)(136003)(230922051799003)(1800799009)(186009)(451199024)(71200400001)(2906002)(53546011)(6512007)(6506007)(26005)(38070700005)(64756008)(82960400001)(76116006)(86362001)(6486002)(66446008)(19627235002)(478600001)(91956017)(38100700002)(122000001)(83380400001)(5660300002)(316002)(6916009)(8936002)(36756003)(8676002)(2616005)(66556008)(66946007)(41300700001)(66476007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?UU9BMkdRVGFHMHhZY0lMY29ZU21pK015aUY2SUpXTDZsY3pGSmt4dUhkUFpm?= =?utf-8?B?ZzVLSUFBdUJ4OEMzUHNJenFVQTVZRWtNclVQL3hLS1ZmZHE1ZWNnK2ZGb1Rx?= =?utf-8?B?a29BRGhQODNtRm4vVVk4ZnRwemZNQzRITFZjZG5FcmVVSEpsb0tmUU5Mb1BG?= =?utf-8?B?Y2YxeFlmVm05c3Ava1N5akZvK3NlMGpFbFcwWHppVlpjblFLOG04dkZLbUho?= =?utf-8?B?bkNaYms3QW5WUDhNQ2xSdWcxL1RzbGVuTnV3a24xcm1aVUVhZG9VZUpUOWx0?= =?utf-8?B?Ulc0VEo2SEZYdllEQ0RWMXpMS2lxYkhGK2tsRVh5Zk1kb3Q4aWhmTmxETGVM?= =?utf-8?B?TElxOXpXTlBScjRGdE85UGIwRllFSEd0RnE5MEVqeWVTQnZHQ2M0UHhZaW1j?= =?utf-8?B?WVBHeFp0dzc5M0o1R3kxVFJDSU1pR2pEMVd2Q0VudkR1b01ackZqa0kwS2Nx?= =?utf-8?B?OVVyYWpOemVaRVVMcjliQUo1b1E4dlpqUElQTndtUVp5em91RTNzUGVWUy94?= =?utf-8?B?SXErelNLVDl5cnY3UkhMaERZU3luTkRiblk1OGo1TkZ0cjVGS3JQdzFNMzM4?= =?utf-8?B?eFU2MXhJMDFSc3ppMDVKTTB4eitzQlcxWjZBNjdkSVZKb2F6RW80bTJ1NmtY?= =?utf-8?B?SW9ac0l3QnNrV3czbzdKbStaZmVkd0l3bWNiTEcyb3ZXaE1TNG9PMzNMUGE3?= =?utf-8?B?cktCOEdHOEt0MFg2enJjalQ5MFVIREE5ZEx3WXhMSkZKNW1rSWNYS0MwOWdW?= =?utf-8?B?UFpkeG1CMW5RSmxTTnc5bTRVNWk1QlpmcHQxWkh3emQ3T2RxSkV3ZDZISWhr?= =?utf-8?B?U1lnM21LUWpMcU9NdE5Ta1Q4VUM4TThERkpKQytrRldvWlBFeTFLY0s4RlNr?= =?utf-8?B?N3d6d01QVnowa0xnYXpLckJrSHNVN0Z5MzFqR3NPRit2RHptQjBxNTZlUUEw?= =?utf-8?B?Tzd5citNTlNtTWdaTjlrdENoMTNiREptL25sYWpYTlZYZUx3Q1lvdkdMTUJR?= =?utf-8?B?UEtIT3lPeTlLZldjckFiWHpMbks3YWtyVWFrcXZnNlJSTU1YVTlJeHgwWXdB?= =?utf-8?B?ZFJPcDI4dnFtUWRJL3o1YWRqcHdKTVBsbmpBMTZ5RXVWby8ySHBrc004Wml4?= =?utf-8?B?bkVaOFVHeTVqbi96VWxVMEExZmxtdTZhUzJpUDVYZE9kR2lVT1loYXlZdlNj?= =?utf-8?B?Q29NTi9vY3NOM2cwSmZIRmhzQ2U4SFJXTjNnYStSVVhEN2NqTnFEemZXT0Uv?= =?utf-8?B?Qm4yTGxteHpWOGhDZVNIQzc3Q08xRk9mUE9TeXkwRDc4dnBFYXFMeFd3MGFs?= =?utf-8?B?M01Bc3lyc2VibUhWOXBsblRLMzlIWUhETVFMUHl6UXBaTThSRFlOWktUR0Q3?= =?utf-8?B?NGtqOUtRbmhUWFhGWTNuOUhRSnpoS3l5d05EK3FMaXFDdDBsYnIwc0grNGJm?= =?utf-8?B?QlAyWUxPcERZVFpya3cyK0dEekw0UXlQOEJibEM3M3BSNkRyQWpVVTNtMGdD?= =?utf-8?B?aEpTK0RiV3kxNCtlTWV3LzBnY1ZaRDlqVHdWVEkxQlc5ZlI1eHhuRldHRTNq?= =?utf-8?B?TkIrZk9namVtSmNLcFRsdUh1azg2My9ZMDZQTWNZSW8xbE5ZS3NzQUdGbWRH?= =?utf-8?B?UXQvV3UrSHBpRmVITk84b0c0OU94ZGZVTHdVR1RsN0ppOUtkWjExSlRHQ3Vy?= =?utf-8?B?Y2JoK1JVMjZVT2laY0ZDeTJBV0RMTlMwWURmc0ZEU1AwaGtGb2NNcUdUSGU2?= =?utf-8?B?ZWk4ZkpVdVRvT3poUWg4eWNvZm80MmxvWnhJNnJmQnF0UElGSUU0THpQb2p5?= =?utf-8?B?TEZLR0tiQXNKM3B5cCtmK2FiNjVGQlJoRkdPZ1BOUEd3Z0ovNkQ5MndWajNq?= =?utf-8?B?c3I2ZzVCQWl0dEpoVnh4SVQ2Q2JHbndiMStKN2Z4L1VzZmV4NTRTRkU5Vkt4?= =?utf-8?B?Q0xFQ2kyYTNQVythcXFhWFB1RjBQM3dZdDJSVERPM1Brc3luTDc0K0JENnJp?= =?utf-8?B?d3o2aldPd0pFcEpnVHFlcGllWXZFTU9UbERZTVA0N3dIWm5ZcXdyKy9wTDBx?= =?utf-8?B?cnZXbmd2dHdHTFBIem5TanBlTlJQRW1mSE51SnBVY2FlMEdYckcySURDQ0Rw?= =?utf-8?B?T2Q2aXo5TEpuUkpYaVRUaTVDV0tnYU5xVDM5bDh0OEN5YmhscHFXbXJqR2xN?= =?utf-8?B?emc9PQ==?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5030.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 80be9414-4cc5-4a5d-fc7d-08dbbeffbf88 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Sep 2023 02:16:24.1875 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vpelP7WlUNPg/gaEVpv4XzDbDkyUhob2xI9lGUeCNxOuLK9+OAVPTdoDETy3L5HCjATFbbDwOE6qheTnZsueRw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4529 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v2] cbs_av1: Make fake OBU size length field a write option X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, 2023-09-26 at 21:30 +0100, Mark Thompson wrote: > This is an option to modify the behaviour of the writer, not a syntax > field. > --- > On 26/09/2023 03:34, Wang, Fei W wrote: > > On Mon, 2023-09-25 at 14:53 +0100, Mark Thompson wrote: > > > ... > > > diff --git a/libavcodec/vaapi_encode_av1.c > > > b/libavcodec/vaapi_encode_av1.c > > > index 3ff1c47b53..861bf4a13b 100644 > > > --- a/libavcodec/vaapi_encode_av1.c > > > +++ b/libavcodec/vaapi_encode_av1.c > > > @@ -133,6 +133,9 @@ static av_cold int > > > vaapi_encode_av1_configure(AVCodecContext *avctx) > > > priv->cbc->trace_context = ctx; > > > priv->cbc->trace_write_callback = > > > vaapi_encode_av1_trace_write_log; > > > > > > + av_opt_set_int(priv->cbc->priv_data, > > > "fixed_obu_size_length", > > > + priv->attr_ext2.bits.obu_size_bytes_minus1 + > > > 1, > > > 0); > > > + > > > > This should be put after querying priv.attr_ext2 in > > vaapi_encode_av1_init(). > > Ah, true - I got my init and configure mixed up, but don't have > convenient hardware to test. Fixed in this version. LGTM for this version. Thanks Fei > > Thanks, > > - Mark > > libavcodec/cbs_av1.c | 31 +++++++++++++++++++++---------- > libavcodec/cbs_av1.h | 5 ++++- > libavcodec/vaapi_encode_av1.c | 4 +++- > 3 files changed, 28 insertions(+), 12 deletions(-) > > diff --git a/libavcodec/cbs_av1.c b/libavcodec/cbs_av1.c > index 4e687ace79..ed9a7b80d4 100644 > --- a/libavcodec/cbs_av1.c > +++ b/libavcodec/cbs_av1.c > @@ -138,19 +138,25 @@ static int > cbs_av1_read_leb128(CodedBitstreamContext *ctx, GetBitContext *gbc, > return 0; > } > > -/** Minimum byte length will be used to indicate the len128 of value > if byte_len is 0. */ > static int cbs_av1_write_leb128(CodedBitstreamContext *ctx, > PutBitContext *pbc, > - const char *name, uint64_t value, > uint8_t byte_len) > + const char *name, uint64_t value, > int fixed_length) > { > int len, i; > uint8_t byte; > > CBS_TRACE_WRITE_START(); > > - if (byte_len) > - av_assert0(byte_len >= (av_log2(value) + 7) / 7); > + len = (av_log2(value) + 7) / 7; > > - len = byte_len ? byte_len : (av_log2(value) + 7) / 7; > + if (fixed_length) { > + if (fixed_length < len) { > + av_log(ctx->log_ctx, AV_LOG_ERROR, "OBU is too large for > " > + "fixed length size field (%d > %d).\n", > + len, fixed_length); > + return AVERROR(EINVAL); > + } > + len = fixed_length; > + } > > for (i = 0; i < len; i++) { > if (put_bits_left(pbc) < 8) > @@ -1006,8 +1012,8 @@ static int > cbs_av1_write_obu(CodedBitstreamContext *ctx, > > if (obu->header.obu_has_size_field) { > pbc_tmp = *pbc; > - if (obu->obu_size_byte_len) { > - for (int i = 0; i < obu->obu_size_byte_len; i++) > + if (priv->fixed_obu_size_length) { > + for (int i = 0; i < priv->fixed_obu_size_length; i++) > put_bits(pbc, 8, 0); > } else { > // Add space for the size field to fill later. > @@ -1133,7 +1139,8 @@ static int > cbs_av1_write_obu(CodedBitstreamContext *ctx, > end_pos /= 8; > > *pbc = pbc_tmp; > - err = cbs_av1_write_leb128(ctx, pbc, "obu_size", obu->obu_size, > obu->obu_size_byte_len); > + err = cbs_av1_write_leb128(ctx, pbc, "obu_size", obu->obu_size, > + priv->fixed_obu_size_length); > if (err < 0) > goto error; > > @@ -1150,10 +1157,12 @@ static int > cbs_av1_write_obu(CodedBitstreamContext *ctx, > } > > if (obu->obu_size > 0) { > - if (!obu->obu_size_byte_len) { > - obu->obu_size_byte_len = start_pos - data_pos; > + if (!priv->fixed_obu_size_length) { > memmove(pbc->buf + data_pos, > pbc->buf + start_pos, header_size); > + } else { > + // The size was fixed so the following data was > + // already written in the correct place. > } > skip_put_bytes(pbc, header_size); > > @@ -1273,6 +1282,8 @@ static const CodedBitstreamUnitTypeDescriptor > cbs_av1_unit_types[] = { > static const AVOption cbs_av1_options[] = { > { "operating_point", "Set operating point to select layers to > parse from a scalable bitstream", > OFFSET(operating_point), AV_OPT_TYPE_INT, > { .i64 = -1 }, -1, AV1_MAX_OPERATING_POINTS - 1, 0 }, > + { "fixed_obu_size_length", "Set fixed length of the obu_size > field", > + OFFSET(fixed_obu_size_length), AV_OPT_TYPE_INT, { .i64 = 0 }, > 0, 8, 0 }, > { NULL } > }; > > diff --git a/libavcodec/cbs_av1.h b/libavcodec/cbs_av1.h > index a9e2d2284f..7924257164 100644 > --- a/libavcodec/cbs_av1.h > +++ b/libavcodec/cbs_av1.h > @@ -401,7 +401,6 @@ typedef struct AV1RawOBU { > AV1RawOBUHeader header; > > size_t obu_size; > - uint8_t obu_size_byte_len; > > union { > AV1RawSequenceHeader sequence_header; > @@ -468,6 +467,10 @@ typedef struct CodedBitstreamAV1Context { > > // AVOptions > int operating_point; > + // When writing, fix the length in bytes of the obu_size field. > + // Writing will fail with an error if an OBU larger than can be > + // represented by the fixed size is encountered. > + int fixed_obu_size_length; > } CodedBitstreamAV1Context; > > > diff --git a/libavcodec/vaapi_encode_av1.c > b/libavcodec/vaapi_encode_av1.c > index 3ff1c47b53..5a9ff0f798 100644 > --- a/libavcodec/vaapi_encode_av1.c > +++ b/libavcodec/vaapi_encode_av1.c > @@ -634,7 +634,6 @@ static int > vaapi_encode_av1_init_picture_params(AVCodecContext *avctx, > } > } > > - fh_obu->obu_size_byte_len = priv- > >attr_ext2.bits.obu_size_bytes_minus1 + 1; > ret = vaapi_encode_av1_add_obu(avctx, obu, > AV1_OBU_FRAME_HEADER, &priv->fh); > if (ret < 0) > goto end; > @@ -839,6 +838,9 @@ static av_cold int > vaapi_encode_av1_init(AVCodecContext *avctx) > priv->attr_ext2.value = attr.value; > } > > + av_opt_set_int(priv->cbc->priv_data, "fixed_obu_size_length", > + priv->attr_ext2.bits.obu_size_bytes_minus1 + 1, > 0); > + > ret = vaapi_encode_av1_set_tile(avctx); > if (ret < 0) > return ret; _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".