From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9CB65478F2 for ; Fri, 27 Oct 2023 12:58:20 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2D51968CB27; Fri, 27 Oct 2023 15:58:18 +0300 (EEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D548868CA27 for ; Fri, 27 Oct 2023 15:58:11 +0300 (EEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20231027125809euoutp0271df6a10df54ff03fa3e6afeac16037b~R_EBbhsAO1505915059euoutp029 for ; Fri, 27 Oct 2023 12:58:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20231027125809euoutp0271df6a10df54ff03fa3e6afeac16037b~R_EBbhsAO1505915059euoutp029 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1698411489; bh=WN+/nVY5YQ0Pu+y9ZUoIJx33GnCJ4wa3gqQkjxGt7ds=; h=From:To:In-Reply-To:Subject:Date:References:From; b=JJb0LJv7UMaVjp6fVvqDAs7qAuCXfxm2U8Hc/eUfSgWMIEbjvsuZy1SSTBI9js043 Rhum+h8BOBwIn6u8vpC6iIUYweY81TZpz1Unk0XqoDqX5ZziehCszwhRH3fmaw5VvY ubv9RtiU4LzpBS+6X0oLwAqfx1a51bqttTIMD+1s= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20231027125809eucas1p1588b18a647f19969b17d8e89e358ce12~R_EBSArdP0629006290eucas1p1y for ; Fri, 27 Oct 2023 12:58:09 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 4A.26.42423.1E3BB356; Fri, 27 Oct 2023 13:58:09 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20231027125809eucas1p2fa8578c3ca010119712b4f65cba67a0a~R_EA7aO_p2630726307eucas1p2M for ; Fri, 27 Oct 2023 12:58:09 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20231027125809eusmtrp29b8d61f83ed85cd66c580365a1965463~R_EA63kfg2860728607eusmtrp2G for ; Fri, 27 Oct 2023 12:58:09 +0000 (GMT) X-AuditID: cbfec7f2-a3bff7000002a5b7-75-653bb3e146fb Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id AD.7F.10549.1E3BB356; Fri, 27 Oct 2023 13:58:09 +0100 (BST) Received: from AMDN5164 (unknown [106.210.132.171]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20231027125808eusmtip1f73b47bfc07dbf2699a2b401e7771e47~R_EArnLHA2793527935eusmtip1m for ; Fri, 27 Oct 2023 12:58:08 +0000 (GMT) From: "Dawid Kozinski/Multimedia \(PLT\) /SRPOL/Staff Engineer/Samsung Electronics" To: "'FFmpeg development discussions and patches'" In-Reply-To: <20231012232759.5352-3-michael@niedermayer.cc> Date: Fri, 27 Oct 2023 14:58:08 +0200 Message-ID: <013d01da08d5$3c1eaaf0$b45c00d0$@samsung.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQGwSlkZIpKz3g0iSxrKrYb1T+oWTQF9paygAZFZ7PWwmJ2BkA== Content-Language: pl X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrFIsWRmVeSWpSXmKPExsWy7djP87oPN1unGrR8lrf49ukMswOjx59F m1kCGKO4bFJSczLLUov07RK4MlZ0HmIvOCVZcfRsdAPjM4kuRk4OCQETiW0HjjB1MXJxCAms YJQ4/vE2M4QziUniz63z7BDORCaJl/f2scO0PJv8DyqxnFFi47HJLBBOG5PE+cd7WECq2ATy JB5/XssMYosI+Eh0r1/PCmJzClhL7Hu3HaxGWMBFYtebw2BTWQRUJWb+usgIYvMKWErs3tjL BmELSpyc+QSsnllAT+LZqVlQtrbEsoWvmSEuUpD4+XQZK8QuJ4m2ebuYIWpEJG48amEEOU5C YCKHxP7la6BecJGYvLmTBcIWlnh1fAtUXEbi/875wNDgALKLJQ71O0CYNRKHfqRDVFhLvG08 zghhO0p0PD7EAlHCJ3HjrSDEVj6JSdumM0OEeSU62oQgTBWJvk4xiEYpiafL5jBPYFSaheTF WUhenIXkxVlIXlnAyLKKUTy1tDg3PbXYMC+1XK84Mbe4NC9dLzk/dxMjMDmc/nf80w7Gua8+ 6h1iZOJgPMQowcGsJMIb6WORKsSbklhZlVqUH19UmpNafIhRmoNFSZxXNUU+VUggPbEkNTs1 tSC1CCbLxMEp1cDEHbP25/IwkZS/y683z/hy9+eJY9y+zM8v/b5R/6Bz4eXdOVY3D7a1a63a +ctyxoSKHZI7z3cbL3h387cWi1XPzAgWualya99KsH/VV2U8mvL7el1vzprP7VmTX/N4NUre efj9TFP/JSn/EL0V++/E2t/y/L6vnX9+dP6fR+Yhkvs3Vk9Z8Pf5xprkaRo2z3af6dy2O6eh rP19drrbFX3j1y1hP2Y3/tj+5xn/oznien8Tp2vcFbiysIPxgcfTfyf+2FStMzmpmyi6iT0/ 84h9rmTgKp7r/4MuC+9dylF7dPWnw7Ghi/xrju140ixwN3/ZzcrTMlMa91luZEmMjo+b7eF9 OIjHWbBD3nTt4YmuB5VYijMSDbWYi4oTAS4bLxB9AwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpgkeLIzCtJLcpLzFFi42I5/e/4Xd2Hm61TDdYd57H49ukMswOjx59F m1kCGKP0bIryS0tSFTLyi0tslaINLYz0DC0t9IxMLPUMjc1jrYxMlfTtbFJSczLLUov07RL0 Mk4+P8hWsF+o4vK6OYwNjCv4uxg5OSQETCSeTf7H3sXIxSEksJRR4uml5WwQCSmJpUsXMULY whJ/rnWxQRS1MEncPbUSLMEmkCOxdvZEJhBbRMBHonv9elaIot2MEn0Nc8AmcQpYS+x7t50F xBYWcJHY9eYwO4jNIqAqMfPXRbBBvAKWErs39rJB2IISJ2c+AatnFjCQWLLwFxOErS2xbOFr ZoiLFCR+Pl3GCrHYSaJt3i5miBoRiRuPWhgnMArNQjJqFpJRs5CMmoWkZQEjyypGkdTS4tz0 3GJDveLE3OLSvHS95PzcTYzAqNh27OfmHYzzXn3UO8TIxMF4iFGCg1lJhDfSxyJViDclsbIq tSg/vqg0J7X4EKMp0G8TmaVEk/OBcZlXEm9oZmBqaGJmaWBqaWasJM7rWdCRKCSQnliSmp2a WpBaBNPHxMEp1cBks+9P/Y6DAWyzj7T7yP05FfpkQbewSy/3jnMaL5MLmmevPsZv+KNt9hO+ I149iracSxysVZjecV/IPmuUzbzty8Kpcc+nRQcy7pn1/1Svxy0dr8a/q/4tvG1sdZT7X6X9 7AsRH13TJn3nvMy9ZrXc3WvRFlNU49qLd0Uz15YrHpbNsz3j0CXGKb3zQZ6C69TDq+6+4Z4h Of+WpqXVzt7+iY2T3PSlojKkPRKnSB+2Obe2qzjl2Y7chYkTNp3czeDZW/wxTqykka3DLEgk fW1LRPq70yGxV+Y+0T8nkzblG+PhJbvmuvPpLz1y4+Q8Z6G52/e48wgXHmTwK8292BjNF5f8 Q41x8oofR/aqyl1SYinOSDTUYi4qTgQAFfUOlRMDAAA= X-CMS-MailID: 20231027125809eucas1p2fa8578c3ca010119712b4f65cba67a0a X-Msg-Generator: CA X-RootMTR: 20231012232829eucas1p1c53b05760758a881bfeca2caf8bb3e2a X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20231012232829eucas1p1c53b05760758a881bfeca2caf8bb3e2a References: <20231012232759.5352-1-michael@niedermayer.cc> <20231012232759.5352-3-michael@niedermayer.cc> Subject: Re: [FFmpeg-devel] [PATCH 3/3] avcodec/evc_parse: Check tid X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of > Michael Niedermayer > Sent: pi=B1tek, 13 pa=BCdziernika 2023 01:28 > To: FFmpeg development discussions and patches > Subject: [FFmpeg-devel] [PATCH 3/3] avcodec/evc_parse: Check tid > = > The check is based on not infinite looping. It is likely a more strict check can be > done > = > Fixes: Infinite loop > Fixes: 62473/clusterfuzz-testcase-minimized- > ffmpeg_BSF_EVC_FRAME_MERGE_fuzzer-5719883750703104 > Fixes: 62765/clusterfuzz-testcase-minimized-ffmpeg_dem_EVC_fuzzer- > 6448531252314112 > = > Found-by: continuous fuzzing process > https://protect2.fireeye.com/v1/url?k=3D06e4faf3-676fefea-06e571bc- > 74fe485cbfec-11816a289a0e9c00&q=3D1&e=3D16696cd9-38c1-42d0-9196- > 8ad7c6d1d0d6&u=3Dhttps%3A%2F%2Fgithub.com%2Fgoogle%2Foss- > fuzz%2Ftree%2Fmaster%2Fprojects%2Fffmpeg > Signed-off-by: Michael Niedermayer > --- > libavcodec/evc_parse.c | 3 +++ > 1 file changed, 3 insertions(+) > = > diff --git a/libavcodec/evc_parse.c b/libavcodec/evc_parse.c index > 255706ce61..43b8dabf8b 100644 > --- a/libavcodec/evc_parse.c > +++ b/libavcodec/evc_parse.c > @@ -174,6 +174,9 @@ int ff_evc_derive_poc(const EVCParamSets *ps, const > EVCParserSliceHeader *sh, > } else { > int SubGopLength =3D 1 << sps->log2_sub_gop_length; > = > + if (tid > (SubGopLength > 1 ? 1 + av_log2(SubGopLength - 1) : 0)) > + return AVERROR_INVALIDDATA; > + > if (tid =3D=3D 0) { > poc->PicOrderCntVal =3D poc->prevPicOrderCntVal + SubGopLength; > poc->DocOffset =3D 0; > -- > 2.17.1 > = My previous comment was related to a different patchset ([FFmpeg-devel,4/4] avcodec/evc_parse: Check tid) = I apologize for the mistake > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://protect2.fireeye.com/v1/url?k=3D63dfcc8a-0254d993-63de47c5- > 74fe485cbfec-e9d44b0bcc16ae00&q=3D1&e=3D16696cd9-38c1-42d0-9196- > 8ad7c6d1d0d6&u=3Dhttps%3A%2F%2Fffmpeg.org%2Fmailman%2Flistinfo%2Fffmp > eg-devel > = > To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org > with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".