From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/av1dec: fix matrix coefficients exposed by codec context
Date: Tue, 20 Feb 2024 15:30:26 -0300
Message-ID: <013cb056-189c-48bb-961e-1e28cc4a5d0b@gmail.com> (raw)
In-Reply-To: <20240220182901.2634807-1-jeebjp@gmail.com>
On 2/20/2024 3:28 PM, Jan Ekström wrote:
> `colorspace` in avcodec terms means `matrix coefficients`.
> ---
> libavcodec/av1dec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c
> index 7ffa7821e9..7debc4deda 100644
> --- a/libavcodec/av1dec.c
> +++ b/libavcodec/av1dec.c
> @@ -743,7 +743,7 @@ static int set_context_with_sequence(AVCodecContext *avctx,
> avctx->color_range =
> seq->color_config.color_range ? AVCOL_RANGE_JPEG : AVCOL_RANGE_MPEG;
> avctx->color_primaries = seq->color_config.color_primaries;
> - avctx->colorspace = seq->color_config.color_primaries;
> + avctx->colorspace = seq->color_config.matrix_coefficients;
> avctx->color_trc = seq->color_config.transfer_characteristics;
>
> switch (seq->color_config.chroma_sample_position) {
LGTM
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-02-20 18:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-20 18:28 Jan Ekström
2024-02-20 18:30 ` James Almer [this message]
2024-02-20 18:58 ` Jan Ekström
2024-02-20 20:55 ` Jan Ekström
2024-02-20 18:35 ` llyyr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=013cb056-189c-48bb-961e-1e28cc4a5d0b@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git