From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id EA8694FF8D for ; Fri, 4 Jul 2025 13:45:59 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 9312C68FA52; Fri, 4 Jul 2025 16:45:30 +0300 (EEST) Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 7BEDA68FA45 for ; Fri, 4 Jul 2025 16:45:27 +0300 (EEST) Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-74b56b1d301so645358b3a.1 for ; Fri, 04 Jul 2025 06:45:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751636726; x=1752241526; darn=ffmpeg.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date :references:in-reply-to:message-id:from:from:to:cc:subject:date :message-id:reply-to; bh=r8SH/fRAVYhG/ca304SKlWSA8P5e1jChmWOGK/h3sQ0=; b=Tb+wG1+Pdvimtaj1alcOCwMB1+hdJotsqfKKNWglMet3iD4crbJPrkSRJqEy7JcMwv T/fQE2ocCip7ko826ZB8Wy6AN5hQD+Wf7E/8P+75nIPLZ1XpIMZuaMvL8nAx4QGGfePv mlGpmNCFhyksB98+zCOeRcJ+355OOUTfKrXS8yOwuVqoAVmCRZeMVhMmd1IOIsDgb/Uu CgM/YNRx6zgKid4J2zsgXpnH5C5scWLxnqwYJhEHHtQ0WSP55zSXnjwK7owbt0P4Gbha QGvz/dF7/rz+4PsyT3Jn5s9W1PXS9jCcgNBZRhyFIPxbw9pS48/HpIm0f4l3iu4Xb6il I9FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751636726; x=1752241526; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date :references:in-reply-to:message-id:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=r8SH/fRAVYhG/ca304SKlWSA8P5e1jChmWOGK/h3sQ0=; b=NbX7DmG3VT8VYPdBAzWIX+nEGCrQQTzI/I6N7+G9nFnFL7I2B/DId3EidGlxkRDY5j 6p9JNe/1055mJ7tytlkPyYPLf+0Hg9CKzPU7UCFOpVnf1wzLlaUer3Xvo1zKMmrx1BqJ 7WgQL3CAw5BICgQ1chhSOXzsupYDX74jXyVVaYYnGSPpNN4xnMvAd6qXcsKhDVACgZ9b TUFvjW97CVXqOhS27CxWqtWQt8IOsW+NlCi+UgBsA0tGsUJklzkO5mjwfrzekyz/HMts h2QEoQganA3KQBPA2xU72euUaGP1VmXudGzFc0/XwZIxyui34KGm6AK2/WvA1YTEWcVH PJCg== X-Gm-Message-State: AOJu0YyLOg2NilrsEIqNnXwQVm7Xjb2SdWCgdFSMoTyFSO//WoKbfBFl YoLwk3dhvG5TCeqeyDG7TDduIoSxs7Kt4qqe0/L8BjBhUrXX8Vebk7dySzPX6g== X-Gm-Gg: ASbGncsBkxpGovuMSqBkiC325AGtkjqcT+LDAdOpLo9p6EZWQljWvpuTdIr42J22OLw X22ACdQEKNlWmmWrta4qsxgbXbANgM1cm0HHmn7YyAuhdV2KX3xd+Q8QBcRAeyc4vIfNkaNzdmk eJVNp0gGed9FSkC7pSGQr7eaEjYCqykGzR9YQPk0zcdrltauDPtChF85idibMo0ETfImuQXKsNs vgCtipPsxD/Hg2q/oozdiL0h4LVbCTwXsnOo5hMRzAem/mJCWYLEn0PPp/9NKyucABLYOrMzH54 4OBMV19SCFbHkTq3i3hpsGlf3ErPynXuelkTB6UJf25UeyWO73QfVfvqjp+oXZ82TqJV3H7pvQT rm/HN47kS/IeVOgOX X-Google-Smtp-Source: AGHT+IHojYaBEovA65SUmy1OcOyvI+F/YZS8kjt7cYVLP9dqkEpLrCukrdyuCcLJ4b9eK8Z5T95xIw== X-Received: by 2002:a05:6a00:1412:b0:748:fe3a:49f2 with SMTP id d2e1a72fcca58-74ce8ae79dbmr3171718b3a.21.1751636725589; Fri, 04 Jul 2025 06:45:25 -0700 (PDT) Received: from [127.0.0.1] (master.gitmailbox.com. [34.83.118.50]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-74ce43d4dc7sm2226578b3a.168.2025.07.04.06.45.25 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 04 Jul 2025 06:45:25 -0700 (PDT) From: Andreas Rheinhardt X-Google-Original-From: Andreas Rheinhardt Message-Id: <012886e0925a718478551e04c6c59c7fb9d35eb9.1751636697.git.ffmpegagent@gmail.com> In-Reply-To: References: X-Original-From: Andreas Rheinhardt Date: Fri, 04 Jul 2025 13:44:57 +0000 Fcc: Sent MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH 4/4] avcodec/get_bits: Remove GetBitContext.buffer_end X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: From: Andreas Rheinhardt It is unused. Furthermore, this automatically fixes the issue that init_get_bits() failure would lead to NULL + 0 (when setting buffer_end) which is UB before C23. This happened in the fic-avi and fic-avi-skip_cursor FATE-tests. This saved 7296B of .text here. Signed-off-by: Andreas Rheinhardt --- libavcodec/get_bits.h | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/libavcodec/get_bits.h b/libavcodec/get_bits.h index c64540cf95..80a77f0ae3 100644 --- a/libavcodec/get_bits.h +++ b/libavcodec/get_bits.h @@ -107,7 +107,7 @@ typedef BitstreamContext GetBitContext; #else // CACHED_BITSTREAM_READER typedef struct GetBitContext { - const uint8_t *buffer, *buffer_end; + const uint8_t *buffer; int index; int size_in_bits; int size_in_bits_plus8; @@ -512,7 +512,6 @@ static inline unsigned int show_bits_long(GetBitContext *s, int n) static inline int init_get_bits(GetBitContext *s, const uint8_t *buffer, int bit_size) { - int buffer_size; int ret = 0; if (bit_size >= INT_MAX - FFMAX(7, AV_INPUT_BUFFER_PADDING_SIZE*8) || bit_size < 0 || !buffer) { @@ -521,12 +520,9 @@ static inline int init_get_bits(GetBitContext *s, const uint8_t *buffer, ret = AVERROR_INVALIDDATA; } - buffer_size = (bit_size + 7) >> 3; - s->buffer = buffer; s->size_in_bits = bit_size; s->size_in_bits_plus8 = bit_size + 8; - s->buffer_end = buffer + buffer_size; s->index = 0; return ret; -- ffmpeg-codebot _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".