From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8D20A43D14 for ; Mon, 8 Aug 2022 12:47:22 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 02CA468B75A; Mon, 8 Aug 2022 15:47:21 +0300 (EEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DFAA468B726 for ; Mon, 8 Aug 2022 15:47:14 +0300 (EEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20220808124713euoutp0196f56fa4805828c59c465b3b65d11c2b~JX2cCtqhc0297902979euoutp01p for ; Mon, 8 Aug 2022 12:47:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20220808124713euoutp0196f56fa4805828c59c465b3b65d11c2b~JX2cCtqhc0297902979euoutp01p DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1659962833; bh=yDBvA6GLtf4HKkuvRnVMxzQEIbkF0eJsFjNWtBOrQA0=; h=From:To:In-Reply-To:Subject:Date:References:From; b=mNPUO9Fbvh7RdGstCn2f44soyPtTVjyYXHh6gOnj2v7SQcsPj5Sj/y5wJImmIEIxL mRHXg/7Ox4+pvjZK8k5EUWs+I5Fen48W73LVlCQjskbZwmV+ufCOEynx2JGFeq/3Od DYNyE/EITkEEVyTSDWQZPccjHhonhRj0qs4Gpalk= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20220808124713eucas1p29f8ef9291333a7aee98eb2ab2cdb6910~JX2b6E6Aj2158821588eucas1p2U for ; Mon, 8 Aug 2022 12:47:13 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id CD.AE.10067.1D501F26; Mon, 8 Aug 2022 13:47:13 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20220808124713eucas1p118bcdcae568934ff11e7c5fda50a06be~JX2bew-5D1249412494eucas1p1N for ; Mon, 8 Aug 2022 12:47:13 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20220808124713eusmtrp2f076fa2434bcad666e0c4378482748a2~JX2beFoNP3004930049eusmtrp2W for ; Mon, 8 Aug 2022 12:47:13 +0000 (GMT) X-AuditID: cbfec7f4-dd7ff70000002753-90-62f105d1b722 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id C7.08.09095.0D501F26; Mon, 8 Aug 2022 13:47:12 +0100 (BST) Received: from AMDN3260 (unknown [106.210.132.171]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20220808124712eusmtip24eff9f758e22534e70d46462c35ed386~JX2bOLnOj0913509135eusmtip2I for ; Mon, 8 Aug 2022 12:47:12 +0000 (GMT) From: =?utf-8?Q?Dawid_Kozinski/Robot_SDK_=28PLT=29_/?= =?utf-8?Q?SRPOL/Staff_Engineer/=EC=82=BC=EC=84=B1=EC=A0=84=EC=9E=90?= To: "'FFmpeg development discussions and patches'" In-Reply-To: Date: Mon, 8 Aug 2022 14:47:12 +0200 Message-ID: <011901d8ab24$fb31b1e0$f19515a0$@samsung.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQGcviT3Su2wfi8EL65XYlO9HuPOZAEsn7e4AcSMEiSuBUQREA== Content-Language: pl X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrOIsWRmVeSWpSXmKPExsWy7djPc7oXWT8mGfS0yFh8+3SG2YHR48+i zSwBjFFcNimpOZllqUX6dglcGX8OnmAq+KRUsfPUZeYGxh1SXYycHBICJhLP3jxnBLGFBFYw Suw8p9jFyAVkT2KS2L26jRnCmcgksebpI3aYjut/+pkgEssZJbY3L2WBcNqYJO629bOCOGwC Mxkl5n5dAzZYRMBHonv9elYQm1PAVmLKqnlsILawQIZE39LNzCA2i4CKxKw9X8HqeQUsJS6/ bGWGsAUlTs58wgJiMwvIS2x/O4cZ4gwFiZ9Pl7FCzHeSmLjhCBNEjYjEjUctjBA1Ezkkrs8R g7BdJFasvQ4VF5Z4dXwL1DsyEv93zgfq5QCyiyUO9TtAmDUSh36kQ1RYS7xtPM4IEmYW0JRY v0sfosJRYusZLQiTT+LGW0GI9XwSk7ZNZ4YI80p0tAlBmCoSfZ1Qh0hJPF02h3kCo9IsJP/N QvLfLCR/zELYuoCRZRWjeGppcW56arFRXmq5XnFibnFpXrpecn7uJkZgWjj97/iXHYzLX33U O8TIxMF4iFGCg1lJhPfI2vdJQrwpiZVVqUX58UWlOanFhxilOViUxHmTMzckCgmkJ5akZqem FqQWwWSZODilGpic1Cdt3sQQpBTPumxhfMx5k3VPp62f7zY/0k3HsmpXmaJSfFrxsXRNBfP0 qBX/3R9NjxORzVtlmXqdbdH/7kecN+on7QhLuuDu2X31u06MzWk317mNx1xaVTy3qgSoaUz9 0bC7ZMOOK0e3J6yavTtZw+Bo9v5V+t43nqSLL9R7Xtr1Q2JxJF9wo1yS6jcGVVGR5zc/ttrO vJWd3/fvkE6K9zM978N59g5CL3oDlBJ3sp78fm9zxEf9bsNZJgZmnJbLM6Y6JLGJm7M2dGr7 TPB/HZb6oXCbXkemyN+m+w3WseUv61scl6/LF1+fZutYs+Qzf+w6PVGllkChV68vR6ld2NQ8 71RJgbttWf10JZbijERDLeai4kQAVS7fXXoDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrPLMWRmVeSWpSXmKPExsVy+t/xe7oXWT8mGRy0s/j26QyzA6PHn0Wb WQIYo/RsivJLS1IVMvKLS2yVog0tjPQMLS30jEws9QyNzWOtjEyV9O1sUlJzMstSi/TtEvQy /hw8wVTwSali56nLzA2MO6S6GDk5JARMJK7/6WfqYuTiEBJYyihxYttSZoiElMTSpYsYIWxh iT/XutggilqYJCa9Ps0I4rAJTGeUOHmwjwmkSkTAR6J7/XpWEFtIYA+jxOzJviA2p4CtxJRV 89hAbGGBNInJTw6ygNgsAioSs/Z8BdvAK2ApcfllKzOELShxcuYTsBpmAW2JpzefQtnyEtvf zoG6TkHi59NlrBB7nSQmbjjCBFEjInHjUQvjBEahWUhGzUIyahaSUbOQtCxgZFnFKJJaWpyb nltsqFecmFtcmpeul5yfu4kRGBPbjv3cvINx3quPeocYmTgYDzFKcDArifAeWfs+SYg3JbGy KrUoP76oNCe1+BCjKdBvE5mlRJPzgVGZVxJvaGZgamhiZmlgamlmrCTO61nQkSgkkJ5Ykpqd mlqQWgTTx8TBKdXApKfblvtFouZLVm9YdL4o0wfX+4XvmzJEnGb89H145MJZNqHvVeL7/+ya cUbEnm9J6GdejwN7txV39ThZ2h0+c+3xpI4ndVlJC9NzZZ5FKwZwFMW8OPZoquqOk98nrbYu 2XJ4zufuus3Wlh1NHLJFAf8m9u3ZVTO3jmGy/O6OntB99vzvas5cXP1/suS1xcWhdfOcpjjZ 7Pts8mBuzLINbF9US27wzEg/2hw4zXpdiNrjZW8S3NPWFs/8bF/LVe2sx7rq69zlqdFb//jz CYY9cTFtKzjCftY7QOTa3M0OuseORxdvXeM8Y+uM6NMNb1zWJxy3dTQUjpOo3i7ysO3LJicv 770NMknW7Qt9votlKLEUZyQaajEXFScCABPQMpYSAwAA X-CMS-MailID: 20220808124713eucas1p118bcdcae568934ff11e7c5fda50a06be X-Msg-Generator: CA X-RootMTR: 20220801092901eucas1p1f8d764e6269c88872566d616b74a6b99 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20220801092901eucas1p1f8d764e6269c88872566d616b74a6b99 References: <002001d8a589$2272a170$6757e450$@samsung.com> Subject: Re: [FFmpeg-devel] [PATCH 2/2] Provided support for MPEG-5 EVC (Essential Video Coding) codec X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: I just uploaded new patches that were made based on your requests and suggestions. Please find below my comments. -----Original Message----- From: ffmpeg-devel On Behalf Of James Almer Sent: Monday, August 1, 2022 4:05 PM To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH 2/2] Provided support for MPEG-5 EVC (Essential Video Coding) codec On 8/1/2022 6:29 AM, Dawid Kozinski wrote: > diff --git a/libavformat/movenc.c b/libavformat/movenc.c > index 5608afde42..d0b094c30d 100644 > --- a/libavformat/movenc.c > +++ b/libavformat/movenc.c > @@ -1392,6 +1392,16 @@ static int mov_write_hvcc_tag(AVIOContext *pb, MOVTrack *track) > return update_size(pb, pos); > } > > +static int mov_write_evcc_tag(AVIOContext *pb, MOVTrack *track) > +{ > + int64_t pos = avio_tell(pb); > + > + avio_wb32(pb, 0); > + ffio_wfourcc(pb, "evcC"); Is that it? That's all this atom contains? No structure containing a global SPS/PPS? Is there a spec anywhere defining this? ############# DONE ############# > + > + return update_size(pb, pos); > +} > + > /* also used by all avid codecs (dv, imx, meridien) and their variants */ > static int mov_write_avid_tag(AVIOContext *pb, MOVTrack *track) > { > @@ -1641,6 +1651,16 @@ static int mov_get_h264_codec_tag(AVFormatContext *s, MOVTrack *track) > return tag; > } > > +static int mov_get_evc_codec_tag(AVFormatContext *s, MOVTrack *track) > +{ > + int tag = track->par->codec_tag; > + > + if (!tag) > + tag = MKTAG('e', 'v', 'c', 'i'); > + > + return tag; > +} > + > static const struct { > enum AVPixelFormat pix_fmt; > uint32_t tag; > @@ -1722,6 +1742,8 @@ static unsigned int mov_get_codec_tag(AVFormatContext *s, MOVTrack *track) > tag = mov_get_mpeg2_xdcam_codec_tag(s, track); > else if (track->par->codec_id == AV_CODEC_ID_H264) > tag = mov_get_h264_codec_tag(s, track); > + else if (track->par->codec_id == AV_CODEC_ID_EVC) > + tag = mov_get_evc_codec_tag(s, track); > else if (track->par->codec_id == AV_CODEC_ID_DNXHD) > tag = mov_get_dnxhd_codec_tag(s, track); > else if (track->par->codec_type == AVMEDIA_TYPE_VIDEO) { > @@ -2280,6 +2302,9 @@ static int mov_write_video_tag(AVFormatContext *s, AVIOContext *pb, MOVMuxContex > mov_write_avcc_tag(pb, track); > if (track->mode == MODE_IPOD) > mov_write_uuid_tag_ipod(pb); > + } > + else if (track->par->codec_id ==AV_CODEC_ID_EVC) { > + mov_write_evcc_tag(pb, track); > } else if (track->par->codec_id == AV_CODEC_ID_VP9) { > mov_write_vpcc_tag(mov->fc, pb, track); > } else if (track->par->codec_id == AV_CODEC_ID_AV1) { > @@ -6030,7 +6055,8 @@ int ff_mov_write_packet(AVFormatContext *s, AVPacket *pkt) > if ((par->codec_id == AV_CODEC_ID_DNXHD || > par->codec_id == AV_CODEC_ID_H264 || > par->codec_id == AV_CODEC_ID_HEVC || > - par->codec_id == AV_CODEC_ID_TRUEHD) && !trk->vos_len && > + par->codec_id == AV_CODEC_ID_TRUEHD || > + par->codec_id == AV_CODEC_ID_EVC) && !trk->vos_len && Why are you copying the first muxed packet's data (in the absence of extradata) into vos_data if you're seemingly doing nothing with it? I'd expect that's what the evcC tag should contain. ############# DONE ############# > !TAG_IS_AVCI(trk->tag)) { > /* copy frame to create needed atoms */ > trk->vos_len = size; > @@ -7689,6 +7715,7 @@ static const AVCodecTag codec_mp4_tags[] = { > { AV_CODEC_ID_H264, MKTAG('a', 'v', 'c', '3') }, > { AV_CODEC_ID_HEVC, MKTAG('h', 'e', 'v', '1') }, > { AV_CODEC_ID_HEVC, MKTAG('h', 'v', 'c', '1') }, > + { AV_CODEC_ID_EVC, MKTAG('e', 'v', 'c', '1') }, > { AV_CODEC_ID_MPEG2VIDEO, MKTAG('m', 'p', '4', 'v') }, > { AV_CODEC_ID_MPEG1VIDEO, MKTAG('m', 'p', '4', 'v') }, > { AV_CODEC_ID_MJPEG, MKTAG('m', 'p', '4', 'v') }, _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".