From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 316C443D17 for ; Mon, 8 Aug 2022 12:46:20 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E577368B75A; Mon, 8 Aug 2022 15:46:18 +0300 (EEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C048C68B72C for ; Mon, 8 Aug 2022 15:46:12 +0300 (EEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20220808124612euoutp027b4f748d1fcfc42afcd69ffbf8bc5c0a~JX1i3i7m92597825978euoutp02H for ; Mon, 8 Aug 2022 12:46:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20220808124612euoutp027b4f748d1fcfc42afcd69ffbf8bc5c0a~JX1i3i7m92597825978euoutp02H DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1659962772; bh=cU+kLlLg9NcKdzDGhs5a/En6OTyitSG35Gmmj0escek=; h=From:To:In-Reply-To:Subject:Date:References:From; b=KG20i78Lkkc0k9NLcqRjG51OW7TPKgqE12NXcfD1FrU0oGBSweMx1nL84oa2zXP8e TOYYCDzfgLlnCU3cAU39XkRJI3TEphghfECBvBgaGXf5rjplcF0jvie3IiHklF0AbW yVmXAQLRvQTMMJD2v1pv4y0+IDqgothUWW+J85vM= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20220808124612eucas1p203a1b1701bec5c9bdc2259cb5d04d366~JX1iss1H41970619706eucas1p2F for ; Mon, 8 Aug 2022 12:46:12 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 88.2B.09580.49501F26; Mon, 8 Aug 2022 13:46:12 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20220808124611eucas1p1a4684ecc704fa9cc6a7137b8bf40af18~JX1iV_6jk1475714757eucas1p1h for ; Mon, 8 Aug 2022 12:46:11 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20220808124611eusmtrp13aba5ff912b555cd444fdf38214a6334~JX1iVY9he0413504135eusmtrp1m for ; Mon, 8 Aug 2022 12:46:11 +0000 (GMT) X-AuditID: cbfec7f5-9c3ff7000000256c-d1-62f10594885a Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 92.D7.09095.39501F26; Mon, 8 Aug 2022 13:46:11 +0100 (BST) Received: from AMDN3260 (unknown [106.210.132.171]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20220808124611eusmtip2538bfe3d19c3e18e1917165a8fe8f117~JX1iIyH900464204642eusmtip2Y for ; Mon, 8 Aug 2022 12:46:11 +0000 (GMT) From: =?utf-8?Q?Dawid_Kozinski/Robot_SDK_=28PLT=29_/?= =?utf-8?Q?SRPOL/Staff_Engineer/=EC=82=BC=EC=84=B1=EC=A0=84=EC=9E=90?= To: "'FFmpeg development discussions and patches'" In-Reply-To: <20220801193053.GF2088045@pb2> Date: Mon, 8 Aug 2022 14:46:11 +0200 Message-ID: <011801d8ab24$d6a72440$83f56cc0$@samsung.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQGcviT3Su2wfi8EL65XYlO9HuPOZAEsn7e4ATtjp16t/7U/wA== Content-Language: pl X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrJIsWRmVeSWpSXmKPExsWy7djPc7pTWD8mGVz7wGLx7dMZZgdGjz+L NrMEMEZx2aSk5mSWpRbp2yVwZdye3cxS8F+gYsmsPtYGxuM8XYycHBICJhIvN7ewdTFycQgJ rGCUmNXQwgjhTGKSWPDvACuEM5FJ4vuDG+wwLTvmnodKLGeUWLjwPVR/G5PE5203mUAcNoGZ jBJzv65hBGkREfCR6F6/nhXE5hTQlvh7dBbYKGGBDIm+pZuZQWwWARWJs5MfgNm8ApYSm/Zs ZIWwBSVOznzCAmIzC8hLbH87hxniDAWJn0+XsULMd5L49nMOE0SNiMSNRxBPSAhM5ZA4N/0O K0SDi0TX4ptQzcISr45vgfpHRuL05B6gBRxAdrHEoX4HCLNG4tCPdIgKa4m3jccZQcLMApoS 63fpQ1Q4Smw9owVh8knceCsIsZ9PYtK26cwQYV6JjjYhCFNFoq9TDGKclMTTZXOYJzAqzULy 4CwkD85C8sgshK0LGFlWMYqnlhbnpqcWG+ellusVJ+YWl+al6yXn525iBKaG0/+Of93BuOLV R71DjEwcjIcYJTiYlUR4j6x9nyTEm5JYWZValB9fVJqTWnyIUZqDRUmcNzlzQ6KQQHpiSWp2 ampBahFMlomDU6qBadMn5UR/X0n5T7ZHltXZ3H6d1aOufvtriJXN8i9cRnanPkYcOdqRVqKS f4f7rP6d1waJVzZs3ru3O7S4szA0tfVVaMmJyZ9vWos+vlrxWHvTHg2GdMbaXWu68zJ3bOr6 ca/Rp8U52+iQ43se2abGlIf+TJqLZ9vu6HM+uSiB6b3gDCPlzwrzXq16t5Z/k3bnkn15PvKx 31ZnX7NoUWE8s+NUTs571t9XLA8KifLXvF2iklF0Zsd66XM/REUPv/S9omC3K9335CUl08za 529bXkpvOfBkfXpzc44909RH9xfs7Tdl+tGVNNtl59v3cxlvCHVYJoXteukzbW2fuR3vWSGn Xyk/+X8p3PZbNPPXByWW4oxEQy3mouJEALyhNyJ8AwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpgkeLIzCtJLcpLzFFi42I5/e/4Pd3JrB+TDF7O0bL49ukMswOjx59F m1kCGKP0bIryS0tSFTLyi0tslaINLYz0DC0t9IxMLPUMjc1jrYxMlfTtbFJSczLLUov07RL0 Mm7PbmYp+C9QsWRWH2sD43GeLkZODgkBE4kdc8+zdjFycQgJLGWUeHphKjtEQkpi6dJFjBC2 sMSfa11sILaQQAuTxLS51SANbALTGSVOHuxjAkmICPhIdK9fDzVpFaPEk0ufwDo4BbQl/h6d BTZVWCBNYvKTgywgNouAisTZyQ+YQWxeAUuJTXs2skLYghInZz4Bq2EG6n168ymULS+x/e0c ZoiLFCR+Pl3GCrHYSeLbzzlMEDUiEjcetTBOYBSahWTULCSjZiEZNQtJywJGllWMIqmlxbnp ucWGesWJucWleel6yfm5mxiBUbHt2M/NOxjnvfqod4iRiYPxEKMEB7OSCO+Rte+ThHhTEiur Uovy44tKc1KLDzGaAv02kVlKNDkfGJd5JfGGZgamhiZmlgamlmbGSuK8ngUdiUIC6Yklqdmp qQWpRTB9TBycUg1MXb7epz4dkup4E9Uut2/aAzGeqb8dmJOnezYf/H1o4dt7jOpKhQxhL0wm Tnd3lzsw9z3Tnqkzj0y6pzlxgd7hew9XvWyJ0Z/x6duVby/nv5znf7xPu+TZt/+l25R9o5eq WlxK6s2qTXv0Qj12p8Bf443nEhyvds1e2PTz47qirT89/v8tWSlzzuGs944l/PVqezO39nx9 uvrfuu2BbnccD1laVC44zH32oAJ7PIP7qXPN0ZpqCybJcL6ynCXOu2VuidmU/Zc/JetY7Tx+ 9629wreZorr87VP/SK2trxVaragmt1nw+wzdXI2vh+bPuyrnUnQlM/T0G6VVmpx6KwSTp4v4 97BUOcVa3p+UOs11sqoSS3FGoqEWc1FxIgCi3Y7wEwMAAA== X-CMS-MailID: 20220808124611eucas1p1a4684ecc704fa9cc6a7137b8bf40af18 X-Msg-Generator: CA X-RootMTR: 20220801092901eucas1p1f8d764e6269c88872566d616b74a6b99 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20220801092901eucas1p1f8d764e6269c88872566d616b74a6b99 References: <002001d8a589$2272a170$6757e450$@samsung.com> <20220801193053.GF2088045@pb2> Subject: Re: [FFmpeg-devel] [PATCH 2/2] Provided support for MPEG-5 EVC (Essential Video Coding) codec X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: I just uploaded new patches that were made based on your requests and suggestions. -----Original Message----- From: ffmpeg-devel On Behalf Of Michael Niedermayer Sent: Monday, August 1, 2022 9:31 PM To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 2/2] Provided support for MPEG-5 EVC (Essential Video Coding) codec On Mon, Aug 01, 2022 at 11:29:01AM +0200, Dawid Kozinski wrote: [...] > +static int get_nalu_type(const uint8_t *bits, int bits_size) > +{ > + int unit_type_plus1 = 0; > + > + if(bits_size >= EVC_NAL_HEADER_SIZE) { > + unsigned char *p = (unsigned char *)bits; > + // forbidden_zero_bit > + if ((p[0] & 0x80) != 0) { > + av_log(NULL, AV_LOG_ERROR, "Cannot get bitstream information. Malformed bitstream.\n"); > + return -1; > + } > + > + // nal_unit_type > + unit_type_plus1 = (p[0] >> 1) & 0x3F; > + } > + > + return unit_type_plus1 - 1; > +} > + > +static uint32_t read_nal_unit_length(const uint8_t *bits, int bits_size) > +{ > + uint32_t nalu_len = 0; > + > + if(bits_size >= EVC_NAL_UNIT_LENGTH_BYTE) { > + > + int t = 0; > + unsigned char *p = (unsigned char *)bits; > + > + for(int i=0; i + t = (t << 8) | p[i]; > + } > + > + nalu_len = t; > + if(nalu_len == 0) { > + av_log(NULL, AV_LOG_ERROR, "Invalid bitstream size!\n"); These av_log() are a problem as they are in probing code probing code would be run on all kinds of input, most not EVC so "errors" are common while at the same time they are not real errors. That would make probing very noisy ####### DONE ####### thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The real ebay dictionary, page 1 "Used only once" - "Some unspecified defect prevented a second use" "In good condition" - "Can be repaird by experienced expert" "As is" - "You wouldnt want it even if you were payed for it, if you knew ..." _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".