From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5A9A848CE7 for ; Thu, 23 May 2024 19:50:52 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2F96168D4EC; Thu, 23 May 2024 22:50:37 +0300 (EEST) Received: from a27-233.smtp-out.us-west-2.amazonses.com (a27-233.smtp-out.us-west-2.amazonses.com [54.240.27.233]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 92AD668D4CF for ; Thu, 23 May 2024 22:50:27 +0300 (EEST) To: =?UTF-8?Q?ffmpeg-devel=40ffmpeg=2Eorg?= Date: Thu, 23 May 2024 19:50:24 +0000 Mime-Version: 1.0 In-Reply-To: <20240523195019.64019-1-cosmin@cosmin.at> References: <20240523195019.64019-1-cosmin@cosmin.at> <20240523195019.64019-3-cosmin@cosmin.at> X-Mailer: Amazon WorkMail Thread-Index: AQHarUpyU8iX1OOeTgC/HI1UPzU75gAAAE2X Thread-Topic: [PATCH v3 2/5] avcodec/dovi_rpuenc - guard metadata compression X-Original-Mailer: git-send-email 2.42.1 X-Wm-Sent-Timestamp: 1716493823 Message-ID: <0101018fa701338b-9788938f-7752-4af2-b15b-f90d1d3f4e0c-000000@us-west-2.amazonses.com> Feedback-ID: ::1.us-west-2.An468LAV0jCjQDrDLvlZjeAthld7qrhZr+vow8irkvU=:AmazonSES X-SES-Outgoing: 2024.05.23-54.240.27.233 Subject: [FFmpeg-devel] [PATCH v3 2/5] avcodec/dovi_rpuenc - guard metadata compression X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cosmin Stejerean via ffmpeg-devel Reply-To: FFmpeg development discussions and patches Cc: =?UTF-8?Q?Cosmin_Stejerean?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: From: Cosmin Stejerean Guard use_prev_vdr_rpu by the new enable_compression field since not all clients support this. Separately output when vdr_dm_metadata_changed == 0 fails the DV verifier so turn that off unconditionally for now. --- libavcodec/dovi_rpuenc.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libavcodec/dovi_rpuenc.c b/libavcodec/dovi_rpuenc.c index 3c3e0f84c0..26ed25733a 100644 --- a/libavcodec/dovi_rpuenc.c +++ b/libavcodec/dovi_rpuenc.c @@ -512,8 +512,12 @@ int ff_dovi_rpu_generate(DOVIContext *s, const AVDOVIMetadata *metadata, } } - vdr_dm_metadata_changed = !s->color || memcmp(s->color, color, sizeof(*color)); - use_prev_vdr_rpu = !memcmp(&s->vdr[vdr_rpu_id]->mapping, mapping, sizeof(*mapping)); + // the output when vdr_dm_metadata_changed is 0 fails the DV verifier + // force it to 1 until we can get some samples or documentation on correct syntax + vdr_dm_metadata_changed = 1; // !s->color || memcmp(s->color, color, sizeof(*color)); + + // not all clients support metadata compression + use_prev_vdr_rpu = s->enable_compression && !memcmp(&s->vdr[vdr_rpu_id]->mapping, mapping, sizeof(*mapping)); buffer_size = 12 /* vdr seq info */ + 5 /* CRC32 + terminator */; buffer_size += num_ext_blocks_v1 * 13; -- 2.42.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".