Re: [FFmpeg-devel] [PATCH 01/13] avformat/flvenc: Implement support for multi-track video

[Cosmin Stejerean via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>]

> On May 21, 2024, at 11:48 AM, Dennis Sädtler via ffmpeg-devel <ffmpeg-devel@ffmpeg.org> wrote:
> 
>> From: Dennis Sädtler via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
> 
> I wonder what happened here, did I make a mistake when submitting the
> original patch to the ML so the actual commit author name/email got
> lost?
> 
> Should be the same as the signed-off section based on the repo I
> submitted it from:
> https://github.com/derrod/ffmpeg/commit/25f1700cffa00fcd04bcc27efce077a93e7f5142
> 

The problem is the mailing list rewrites the message (to for example add the footer at the bottom). It cannot do that and keep the from email address if you have email security configured properly for the domain (as it would get rejected). 

So the mailing list changes the from to ".... via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>". Furthermore git send-email won't include "From:" in the patch body if the commit authorship matches the from email address on git send-email. 

However I've found a workaround. By setting my git send-email from to just "cosmin@cosmin.at <mailto:cosmin@cosmin.at>" rather than "Cosmin Stejerean <cosmin@cosmin.at <mailto:cosmin@cosmin.at>>" then the emails that go out will have the "From: " as the first line of the body, so the patches apply properly. You can see my most recent patch for example.

You can add an entry to .mailmap to handle any previous commits that have been pushed using the "via ffmpeg-devel" rewrite, see my entry for example.


- Cosmin




_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".