From: Cosmin Stejerean via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: "FFmpeg development discussions and patches" <ffmpeg-devel@ffmpeg.org>
Cc: "Cosmin Stejerean" <cosmin@cosmin.at>
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libsvtav1: send the EOS signal without a one frame delay to allow for the library to operate in a low-delay mode
Date: Tue, 27 Feb 2024 22:22:31 +0000
Message-ID: <0101018deca99026-2143cb86-74ea-47b3-84b1-ee467f08e0f9-000000@us-west-2.amazonses.com> (raw)
In-Reply-To: <d7c131ed-0bda-4061-8701-77fc47ab9763@gmail.com>
> On Feb 27, 2024, at 1:49 PM, James Almer <jamrial@gmail.com> wrote:
>
>>> SVT-AV1 1.8.0 has this value set to 1.8.0, same as in the current git head commit. Is this in preparation for an upcoming release?
>> Yes, this is in preparation for release 2.0 which is targeted for next week. https://gitlab.com/AOMediaCodec/SVT-AV1/-/issues/2155 is tracking the status, and this API change is one of the outstanding items.
>
> Without this patch, the command "ffmpeg -lavfi testsrc,format=yuv420p -vframes 101 -c:v libsvtav1 -loglevel debug -f null -" gives this:
>
>> Output stream #0:0 (video): 101 frames encoded; 101 packets muxed (17890 bytes);
>> Total: 101 packets (17890 bytes) muxed
>> frame= 101 fps=0.0 q=31.0 Lsize=N/A time=00:00:04.00 bitrate=N/A
>
> Whereas with it applied, i get:
>
>> Output stream #0:0 (video): 101 frames encoded; 100 packets muxed (17885 bytes);
>> Total: 100 packets (17885 bytes) muxed
>> frame= 100 fps=0.0 q=35.0 Lsize=N/A time=00:00:03.96 bitrate=N/A
>
> If i pass it a single frame, i get no output at all. So the last frame is being lost.
This change depends on the API change on the SVT-AV1 side, which is in in https://gitlab.com/AOMediaCodec/SVT-AV1/-/merge_requests/2189
This will get merged in shortly as part of the 2.0 release. If I build this patch against the low-delay-api-change branch (from PR 2189) then I get
> Output stream #0:0 (video): 101 frames encoded; 101 packets muxed (17970 bytes);
> Total: 101 packets (17970 bytes) muxed
- Cosmin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-02-27 22:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240223232136.49044-1-cosmin@cosmin.at>
2024-02-23 23:21 ` Cosmin Stejerean via ffmpeg-devel
2024-02-27 21:19 ` James Almer
[not found] ` <6998C5B5-9E87-4E92-81C4-E22AC2956821@cosmin.at>
2024-02-27 21:36 ` Cosmin Stejerean via ffmpeg-devel
2024-02-27 21:49 ` James Almer
[not found] ` <95514F26-31A6-4A83-9FC9-D61323040FED@cosmin.at>
2024-02-27 22:22 ` Cosmin Stejerean via ffmpeg-devel [this message]
2024-02-27 22:36 ` James Almer
[not found] <20240521011728.29347-1-cosmin@cosmin.at>
[not found] ` <20240521011728.29347-2-cosmin@cosmin.at>
2024-05-21 1:17 ` Cosmin Stejerean via ffmpeg-devel
[not found] ` <A69148C5-81DD-495E-926C-62D0D6F81862@cosmin.at>
2024-05-21 3:38 ` Cosmin Stejerean via ffmpeg-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0101018deca99026-2143cb86-74ea-47b3-84b1-ee467f08e0f9-000000@us-west-2.amazonses.com \
--to=ffmpeg-devel@ffmpeg.org \
--cc=cosmin@cosmin.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git