From: Cosmin Stejerean via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: "FFmpeg development discussions and patches" <ffmpeg-devel@ffmpeg.org>
Cc: "Cosmin Stejerean" <cosmin@cosmin.at>
Subject: Re: [FFmpeg-devel] [PATCH] lavc/libopenh264: Drop openh264 runtime version checks
Date: Fri, 8 Dec 2023 19:12:24 +0000
Message-ID: <0101018c4ad86500-fef4d340-bd76-4ac2-8115-2f6203fd89ff-000000@us-west-2.amazonses.com> (raw)
In-Reply-To: <CAHjaNbpYFCeNsKW9eYb2NuV-V=z8z_NAt-_4ZKLbM5K5HCVoZQ@mail.gmail.com>
> On Dec 8, 2023, at 11:07 AM, Kalev Lember <klember@redhat.com> wrote:
>
> On Fri, Dec 8, 2023 at 4:59 PM James Almer <jamrial@gmail.com> wrote:
>
>> Does the configure check ensure a new enough openh264 version is the
>> minimum supported?
>>
>
> Hm, I'd say that configure minimum version check is mostly orthogonal to
> the patch here.
>
> This patch just removes a check that made it error out if the build time
> and runtime versions didn't perfectly match (as in, 1.0.0 at build time and
> 1.0.1 at run time would have resulted in erroring out). Basically just
> makes it behave like with all other libraries :)
As of what version of openh264 though is it safe to assume that ABI won't change without soname changes? Since years ago ABI changes without soname changes were present there's likely to be some minimum version above which runtime version checks are not needed.
- Cosmin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-12-08 19:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 8:15 Kalev Lember
2023-12-08 8:39 ` Martin Storsjö
2023-12-08 11:49 ` Kalev Lember
2023-12-08 12:00 ` Martin Storsjö
2023-12-08 12:11 ` Kalev Lember
2023-12-08 12:17 ` Martin Storsjö
2023-12-08 15:48 ` Neal Gompa
2023-12-08 15:58 ` James Almer
2023-12-08 19:07 ` Kalev Lember
2023-12-08 19:12 ` James Almer
[not found] ` <66731BE2-B56B-4F28-80D6-D5599C76CD04@cosmin.at>
2023-12-08 19:12 ` Cosmin Stejerean via ffmpeg-devel [this message]
2023-12-08 20:03 ` Kalev Lember
2023-12-08 20:34 ` Martin Storsjö
2023-12-09 21:03 ` Kalev Lember
2023-12-09 21:07 Kalev Lember
2023-12-18 22:15 ` Martin Storsjö
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0101018c4ad86500-fef4d340-bd76-4ac2-8115-2f6203fd89ff-000000@us-west-2.amazonses.com \
--to=ffmpeg-devel@ffmpeg.org \
--cc=cosmin@cosmin.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git