From: Cosmin Stejerean via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: "FFmpeg development discussions and patches" <ffmpeg-devel@ffmpeg.org>
Cc: "Cosmin Stejerean" <cosmin@cosmin.at>
Subject: Re: [FFmpeg-devel] [PATCH v7 3/7] avcodec/webp_parser: parse each frame into one packet
Date: Fri, 8 Dec 2023 02:02:24 +0000
Message-ID: <0101018c47296762-91233252-a853-4010-9f1a-fb92c34408e6-000000@us-west-2.amazonses.com> (raw)
In-Reply-To: <AS8P250MB0744273A3F1FD08503DE97198F8BA@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>
> On Dec 7, 2023, at 9:42 AM, Andreas Rheinhardt <andreas.rheinhardt@outlook.com> wrote:
>
> According to
> https://developers.google.com/speed/webp/docs/riff_container#extended_file_format
> metadata chunks are stored after the image data; if you split the data
> into packets, then the metadata while only become available for the very
> last frame, although it pertains to all of them. This makes your
> approach unworkable.
>
> Additionally, the WebP muxer expects animations to be contained in a
> single packet, hence the warnings from Michael.
What would be a better approach here, keeping all the animations in a single packet and decoding multiple frames from it, by essentially moving this logic to split them from the parser to the decoder?
- Cosmin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-12-08 2:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 1:34 [FFmpeg-devel] [PATCH v7 0/7] webp: add support for animated WebP decoding Thilo Borgmann via ffmpeg-devel
2023-12-06 1:34 ` [FFmpeg-devel] [PATCH v7 1/7] avcodec/webp: move definitions into header Thilo Borgmann via ffmpeg-devel
2023-12-07 16:09 ` Anton Khirnov
2023-12-06 1:35 ` [FFmpeg-devel] [PATCH v7 2/7] avcodec/webp: remove unused definitions Thilo Borgmann via ffmpeg-devel
2023-12-06 1:35 ` [FFmpeg-devel] [PATCH v7 3/7] avcodec/webp_parser: parse each frame into one packet Thilo Borgmann via ffmpeg-devel
2023-12-07 17:42 ` Andreas Rheinhardt
[not found] ` <53478080-5F0E-489B-828D-9EF1F22F3D4F@cosmin.at>
2023-12-08 2:02 ` Cosmin Stejerean via ffmpeg-devel [this message]
2023-12-12 12:14 ` Thilo Borgmann via ffmpeg-devel
2023-12-06 1:35 ` [FFmpeg-devel] [PATCH v7 4/7] libavcodec/webp: add support for animated WebP decoding Thilo Borgmann via ffmpeg-devel
2023-12-06 1:35 ` [FFmpeg-devel] [PATCH v7 5/7] avcodec/webp: make init_canvas_frame static Thilo Borgmann via ffmpeg-devel
2023-12-06 1:35 ` [FFmpeg-devel] [PATCH v7 6/7] libavformat/webp: add WebP demuxer Thilo Borgmann via ffmpeg-devel
2023-12-06 1:35 ` [FFmpeg-devel] [PATCH v7 7/7] fate: add test for animated WebP Thilo Borgmann via ffmpeg-devel
2023-12-06 22:01 ` [FFmpeg-devel] [PATCH v7 0/7] webp: add support for animated WebP decoding Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0101018c47296762-91233252-a853-4010-9f1a-fb92c34408e6-000000@us-west-2.amazonses.com \
--to=ffmpeg-devel@ffmpeg.org \
--cc=cosmin@cosmin.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git