From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1E7A747307 for ; Thu, 5 Oct 2023 17:22:56 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 970B468CBAF; Thu, 5 Oct 2023 20:22:53 +0300 (EEST) Received: from a27-234.smtp-out.us-west-2.amazonses.com (unknown [54.240.27.234]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 31DB068CB79 for ; Thu, 5 Oct 2023 20:22:46 +0300 (EEST) To: =?UTF-8?Q?FFmpeg_development_discussions_and_patches?= Date: Thu, 5 Oct 2023 17:22:43 +0000 Mime-Version: 1.0 In-Reply-To: References: <216A8695-AE2C-4CB1-8704-DA82139B4C75@cosmin.at> X-Priority: 3 (Normal) X-Mailer: Amazon WorkMail Thread-Index: AQHZ9a8smT1A98kPRjOmt3E2Hm5ojQAaPsXZAGF0Uz0AgFgLiw== Thread-Topic: [FFmpeg-devel] [PATCH] aacdec: padding skip improvements X-Original-Mailer: Apple Mail (2.3731.700.6) X-Wm-Sent-Timestamp: 1696526562 Message-ID: <0101018b00dcf9aa-91fd01f2-137d-4300-990f-fdfde163c27f-000000@us-west-2.amazonses.com> Feedback-ID: 1.us-west-2.An468LAV0jCjQDrDLvlZjeAthld7qrhZr+vow8irkvU=:AmazonSES X-SES-Outgoing: 2023.10.05-54.240.27.234 Subject: Re: [FFmpeg-devel] [PATCH] aacdec: padding skip improvements X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cosmin Stejerean via ffmpeg-devel Reply-To: FFmpeg development discussions and patches Cc: =?UTF-8?Q?Cosmin_Stejerean?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > On Oct 4, 2023, at 7:37 PM, Lynne wrote: > > 2048 is just more widely encountered. I'm posting these patches > to get an opinion: > - do we cut nothing at all (currently) > - do we cut 1024 (required by the standard/algorithm, and currently what our AAC ENcoder outputs) > - do we cut 2048 (what is most widely expected) > > My preference would be 1024. Note: this is only for raw AAC > streams outside of a container. Streams inside of a container are currently > correctly cut, with this value being overridden. I think it would be good by default to have the ffmpeg encoder and decoder roundtrip correctly, and then leverage an option to specify a different padding if a different encoder was used. I think the important property is that if we take a PCM input, encode it to raw AAC with ffmpeg and then decode it to PCM output that we have the same number of PCM samples and they're all properly aligned. Since we can't correctly handle unknown encoders (that might be using 2048 or 2112 priming samples) for the option to override the priming samples should be used in that case (which could also be set to 0 if someone really wants potentially distorted output before the decoder was properly primed). - Cosmin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".