From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id DE8A1457F0 for ; Fri, 24 Mar 2023 13:45:17 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9CA8A68C7EF; Fri, 24 Mar 2023 15:45:14 +0200 (EET) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 392A968C7D8 for ; Fri, 24 Mar 2023 15:45:07 +0200 (EET) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20230324134505euoutp01cd3894873d449382fab171e76ad3d3f8~PXuCukTP51883218832euoutp01h for ; Fri, 24 Mar 2023 13:45:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20230324134505euoutp01cd3894873d449382fab171e76ad3d3f8~PXuCukTP51883218832euoutp01h DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1679665505; bh=0hOvNVZc3AgGxr+aY3goYrRhmSaxIYyveVrocetDRi4=; h=From:To:In-Reply-To:Subject:Date:References:From; b=lJTYhdSU9NAZ7AwJNeZmXfQruVCbEdC7CeliF2jHVc+0L0yHXcBGLXC4LcPuIWxFc Z+pRFLwhjIt4xEQHWJ9D0NGWIUWV1dn+asNFRtHefubaY5MzY4aCaTZYmht2AirvYc Gd7anx5Jb9uoFZyNRzaTv6eHB0+jR+FPIIKLoFOE= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20230324134505eucas1p10817c5fd341b047d2537aa36ff592942~PXuCoH0qw3266632666eucas1p1v for ; Fri, 24 Mar 2023 13:45:05 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 08.0A.10014.069AD146; Fri, 24 Mar 2023 13:45:04 +0000 (GMT) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20230324134504eucas1p2d8309121d3a0987f92fa2124bd8fabe6~PXuCKitts0104701047eucas1p2W for ; Fri, 24 Mar 2023 13:45:04 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20230324134504eusmtrp1fc2e4b1de771f8beae25ac10ad409039~PXuCJ7o5W2018920189eusmtrp1a for ; Fri, 24 Mar 2023 13:45:04 +0000 (GMT) X-AuditID: cbfec7f5-ba1ff7000000271e-28-641da96035c6 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id CC.A5.09583.069AD146; Fri, 24 Mar 2023 13:45:04 +0000 (GMT) Received: from AMDN5164 (unknown [106.210.132.171]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20230324134503eusmtip1b44deafdcff05c0e1f1ac6614d9b6317~PXuBdaH4L2634226342eusmtip1a for ; Fri, 24 Mar 2023 13:45:03 +0000 (GMT) From: "Dawid Kozinski/Multimedia \(PLT\) /SRPOL/Staff Engineer/Samsung Electronics" To: "'FFmpeg development discussions and patches'" In-Reply-To: Date: Fri, 24 Mar 2023 14:45:02 +0100 Message-ID: <00f801d95e56$d6654620$832fd260$@samsung.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQGi1gSVKM9sxuA0mvu9CLea3q5TRAKHJ0jWAh0yiOivUd4vcA== Content-Language: pl X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrNIsWRmVeSWpSXmKPExsWy7djP87oJK2VTDL7tMrX49ukMswOjx59F m1kCGKO4bFJSczLLUov07RK4MhY8mcNaMPEtY8WDya+YGxhnb2LsYuTkkBAwkXi94iZ7FyMX h5DACkaJT2umsEE4k5gkjjZPY4FwJjJJ7D7xkRWm5f2a/1CJ5YwS7yZvZoJw2pgkdqz+xQRS xSaQJ/H481pmEFtEwEeie/16sG5OARWJ7et/gMWFBZIlPnedZAGxWQRUJSZO3wwW5xWwlDh3 sxfKFpQ4OfMJWA2zgLzE9rdzmCGuUJD4+XQZK8R8J4mGGbfZIWpEJG48amEEOUhCYCqHxMzT C6EaXCTutDdAfS0s8er4FnYIW0bi9OQeoAUcQHaxxKF+BwizRuLQj3SICmuJt43HGUHCzAKa Eut36UOEHSUatjQyQlTzSdx4KwhxAJ/EpG3TmSHCvBIdbUIQpopEX6cYRKOUxNNlc5gnMCrN QvLhLCQfzkLyySyEtQsYWVYxiqeWFuempxYb56WW6xUn5haX5qXrJefnbmIEpofT/45/3cG4 4tVHvUOMTByMhxglOJiVRHjfhcimCPGmJFZWpRblxxeV5qQWH2KU5mBREufVtj2ZLCSQnliS mp2aWpBaBJNl4uCUamBaX8qhL76nmL85ZfGUuRy736ycfjHsc9Z6ds3Da9dEnIhznqZSu+9W WZHtbH7/QpWkSX9WbZ/FV6T+dI1tXIsH/9Qq5W8xZSZzb8dOCWRTfqzoOEnpUOKe2J2RFR2f HzE1qeRuiLn/N/8hj1Kz658Gy91KM345qqfznhT/lKA8Xy/mwsG4G4frN4tvyHz3LM/JqvPI Xw3LxBjW4LV3jFb6BPJXPPmmmOZ9/uLCl0bP2vprTRuDtjlHHUx33M6ZLPXtnFrEHZ01irns j85OXCZ/qcl9Xr/oucuGop+s+xOertjW+jXFYOnPsvnKBiF8xpNluO22f/oj4+H+2eB72Afh Bd6yDxu8Nnvpfw3ZO1OJpTgj0VCLuag4EQCCI5YTfgMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrPLMWRmVeSWpSXmKPExsVy+t/xu7oJK2VTDM63iFt8+3SG2YHR48+i zSwBjFF6NkX5pSWpChn5xSW2StGGFkZ6hpYWekYmlnqGxuaxVkamSvp2NimpOZllqUX6dgl6 GQuezGEtmPiWseLB5FfMDYyzNzF2MXJySAiYSLxf858FxBYSWMoo8eaMOURcSmLp0kVQNcIS f651sXUxcgHVtDBJPFt0gQkkwSaQI7F29kQwW0TAR6J7/XpWiKIljBIvT39lB0lwCqhIbF// gxnEFhZIlHj/cStYA4uAqsTE6ZvB4rwClhLnbvZC2YISJ2c+AbqIg4NZQE+ibSPYEcwC8hLb 385hhjhIQeLn02WsEHudJBpm3GaHqBGRuPGohXECo9AsJJNmIUyahWTSLCQdCxhZVjGKpJYW 56bnFhvpFSfmFpfmpesl5+duYgTGxLZjP7fsYFz56qPeIUYmDsZDjBIczEoivO9CZFOEeFMS K6tSi/Lji0pzUosPMZoCfTaRWUo0OR8YlXkl8YZmBqaGJmaWBqaWZsZK4ryeBR2JQgLpiSWp 2ampBalFMH1MHJxSDUzMzLel038z+WxYsu/ewT53BiORBzNebU1t1HHbfSp8zhmDKYf3b/po c+nfwXCLjKf6iqrbst7+XHOLMcajMmbCzov/Vx45mMwjOGnttqX6mUt4u98m1l2/3aB670zX 7jeFJ9bl6TZpRydeyFzxIsP1YVSw1qk80/JbFbZsrEmZ03JaZjFOFhU6fdC2XbHgbK/s+an8 eYuusP1ebGASOlV7+jV+nW1lkRNepD8MnVJwzXGPaXYWh6+uoqLQnAcfLgonrvkt8X5D3Jb9 5g8e/vnx//Ez23+rUp6GOXIZxqtvvLhAo/5ERvDkrx8qdj6rPf/p6wvLgt0LNzdPbHGquH/n UcT9CTMXye1z8GWVWbOmWYmlOCPRUIu5qDgRAIw8MW0SAwAA X-CMS-MailID: 20230324134504eucas1p2d8309121d3a0987f92fa2124bd8fabe6 X-Msg-Generator: CA X-RootMTR: 20230102125442eucas1p1c7c20fbc546613ef07df6b78f373b246 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20230102125442eucas1p1c7c20fbc546613ef07df6b78f373b246 References: <20230102125426.1626-1-d.kozinski@samsung.com> Subject: Re: [FFmpeg-devel] [PATCH v16 5/9] avcodec/evc_encoder: Provided support for EVC encoder X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of Lynne > Sent: wtorek, 7 marca 2023 05:37 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH v16 5/9] avcodec/evc_encoder: Provided > support for EVC encoder > > Jan 2, 2023, 13:54 by d.kozinski@samsung.com: > > > - Added EVC encoder wrapper > > - Changes in project configuration file and libavcodec Makefile > > - Added documentation for xeve wrapper > > > > Signed-off-by: Dawid Kozinski > > --- > > configure | 4 + > > doc/encoders.texi | 69 +++++ > > doc/general_contents.texi | 11 + > > libavcodec/Makefile | 1 + > > libavcodec/allcodecs.c | 1 + > > libavcodec/libxeve.c | 618 ++++++++++++++++++++++++++++++++++++++ > > 6 files changed, 704 insertions(+) > > create mode 100644 libavcodec/libxeve.c > > > > diff --git a/configure b/configure > > index 675dc84f56..392169a4ee 100755 > > --- a/configure > > +++ b/configure > > @@ -291,6 +291,7 @@ External library support: > > --enable-libwebp enable WebP encoding via libwebp [no] > > --enable-libx264 enable H.264 encoding via x264 [no] > > --enable-libx265 enable HEVC encoding via x265 [no] > > + --enable-libxeve enable EVC encoding via libxeve [no] > > --enable-libxavs enable AVS encoding via xavs [no] > > --enable-libxavs2 enable AVS2 encoding via xavs2 [no] > > --enable-libxcb enable X11 grabbing using XCB [autodetect] > > @@ -1862,6 +1863,7 @@ EXTERNAL_LIBRARY_LIST=" > > libvorbis > > libvpx > > libwebp > > + libxeve > > libxml2 > > libzimg > > libzmq > > @@ -3394,6 +3396,7 @@ libx265_encoder_deps="libx265" > > libx265_encoder_select="atsc_a53" > > libxavs_encoder_deps="libxavs" > > libxavs2_encoder_deps="libxavs2" > > +libxeve_encoder_deps="libxeve" > > libxvid_encoder_deps="libxvid" > > libzvbi_teletext_decoder_deps="libzvbi" > > vapoursynth_demuxer_deps="vapoursynth" > > @@ -6718,6 +6721,7 @@ enabled libx265 && require_pkg_config > libx265 x265 x265.h x265_api_get > > require_cpp_condition libx265 x265.h "X265_BUILD >= 89" > > enabled libxavs && require libxavs "stdint.h xavs.h" > xavs_encoder_encode "-lxavs $pthreads_extralibs $libm_extralibs" > > enabled libxavs2 && require_pkg_config libxavs2 "xavs2 >= 1.3.0" > "stdint.h xavs2.h" xavs2_api_get > > +enabled libxeve && require_pkg_config libxeve "xeve >= 0.4.0" "xeve.h" > xeve_encode > > enabled libxvid && require libxvid xvid.h xvid_global -lxvidcore > > enabled libzimg && require_pkg_config libzimg "zimg >= 2.7.0" zimg.h > zimg_get_api_version > > enabled libzmq && require_pkg_config libzmq "libzmq >= 4.2.1" zmq.h > zmq_ctx_new > > diff --git a/doc/encoders.texi b/doc/encoders.texi index > > b8051cda3f..15b8db76c0 100644 > > --- a/doc/encoders.texi > > +++ b/doc/encoders.texi > > @@ -2894,6 +2894,75 @@ ffmpeg -i input -c:v libxavs2 -xavs2-params > > RdoqLevel=0 output.avs2 @end example @end table > > > > +@section libxeve > > + > > +eXtra-fast Essential Video Encoder (XEVE) MPEG-5 EVC encoder wrapper. > > +The xeve-equivalent options or values are listed in parentheses for easy > migration. > > + > > +This encoder requires the presence of the libxeve headers and library > > +during configuration. You need to explicitly configure the build with > > +@option{--enable-libxeve}. > > + > > +@float NOTE > > +Many libxeve encoder options are mapped to FFmpeg global codec > > +options, while unique encoder options are provided through private options. > > +Additionally the xeve-params private options allows one to pass a > > +list of key=value tuples as accepted by the libxeve > @code{parse_xeve_params} function. > > +@end float > > + > > +The xeve project website is at > @url{https://protect2.fireeye.com/v1/url?k=ec383e6a-8db32b4f-ec39b525- > 74fe485cbff6-889ca861fceeab4b&q=1&e=3da9f322-33e7-498a-9a7a- > 3a39fe99e725&u=https%3A%2F%2Fgithub.com%2Fmpeg5%2Fxeve%257D. > > + > > +@subsection Options > > + > > +The following options are supported by the libxeve wrapper. > > +The xeve-equivalent options or values are listed in parentheses for easy > migration. > > + > > +@float NOTE > > +To reduce the duplication of documentation, only the private options > > +and some others requiring special attention are documented here. For > > +the documentation of the undocumented generic options, see > > +@ref{codec-options,,the Codec Options chapter}. > > +@end float > > + > > +@float NOTE > > +To get a more accurate and extensive documentation of the libxeve > > +options, invoke the command @code{xeve_app --help} or consult the libxeve > documentation. > > +@end float > > + > > +@table @option > > +@item b (@emph{bitrate}) > > +Set target video bitrate in bits/s. > > +Note that FFmpeg's b option is expressed in bits/s, while xeve's bitrate is in > kilobits/s. > > + > > +@item bf (@emph{bframes}) > > +Set the maximum number of B frames (1,3,7,15). > > + > > +@item g (@emph{keyint}) > > +Set the GOP size (I-picture period). > > + > > +@item preset (@emph{preset}) > > +Set the xeve preset. > > +Set the encoder preset value to determine encoding speed [fast, > > +medium, slow, placebo] > > + > > +@item tune (@emph{tune}) > > +Set the encoder tune parameter [psnr, zerolatency] > > + > > +@item profile (@emph{profile}) > > +Set the encoder profile [0: baselie; 1: main] > > + > > +@item crf (@emph{crf}) > > +Set the quality for constant quality mode. > > +Constant rate factor <10..49> [default: 32] > > + > > +@item qp (@emph{qp}) > > +Set constant quantization rate control method parameter. > > +Quantization parameter qp <0..51> [default: 32] > > + > > +@item threads (@emph{threads}) > > +Force to use a specific number of threads > > + > > +@end table > > + > > @section libxvid > > > > Xvid MPEG-4 Part 2 encoder wrapper. > > diff --git a/doc/general_contents.texi b/doc/general_contents.texi > > index 8399fcb6b7..bcff3e29b7 100644 > > --- a/doc/general_contents.texi > > +++ b/doc/general_contents.texi > > @@ -343,6 +343,14 @@ libxavs2 is under the GNU Public License Version > > 2 or later details), you must upgrade FFmpeg's license to GPL in order to use it. > > @end float > > > > +@section eXtra-fast Essential Video Encoder (XEVE) > > + > > +FFmpeg can make use of the XEVE library for EVC video encoding. > > + > > +Go to > > +@url{https://protect2.fireeye.com/v1/url?k=828f268a-e30433af-828eadc5 > > +-74fe485cbff6-e6aa3f3bf39eb797&q=1&e=3da9f322-33e7-498a-9a7a- > 3a39fe99e725&u=https%3A%2F%2Fgithub.com%2Fmpeg5%2Fxeve%257D and > follow the instructions for installing the XEVE library. Then pass @code{--enable- > libxeve} to configure to enable it. > > + > > @section ZVBI > > > > ZVBI is a VBI decoding library which can be used by FFmpeg to decode > > DVB @@ -595,6 +603,7 @@ library: > > @item raw DTS @tab X @tab X > > @item raw DTS-HD @tab @tab X > > @item raw E-AC-3 @tab X @tab X > > +@item raw EVC @tab X @tab X > > @item raw FLAC @tab X @tab X > > @item raw GSM @tab @tab X > > @item raw H.261 @tab X @tab X > > @@ -934,6 +943,8 @@ following image formats are supported: > > @item Electronic Arts TQI video @tab @tab X > > @item Escape 124 @tab @tab X > > @item Escape 130 @tab @tab X > > +@item EVC / MPEG-5 Part 1 @tab X @tab X > > + @tab encoding supported through external library libxeve > > @item FFmpeg video codec #1 @tab X @tab X @tab lossless codec > > (fourcc: FFV1) @item Flash Screen Video v1 @tab X @tab X diff > > --git a/libavcodec/Makefile b/libavcodec/Makefile index > > 401d0b7310..8119a4cb6d 100644 > > --- a/libavcodec/Makefile > > +++ b/libavcodec/Makefile > > @@ -1119,6 +1119,7 @@ OBJS-$(CONFIG_LIBX264_ENCODER) += > libx264.o > > OBJS-$(CONFIG_LIBX265_ENCODER) += libx265.o > > OBJS-$(CONFIG_LIBXAVS_ENCODER) += libxavs.o > > OBJS-$(CONFIG_LIBXAVS2_ENCODER) += libxavs2.o > > +OBJS-$(CONFIG_LIBXEVE_ENCODER) += libxeve.o > > OBJS-$(CONFIG_LIBXVID_ENCODER) += libxvid.o > > OBJS-$(CONFIG_LIBZVBI_TELETEXT_DECODER) += libzvbi-teletextdec.o ass.o > > > > diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c index > > d5a6c427e1..514f791fdb 100644 > > --- a/libavcodec/allcodecs.c > > +++ b/libavcodec/allcodecs.c > > @@ -809,6 +809,7 @@ extern LIBX264_CONST FFCodec ff_libx264_encoder; > > #endif extern const FFCodec ff_libx264rgb_encoder; extern FFCodec > > ff_libx265_encoder; > > +extern const FFCodec ff_libxeve_encoder; > > extern const FFCodec ff_libxavs_encoder; extern const FFCodec > > ff_libxavs2_encoder; extern const FFCodec ff_libxvid_encoder; diff > > --git a/libavcodec/libxeve.c b/libavcodec/libxeve.c new file mode > > 100644 index 0000000000..7efdab4716 > > --- /dev/null > > +++ b/libavcodec/libxeve.c > > @@ -0,0 +1,618 @@ > > +/* > > + * libxeve encoder > > + * EVC (MPEG-5 Essential Video Coding) encoding using XEVE MPEG-5 EVC > > +encoder library > > + * > > + * Copyright (C) 2021 Dawid Kozinski > > + * > > + * This file is part of FFmpeg. > > + * > > + * FFmpeg is free software; you can redistribute it and/or > > + * modify it under the terms of the GNU Lesser General Public > > + * License as published by the Free Software Foundation; either > > + * version 2.1 of the License, or (at your option) any later version. > > + * > > + * FFmpeg is distributed in the hope that it will be useful, > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > > + * Lesser General Public License for more details. > > + * > > + * You should have received a copy of the GNU Lesser General Public > > + * License along with FFmpeg; if not, write to the Free Software > > + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA > > +02110-1301 USA */ > > + > > +#include > > +#include > > + > > +#include > > + > > +#include "libavutil/internal.h" > > +#include "libavutil/common.h" > > +#include "libavutil/opt.h" > > +#include "libavutil/pixdesc.h" > > +#include "libavutil/pixfmt.h" > > +#include "libavutil/time.h" > > +#include "libavutil/cpu.h" > > +#include "libavutil/avstring.h" > > + > > +#include "avcodec.h" > > +#include "internal.h" > > +#include "packet_internal.h" > > +#include "codec_internal.h" > > +#include "profiles.h" > > +#include "encode.h" > > + > > +#define MAX_BS_BUF (16*1024*1024) > > + > > +/** > > + * Error codes > > + */ > > +#define XEVE_PARAM_BAD_NAME -100 > > +#define XEVE_PARAM_BAD_VALUE -200 > > + > > +/** > > + * Encoder states > > + * > > + * STATE_ENCODING - the encoder receives and processes input frames > > + * STATE_BUMPING - there are no more input frames, however the > > +encoder still processes previously received data */ typedef enum > > +State { > > + STATE_ENCODING, > > + STATE_BUMPING, > > +} State; > > + > > +/** > > + * The structure stores all the states associated with the instance > > +of Xeve MPEG-5 EVC encoder */ typedef struct XeveContext { > > + const AVClass *class; > > + > > + XEVE id; // XEVE instance identifier > > + XEVE_CDSC cdsc; // coding parameters i.e profile, width & height of > input frame, num of therads, frame rate ... > > + XEVE_BITB bitb; // bitstream buffer (output) > > + XEVE_STAT stat; // encoding status (output) > > + XEVE_IMGB imgb; // image buffer (input) > > + > > + State state; // encoder state (skipping, encoding, bumping) > > + > > + int profile_id; // encoder profile (main, baseline) > > + int preset_id; // preset of xeve ( fast, medium, slow, placebo) > > + int tune_id; // tune of xeve (psnr, zerolatency) > > + > > + // variables for rate control modes > > + int rc_mode; // Rate control mode [ 0(CQP) / 1(ABR) / 2(CRF) ] > > + int qp; // quantization parameter (QP) [0,51] > > + int crf; // constant rate factor (CRF) [10,49] > > + > > + int hash; // embed picture signature (HASH) for conformance > checking in decoding > > + int sei_info; // embed Supplemental enhancement information while > encoding > > + > > + int color_format; // input data color format: currently only > XEVE_CF_YCBCR420 is supported > > + > > + AVDictionary *xeve_params; > > +} XeveContext; > > + > > +/** > > + * Convert FFmpeg pixel format (AVPixelFormat) to XEVE pre-defined > > +color format > > + * > > + * @param[in] av_pix_fmt pixel format (@see > > +https://protect2.fireeye.com/v1/url?k=3ef9f04b-5f72e56e-3ef87b04-74fe > > +485cbff6-ca453fe077dd02b1&q=1&e=3da9f322-33e7-498a-9a7a- > 3a39fe99e725& > > > +u=https%3A%2F%2Fffmpeg.org%2Fdoxygen%2Ftrunk%2Fpixfmt_8h.html%23a > 9a8e > > +335cf3be472042bc9f0cf80cd4c5) > > + * @param[out] xeve_col_fmt XEVE pre-defined color format (@see > > +xeve.h) > > + * > > + * @return 0 on success, negative value on failure */ static int > > +libxeve_color_fmt(enum AVPixelFormat av_pix_fmt, int *xeve_col_fmt) { > > + switch (av_pix_fmt) { > > + case AV_PIX_FMT_YUV420P: > > + *xeve_col_fmt = XEVE_CF_YCBCR420; > > + break; > > + case AV_PIX_FMT_YUV420P10: > > + *xeve_col_fmt = XEVE_CF_YCBCR420; > > + break; > > + default: > > + *xeve_col_fmt = XEVE_CF_UNKNOWN; > > + return AVERROR_INVALIDDATA; > > + } > > + > > + return 0; > > +} > > + > > +/** > > + * Convert FFmpeg pixel format (AVPixelFormat) into XEVE pre-defined > > +color space > > + * > > + * @param[in] px_fmt pixel format (@see > > +https://protect2.fireeye.com/v1/url?k=63b7ae69-023cbb4c-63b62526-74fe > > +485cbff6-99be99e7979f7967&q=1&e=3da9f322-33e7-498a-9a7a- > 3a39fe99e725& > > > +u=https%3A%2F%2Fffmpeg.org%2Fdoxygen%2Ftrunk%2Fpixfmt_8h.html%23a > 9a8e > > +335cf3be472042bc9f0cf80cd4c5) > > + * > > + * @return XEVE pre-defined color space (@see xeve.h) on success, > > +XEVE_CF_UNKNOWN on failure */ static int libxeve_color_space(enum > > +AVPixelFormat av_pix_fmt) { > > + /* color space of input image */ > > + int cs = XEVE_CF_UNKNOWN; > > + > > + switch (av_pix_fmt) { > > + case AV_PIX_FMT_YUV420P: > > + cs = XEVE_CS_YCBCR420; > > + break; > > + case AV_PIX_FMT_YUV420P10: > > +#if AV_HAVE_BIGENDIAN > > + cs = XEVE_CS_SET(XEVE_CF_YCBCR420, 10, 1); #else > > + cs = XEVE_CS_YCBCR420_10LE; > > +#endif > > + > > + break; > > + default: > > + cs = XEVE_CF_UNKNOWN; > > + break; > > + } > > + > > + return cs; > > +} > > + > > +/** > > + * The function returns a pointer to the object of the XEVE_CDSC type. > > + * XEVE_CDSC contains all encoder parameters that should be initialized > before the encoder is used. > > + * > > + * The field values of the XEVE_CDSC structure are populated based on: > > + * - the corresponding field values of the AvCodecConetxt structure, > > + * - the xeve encoder specific option values, > > + * (the full list of options available for xeve encoder is displayed after > executing the command ./ffmpeg --help encoder = libxeve) > > + * > > + * The order of processing input data and populating the XEVE_CDSC > > +structure > > + * 1) first, the fields of the AVCodecContext structure corresponding to the > provided input options are processed, > > + * (i.e -pix_fmt yuv420p -s:v 1920x1080 -r 30 -profile:v 0) > > + * 2) then xeve-specific options added as AVOption to the xeve AVCodec > implementation > > + * (i.e -preset 0) > > + * > > + * Keep in mind that, there are options that can be set in different ways. > > + * In this case, please follow the above-mentioned order of processing. > > + * The most recent assignments overwrite the previous values. > > + * > > + * @param[in] avctx codec context (AVCodecContext) > > + * @param[out] cdsc contains all Xeve MPEG-5 EVC encoder encoder > > +parameters that should be initialized before the encoder is use > > + * > > + * @return 0 on success, negative error code on failure */ static > > +int get_conf(AVCodecContext *avctx, XEVE_CDSC *cdsc) { > > + XeveContext *xectx = NULL; > > + int ret; > > + > > + xectx = avctx->priv_data; > > + > > + /* initialize xeve_param struct with default values */ > > + ret = xeve_param_default(&cdsc->param); > > + if (XEVE_FAILED(ret)) { > > + av_log(avctx, AV_LOG_ERROR, "Cannot set_default parameter\n"); > > + return AVERROR_EXTERNAL; > > + } > > + > > + /* read options from AVCodecContext */ > > + if (avctx->width > 0) > > + cdsc->param.w = avctx->width; > > + > > + if (avctx->height > 0) > > + cdsc->param.h = avctx->height; > > + > > + if (avctx->framerate.num > 0) { > > + // fps can be float number, but xeve API doesn't support it > > + cdsc->param.fps = (int)(((float)avctx->framerate.num / avctx- > >framerate.den) + 0.5); > > + } > > > > cdsc->params.fps = lrintf(av_q2d(avctx->framerate)); > > > > + if (avctx->gop_size >= 0) // GOP size (key-frame interval, I-picture period) > > + cdsc->param.keyint = avctx->gop_size; // 0: only one I-frame > > + at the first time; 1: every frame is coded in I-frame > > > > Why the check? It's never going to be negative. > > > > + if (avctx->max_b_frames == 0 || avctx->max_b_frames == 1 || avctx- > >max_b_frames == 3 || > > + avctx->max_b_frames == 7 || avctx->max_b_frames == 15) // number > of b-frames > > + cdsc->param.bframes = avctx->max_b_frames; > > + else { > > + av_log(avctx, AV_LOG_ERROR, "Incorrect value for maximum number of > B frames: (%d) \n" > > + "Acceptable values for bf option (maximum number of B frames) are > 0,1,3,7 or 15\n", avctx->max_b_frames); > > + return AVERROR_INVALIDDATA; > > + } > > + > > + if (avctx->level >= 0) > > + cdsc->param.level_idc = avctx->level; > > > > Same here. > > > > + > > + if (avctx->rc_buffer_size) // VBV buf size > > + cdsc->param.vbv_bufsize = (int)(avctx->rc_buffer_size / > > + 1000); > > + > > + cdsc->param.rc_type = xectx->rc_mode; > > + > > + if (xectx->rc_mode == XEVE_RC_CQP) { > > + cdsc->param.qp = xectx->qp; > > + } else if (xectx->rc_mode == XEVE_RC_ABR) { > > + if (avctx->bit_rate / 1000 > INT_MAX || avctx->rc_max_rate / 1000 > > INT_MAX) { > > + av_log(avctx, AV_LOG_ERROR, "Not supported bitrate bit_rate and > rc_max_rate > %d000\n", INT_MAX); > > + return AVERROR_INVALIDDATA; > > + } > > + cdsc->param.bitrate = (int)(avctx->bit_rate / 1000); > > + } else if (xectx->rc_mode == XEVE_RC_CRF) { > > + cdsc->param.crf = xectx->crf; > > + } else { > > + av_log(avctx, AV_LOG_ERROR, "Not supported rate control type: %d\n", > xectx->rc_mode); > > + return AVERROR_INVALIDDATA; > > + } > > + > > + if (avctx->thread_count <= 0) { > > + int cpu_count = av_cpu_count(); > > + cdsc->param.threads = (cpu_count < XEVE_MAX_THREADS) ? cpu_count : > XEVE_MAX_THREADS; > > + } else if (avctx->thread_count > XEVE_MAX_THREADS) > > + cdsc->param.threads = XEVE_MAX_THREADS; > > + else > > + cdsc->param.threads = avctx->thread_count; > > + > > + > > + libxeve_color_fmt(avctx->pix_fmt, &xectx->color_format); > > + > > + cdsc->param.cs = XEVE_CS_SET(xectx->color_format, > > + cdsc->param.codec_bit_depth, AV_HAVE_BIGENDIAN); > > + > > + cdsc->max_bs_buf_size = MAX_BS_BUF; > > + > > + ret = xeve_param_ppt(&cdsc->param, xectx->profile_id, xectx->preset_id, > xectx->tune_id); > > + if (XEVE_FAILED(ret)) { > > + av_log(avctx, AV_LOG_ERROR, "Cannot set profile(%d), preset(%d), > tune(%d)\n", xectx->profile_id, xectx->preset_id, xectx->tune_id); > > + return AVERROR_EXTERNAL; > > + } > > + > > + return 0; > > +} > > + > > +/** > > + * Set XEVE_CFG_SET_USE_PIC_SIGNATURE for encoder > > + * > > + * @param[in] logger context > > + * @param[in] id XEVE encodec instance identifier > > + * @param[in] ctx the structure stores all the states associated with > > +the instance of Xeve MPEG-5 EVC encoder > > + * > > + * @return 0 on success, negative error code on failure */ static > > +int set_extra_config(AVCodecContext *avctx, XEVE id, XeveContext > > +*ctx) { > > + int ret, size; > > + size = 4; > > + > > + // embed SEI messages identifying encoder parameters and command line > arguments > > + // - 0: off\n" > > + // - 1: emit sei info" > > + // > > + // SEI - Supplemental enhancement information contains information > > + // that is not necessary to decode the samples of coded pictures from VCL > NAL units. > > + // Some SEI message information is required to check bitstream > conformance > > + // and for output timing decoder conformance. > > + // @see ISO_IEC_23094-1_2020 7.4.3.5 > > + // @see ISO_IEC_23094-1_2020 Annex D > > + ret = xeve_config(id, XEVE_CFG_SET_SEI_CMD, &ctx->sei_info, &size); // > sei_cmd_info > > + if (XEVE_FAILED(ret)) { > > + av_log(avctx, AV_LOG_ERROR, "Failed to set config for sei command > info messages\n"); > > + return AVERROR_EXTERNAL; > > + } > > + > > + ret = xeve_config(id, XEVE_CFG_SET_USE_PIC_SIGNATURE, &ctx->hash, > &size); > > + if (XEVE_FAILED(ret)) { > > + av_log(avctx, AV_LOG_ERROR, "Failed to set config for picture > signature\n"); > > + return AVERROR_EXTERNAL; > > + } > > + > > + return 0; > > +} > > > > You should handle avctx->flags & AV_CODEC_FLAG_GLOBAL_HEADER. > If that flag is set, you have to set avctx->extradata to (usually, in case of > h2645) at least the start SPS unit, or whatever the standard is for containers. Lynne. Currently, handling the case when the condition avctx->flags & AV_CODEC_FLAG_GLOBAL_HEADER is met will be difficult to achieve in our decoder implementation without expanding the API of xeve library. To make it feasible, we will probably need to add a new function to the xeve library, namely "int XEVE_EXPORT xeve_encode_header(...)", similar to the one that HEVC has (int x265_encoder_headers()). Then, when the avctx->flags & AV_CODEC_FLAG_GLOBAL_HEADER condition is met we'll use that new function to get the SPS and PPS headers and set avctx->extradata to include them. Currently, our implementation allows us to force the encoder to add SPS and PPS before each keyframe using the --closed_gop option, as well as to add SPS and PPS only before the first keyframe (the same effect as using the --repeat-headers option in the HEVC encoder). However, it seems we don't have a convenient API that will let us get only non-VCL NAL units i.e SPS and PPS headers. Currently, we have only the XEVE_EXPORT xeve_encode(...) function, which returns a VCL NAL units or a complete access unit containing the SPS, PPS, and VCL NAL unit. Extending the API is already on the to-do list. We will definitely handle the case avctx->flags & AV_CODEC_FLAG_GLOBAL_HEADER as soon as we extend the libxeve API. However, until then we'd like to generate a new patchset without it. > > + > > +/** > > + * @brief Switch encoder to bumping mode > > + * > > + * @param id XEVE encodec instance identifier > > + * @return 0 on success, negative error code on failure */ static > > +int setup_bumping(XEVE id) { > > + int val = 1; > > + int size = sizeof(int); > > + if (XEVE_FAILED(xeve_config(id, XEVE_CFG_SET_FORCE_OUT, (void > *)(&val), &size))) > > + return AVERROR_EXTERNAL; > > + > > + return 0; > > +} > > + > > +/** > > + * @brief Initialize eXtra-fast Essential Video Encoder codec > > + * Create an encoder instance and allocate all the needed resources > > + * > > + * @param avctx codec context > > + * @return 0 on success, negative error code on failure */ static > > +av_cold int libxeve_init(AVCodecContext *avctx) { > > + XeveContext *xectx = avctx->priv_data; > > + unsigned char *bs_buf = NULL; > > + int i; > > + int shift_h = 0; > > + int shift_v = 0; > > + int width_chroma = 0; > > + int height_chroma = 0; > > + XEVE_IMGB *imgb = NULL; > > + int ret = 0; > > + > > + XEVE_CDSC *cdsc = &(xectx->cdsc); > > + > > + /* allocate bitstream buffer */ > > + bs_buf = av_malloc(MAX_BS_BUF); > > + if (bs_buf == NULL) { > > + av_log(avctx, AV_LOG_ERROR, "Cannot allocate bitstream buffer\n"); > > + return AVERROR(ENOMEM); > > + } > > + xectx->bitb.addr = bs_buf; > > + xectx->bitb.bsize = MAX_BS_BUF; > > + > > + /* read configurations and set values for created descriptor (XEVE_CDSC) > */ > > + if ((ret = get_conf(avctx, cdsc)) != 0) { > > + av_log(avctx, AV_LOG_ERROR, "Cannot get configuration\n"); > > + return AVERROR(EINVAL); > > + } > > + > > + if ((ret = xeve_param_check(&cdsc->param)) != 0) { > > + av_log(avctx, AV_LOG_ERROR, "Invalid configuration\n"); > > + return AVERROR(EINVAL); > > + } > > + > > + { > > + AVDictionaryEntry *en = NULL; > > + while (en = av_dict_get(xectx->xeve_params, "", en, > AV_DICT_IGNORE_SUFFIX)) { > > + if ((ret = xeve_param_parse(&cdsc->param, en->key, en->value)) < 0) { > > + av_log(avctx, AV_LOG_WARNING, > > + "Error parsing option '%s = %s'.\n", > > + en->key, en->value); > > + } > > + } > > + } > > + > > + /* create encoder */ > > + xectx->id = xeve_create(cdsc, NULL); > > + if (xectx->id == NULL) { > > + av_log(avctx, AV_LOG_ERROR, "Cannot create XEVE encoder\n"); > > + return AVERROR_EXTERNAL; > > + } > > + > > + if ((ret = set_extra_config(avctx, xectx->id, xectx)) != 0) { > > + av_log(avctx, AV_LOG_ERROR, "Cannot set extra configuration\n"); > > + return AVERROR(EINVAL); > > + } > > + > > + if ((ret = av_pix_fmt_get_chroma_sub_sample(avctx->pix_fmt, &shift_h, > &shift_v)) != 0) { > > + av_log(avctx, AV_LOG_ERROR, "Failed to get chroma shift\n"); > > + return AVERROR(EINVAL); > > + } > > + > > + // Chroma subsampling > > + // > > + // YUV format explanation > > + // shift_h == 1 && shift_v == 1 : YUV420 > > + // shift_h == 1 && shift_v == 0 : YUV422 > > + // shift_h == 0 && shift_v == 0 : YUV444 > > + // > > + width_chroma = AV_CEIL_RSHIFT(avctx->width, shift_h); > > + height_chroma = AV_CEIL_RSHIFT(avctx->height, shift_v); > > + > > + /* set default values for input image buffer */ > > + imgb = &xectx->imgb; > > + imgb->cs = libxeve_color_space(avctx->pix_fmt); > > + imgb->np = 3; /* only for yuv420p, yuv420ple */ > > + > > + for (i = 0; i < imgb->np; i++) > > + imgb->x[i] = imgb->y[i] = 0; > > + > > + imgb->w[0] = imgb->aw[0] = avctx->width; // width luma > > + imgb->w[1] = imgb->w[2] = imgb->aw[1] = imgb->aw[2] = width_chroma; > > + imgb->h[0] = imgb->ah[0] = avctx->height; // height luma > > + imgb->h[1] = imgb->h[2] = imgb->ah[1] = imgb->ah[2] = > > + height_chroma; > > + > > + xectx->state = STATE_ENCODING; > > + > > + return 0; > > +} > > + > > +/** > > + * Encode raw data frame into EVC packet > > + * > > + * @param[in] avctx codec context > > + * @param[out] avpkt output AVPacket containing encoded data > > + * @param[in] frame AVFrame containing the raw data to be encoded > > + * @param[out] got_packet encoder sets to 0 or 1 to indicate that a > > + * non-empty packet was returned in pkt > > + * > > + * @return 0 on success, negative error code on failure > > + */ > > +static int libxeve_encode(AVCodecContext *avctx, AVPacket *avpkt, > > + const AVFrame *frame, int *got_packet) { > > + XeveContext *xectx = avctx->priv_data; > > + int ret = -1; > > + > > + // No more input frames are available but encoder still can have some data > in its internal buffer to process > > + // and some frames to dump. > > + if (xectx->state == STATE_ENCODING && frame == NULL) { > > + if (setup_bumping(xectx->id) == 0) > > + xectx->state = STATE_BUMPING; // Entering bumping process > > + else { > > + av_log(avctx, AV_LOG_ERROR, "Failed to setup bumping\n"); > > + return 0; > > + } > > + } > > + > > + if (xectx->state == STATE_ENCODING) { > > + int i; > > + XEVE_IMGB *imgb = NULL; > > + > > + imgb = &xectx->imgb; > > + > > + for (i = 0; i < imgb->np; i++) { > > + imgb->a[i] = frame->data[i]; > > + imgb->s[i] = frame->linesize[i]; > > + } > > + > > + imgb->ts[XEVE_TS_PTS] = frame->pts; > > + imgb->ts[XEVE_TS_DTS] = 0; > > > > Why is DTS hardcoded to 0? > > Like with the other patchset, the excessive doxy is in the way. > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://protect2.fireeye.com/v1/url?k=2190ee36-401bfb13-21916579- > 74fe485cbff6-0c2c32fdf6e083d5&q=1&e=3da9f322-33e7-498a-9a7a- > 3a39fe99e725&u=https%3A%2F%2Fffmpeg.org%2Fmailman%2Flistinfo%2Fffmp > eg-devel > > To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org > with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".