* [FFmpeg-devel] [PATCH v1] avcodec/hevcpred_template: Removed unreachable code
[not found] <CGME20230929083224eucas1p2b7359a39687cb97fd1d51f6583371e77@eucas1p2.samsung.com>
@ 2023-09-29 8:32 ` Dawid Kozinski
2023-10-02 13:49 ` Ronald S. Bultje
0 siblings, 1 reply; 4+ messages in thread
From: Dawid Kozinski @ 2023-09-29 8:32 UTC (permalink / raw)
To: d.frankiewic, ffmpeg-devel; +Cc: Dawid Kozinski
Signed-off-by: Dawid Kozinski <d.kozinski@samsung.com>
---
libavcodec/hevcpred_template.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/libavcodec/hevcpred_template.c b/libavcodec/hevcpred_template.c
index 16d1c7f35f..46bd806523 100644
--- a/libavcodec/hevcpred_template.c
+++ b/libavcodec/hevcpred_template.c
@@ -213,13 +213,10 @@ do { \
j = 0;
while (j < size_max_x && !IS_INTRA(j, -1))
j++;
- if (j > 0)
- if (cand_up_left) {
- EXTEND_LEFT_CIP(top, j, j + 1);
- } else {
- EXTEND_LEFT_CIP(top, j, j);
- top[-1] = top[0];
- }
+ if (j > 0) {
+ EXTEND_LEFT_CIP(top, j, j);
+ top[-1] = top[0];
+ }
left[-1] = top[-1];
}
left[-1] = top[-1];
--
2.25.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [FFmpeg-devel] [PATCH v1] avcodec/hevcpred_template: Removed unreachable code
2023-09-29 8:32 ` [FFmpeg-devel] [PATCH v1] avcodec/hevcpred_template: Removed unreachable code Dawid Kozinski
@ 2023-10-02 13:49 ` Ronald S. Bultje
2023-10-03 8:15 ` Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics
0 siblings, 1 reply; 4+ messages in thread
From: Ronald S. Bultje @ 2023-10-02 13:49 UTC (permalink / raw)
To: FFmpeg development discussions and patches; +Cc: Dawid Kozinski, d.frankiewic
Hi,
On Fri, Sep 29, 2023 at 4:32 AM Dawid Kozinski <d.kozinski@samsung.com>
wrote:
> Signed-off-by: Dawid Kozinski <d.kozinski@samsung.com>
> ---
> libavcodec/hevcpred_template.c | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/libavcodec/hevcpred_template.c
> b/libavcodec/hevcpred_template.c
> index 16d1c7f35f..46bd806523 100644
> --- a/libavcodec/hevcpred_template.c
> +++ b/libavcodec/hevcpred_template.c
> @@ -213,13 +213,10 @@ do { \
> j = 0;
> while (j < size_max_x && !IS_INTRA(j, -1))
> j++;
> - if (j > 0)
> - if (cand_up_left) {
> - EXTEND_LEFT_CIP(top, j, j + 1);
> - } else {
> - EXTEND_LEFT_CIP(top, j, j);
> - top[-1] = top[0];
> - }
> + if (j > 0) {
> + EXTEND_LEFT_CIP(top, j, j);
> + top[-1] = top[0];
> + }
> left[-1] = top[-1];
> }
> left[-1] = top[-1];
> --
> 2.25.1
>
LGTM.
Can you merge yourself, or do you need me to merge for you?
Ronald
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [FFmpeg-devel] [PATCH v1] avcodec/hevcpred_template: Removed unreachable code
2023-10-02 13:49 ` Ronald S. Bultje
@ 2023-10-03 8:15 ` Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics
2023-10-03 12:45 ` Ronald S. Bultje
0 siblings, 1 reply; 4+ messages in thread
From: Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics @ 2023-10-03 8:15 UTC (permalink / raw)
To: 'FFmpeg development discussions and patches'; +Cc: d.frankiewic
> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Ronald
> S. Bultje
> Sent: poniedziałek, 2 października 2023 15:49
> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
> Cc: Dawid Kozinski <d.kozinski@samsung.com>; d.frankiewic@samsung.com
> Subject: Re: [FFmpeg-devel] [PATCH v1] avcodec/hevcpred_template: Removed
> unreachable code
>
> Hi,
>
> On Fri, Sep 29, 2023 at 4:32 AM Dawid Kozinski <d.kozinski@samsung.com>
> wrote:
>
> > Signed-off-by: Dawid Kozinski <d.kozinski@samsung.com>
> > ---
> > libavcodec/hevcpred_template.c | 11 ++++-------
> > 1 file changed, 4 insertions(+), 7 deletions(-)
> >
> > diff --git a/libavcodec/hevcpred_template.c
> > b/libavcodec/hevcpred_template.c index 16d1c7f35f..46bd806523 100644
> > --- a/libavcodec/hevcpred_template.c
> > +++ b/libavcodec/hevcpred_template.c
> > @@ -213,13 +213,10 @@ do { \
> > j = 0;
> > while (j < size_max_x && !IS_INTRA(j, -1))
> > j++;
> > - if (j > 0)
> > - if (cand_up_left) {
> > - EXTEND_LEFT_CIP(top, j, j + 1);
> > - } else {
> > - EXTEND_LEFT_CIP(top, j, j);
> > - top[-1] = top[0];
> > - }
> > + if (j > 0) {
> > + EXTEND_LEFT_CIP(top, j, j);
> > + top[-1] = top[0];
> > + }
> > left[-1] = top[-1];
> > }
> > left[-1] = top[-1];
> > --
> > 2.25.1
> >
>
> LGTM.
>
> Can you merge yourself, or do you need me to merge for you?
Thank you for review.
If you can, merge it, please.
Dawid
>
> Ronald
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://protect2.fireeye.com/v1/url?k=d33121fa-8cad08d0-d330aab5-
> 000babe598f7-032ae0d1a82bd0a7&q=1&e=1c6b6f88-d7aa-4952-9930-
> 83712a0c6be3&u=https%3A%2F%2Fffmpeg.org%2Fmailman%2Flistinfo%2Fffmp
> eg-devel
>
> To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org
> with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [FFmpeg-devel] [PATCH v1] avcodec/hevcpred_template: Removed unreachable code
2023-10-03 8:15 ` Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics
@ 2023-10-03 12:45 ` Ronald S. Bultje
0 siblings, 0 replies; 4+ messages in thread
From: Ronald S. Bultje @ 2023-10-03 12:45 UTC (permalink / raw)
To: FFmpeg development discussions and patches; +Cc: d.frankiewic
Hi,
On Tue, Oct 3, 2023 at 4:15 AM Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff
Engineer/Samsung Electronics <d.kozinski@samsung.com> wrote:
>
>
>
> > -----Original Message-----
> > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Ronald
> > S. Bultje
> > Sent: poniedziałek, 2 października 2023 15:49
> > To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
> > Cc: Dawid Kozinski <d.kozinski@samsung.com>; d.frankiewic@samsung.com
> > Subject: Re: [FFmpeg-devel] [PATCH v1] avcodec/hevcpred_template: Removed
> > unreachable code
> >
> > Hi,
> >
> > On Fri, Sep 29, 2023 at 4:32 AM Dawid Kozinski <d.kozinski@samsung.com>
> > wrote:
> >
> > > Signed-off-by: Dawid Kozinski <d.kozinski@samsung.com>
> > > ---
> > > libavcodec/hevcpred_template.c | 11 ++++-------
> > > 1 file changed, 4 insertions(+), 7 deletions(-)
> > >
> > > diff --git a/libavcodec/hevcpred_template.c
> > > b/libavcodec/hevcpred_template.c index 16d1c7f35f..46bd806523 100644
> > > --- a/libavcodec/hevcpred_template.c
> > > +++ b/libavcodec/hevcpred_template.c
> > > @@ -213,13 +213,10 @@ do { \
> > > j = 0;
> > > while (j < size_max_x && !IS_INTRA(j, -1))
> > > j++;
> > > - if (j > 0)
> > > - if (cand_up_left) {
> > > - EXTEND_LEFT_CIP(top, j, j + 1);
> > > - } else {
> > > - EXTEND_LEFT_CIP(top, j, j);
> > > - top[-1] = top[0];
> > > - }
> > > + if (j > 0) {
> > > + EXTEND_LEFT_CIP(top, j, j);
> > > + top[-1] = top[0];
> > > + }
> > > left[-1] = top[-1];
> > > }
> > > left[-1] = top[-1];
> > > --
> > > 2.25.1
> > >
> >
> > LGTM.
> >
> > Can you merge yourself, or do you need me to merge for you?
>
> Thank you for review.
> If you can, merge it, please.
>
Done.
Ronald
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-10-03 12:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20230929083224eucas1p2b7359a39687cb97fd1d51f6583371e77@eucas1p2.samsung.com>
2023-09-29 8:32 ` [FFmpeg-devel] [PATCH v1] avcodec/hevcpred_template: Removed unreachable code Dawid Kozinski
2023-10-02 13:49 ` Ronald S. Bultje
2023-10-03 8:15 ` Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics
2023-10-03 12:45 ` Ronald S. Bultje
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git