From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2775247DC4 for ; Fri, 27 Oct 2023 08:16:01 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A0B2A68CC26; Fri, 27 Oct 2023 11:15:59 +0300 (EEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4BA0368CBCC for ; Fri, 27 Oct 2023 11:15:51 +0300 (EEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20231027081550euoutp01a12ec4e1f63d1afcf425d65410c25517~R6NhxMXY40612406124euoutp01E for ; Fri, 27 Oct 2023 08:15:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20231027081550euoutp01a12ec4e1f63d1afcf425d65410c25517~R6NhxMXY40612406124euoutp01E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1698394550; bh=ei93xrHM7htnxZ+hms4ZjiQa4AMx5OyVM80pICSEqKA=; h=From:To:In-Reply-To:Subject:Date:References:From; b=tmZXgYq3HW2inH+qtk77l1s9gPHXbxfFibvi4F/aXwKu08ZhicKDskDcgwTMHW2Wr cCssL/6zFyGMdpDJB9AWsv5owqxPf7DsWAnz3D9wojzKMhhexq5BRyBZi7ou+itXqy BnlqUU8azlfN5jYXk+LdRheQopFZ9myj7cutHzEY= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20231027081550eucas1p24f36956098e9909196e6bb710d01da6d~R6NhofW151140011400eucas1p26 for ; Fri, 27 Oct 2023 08:15:50 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 01.E7.42423.6B17B356; Fri, 27 Oct 2023 09:15:50 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20231027081550eucas1p1997b32d4a6273df9b31afddeebf6d33b~R6NhS-e6l1785217852eucas1p1o for ; Fri, 27 Oct 2023 08:15:50 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20231027081550eusmtrp1f766d2df1979506c2d0144ee1d722c73~R6NhSfPb70180401804eusmtrp1Y for ; Fri, 27 Oct 2023 08:15:50 +0000 (GMT) X-AuditID: cbfec7f2-a3bff7000002a5b7-e1-653b71b6ee3f Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id B9.BC.25043.6B17B356; Fri, 27 Oct 2023 09:15:50 +0100 (BST) Received: from AMDN5164 (unknown [106.210.132.171]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20231027081549eusmtip2c12998ef0357081498cda56378b5ff89~R6Ng-pa6A2734527345eusmtip2e for ; Fri, 27 Oct 2023 08:15:49 +0000 (GMT) From: "Dawid Kozinski/Multimedia \(PLT\) /SRPOL/Staff Engineer/Samsung Electronics" To: "'FFmpeg development discussions and patches'" In-Reply-To: <20231004225921.30287-3-michael@niedermayer.cc> Date: Fri, 27 Oct 2023 10:15:49 +0200 Message-ID: <00e301da08ad$cbaf7910$630e6b30$@samsung.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQLBd/YEamG8pkZ17K4RTXJx2KX1+AHnKs6TAWp4uqyuc94a8A== Content-Language: pl X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrNIsWRmVeSWpSXmKPExsWy7djPc7rbCq1TDVbfU7H49ukMswOjx59F m1kCGKO4bFJSczLLUov07RK4Mva9WspWsFitYsPtb2wNjJNVuxg5OSQETCQW/n/J2sXIxSEk sIJRYsvr9VDOJCaJueeeMUE4E5kkFmzYywTT8m3XTWaIxHJGiUVXV7BBOG1MEveftbKBVLEJ 5Ek8/ryWGcQWEfCR6F4PMpeTg1PARuLS2zawuLBAiMSjf7vZQWwWAVWJuQsvgcV5BSwljt19 CWULSpyc+YQFxGYW0JN4dmoWlK0tsWzha2aIixQkfj5dxgqxy0mioXEhI0SNiMSNRy2MIMdJ CPRySPw8CPOCi8T2T4ehbGGJV8e3sEPYMhKnJ/cALeAAsoslDvU7QJg1Eod+pENUWEu8bTzO CGE7Smzue8QMUcInceOtIMRWPolJ26ZDhXklOtqEIEwVib5OMYhGKYmny+YwT2BUmoXkxVlI XpyF5MVZSF5ZwMiyilE8tbQ4Nz212DAvtVyvODG3uDQvXS85P3cTIzA9nP53/NMOxrmvPuod YmTiYDzEKMHBrCTCG+ljkSrEm5JYWZValB9fVJqTWnyIUZqDRUmcVzVFPlVIID2xJDU7NbUg tQgmy8TBKdXANNus7E3PfslgBs3XOr9SzPW9FWdNn7zIbDGPbPr/dBYh5mwOGTn2hH0rt6q9 Dv9qME1GiC1vXf+VDBYr3elPNp+8rREzv+6v1pctHOlldXHbuc/x9WnwVM2s//6zucWCa6a2 i2lHpe0suzkBFaqZrHZH5py8JddnOrm1I+70X73aitU+i+5aOZ7ZxfnuUfvTsL+TWtkYXZr4 b/zvZPq5aongDMPJzBYZTcJZBzhyNuu63RY52vG/pe/2igt3W0xfFgg239vz7kcs35z/P4+9 FJ90LL/HV936bOujMqe2d1e2P2i3Fq46MNeXN3P+rVcTRR81LeU8eYV316dp0XJvi8Qn6ou2 TFVc+9RypUK4EktxRqKhFnNRcSIAk0Qu6X4DAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpgkeLIzCtJLcpLzFFi42I5/e/4Pd1thdapBi8O8Vh8+3SG2YHR48+i zSwBjFF6NkX5pSWpChn5xSW2StGGFkZ6hpYWekYmlnqGxuaxVkamSvp2NimpOZllqUX6dgl6 GW0tWxkL3opXHNrwkbGBcaJgFyMnh4SAicS3XTeZuxi5OIQEljJKrHi/gwUiISWxdOkiRghb WOLPtS42iKIWJom17+6wgSTYBHIk1s6eyARiiwj4SHSvX88KUbSXUWLHrBnMIAlOARuJS2/b wGxhgSCJCyv3gE1lEVCVmLvwElicV8BS4tjdl1C2oMTJmU/ArmAWMJBYsvAXE4StLbFs4Wtm iIsUJH4+XcYKsdhJoqFxISNEjYjEjUctjBMYhWYhGTULyahZSEbNQtKygJFlFaNIamlxbnpu sZFecWJucWleul5yfu4mRmBUbDv2c8sOxpWvPuodYmTiYDzEKMHBrCTCG+ljkSrEm5JYWZVa lB9fVJqTWnyI0RTot4nMUqLJ+cC4zCuJNzQzMDU0MbM0MLU0M1YS5/Us6EgUEkhPLEnNTk0t SC2C6WPi4JRqYJp6TVra2OnWyh0NM7aI/dmkcuBli+vuiu87lrzhm7hgZUrwmoJ/wp+3XLsy 50RzTFGEr7HnW1kLBofEU8v/RsTcvjYvu8cnaF//kgf6gmfe+PHNyqtl/2EaFhI88+/pHUZv vIRE2rdNizqROGet6EU78yup2Z2fDE7Z7/6tVu/MFrBmg97MFNmZ0jP45k6VW5CVVtfgzzfn 4zTGIFXhlPeNWpPlfhte2f29TOq9lnOH0Ese9bq0HT2p2sb+7J/eh0+ZdZkj8urM+0Yn2qdJ aHvNm5QUJrrZKbAn6MfzrxdYttru+2oV9EcqjPPuK1HTjCMrGcK4byQV9FxadtI4mPW6He8q K61pTqEpjD4pAkosxRmJhlrMRcWJAMRA+AoTAwAA X-CMS-MailID: 20231027081550eucas1p1997b32d4a6273df9b31afddeebf6d33b X-Msg-Generator: CA X-RootMTR: 20231004225955eucas1p1eba33062cb3ce48b597719b830bf2b75 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20231004225955eucas1p1eba33062cb3ce48b597719b830bf2b75 References: <20231004225921.30287-1-michael@niedermayer.cc> <20231004225921.30287-3-michael@niedermayer.cc> Subject: Re: [FFmpeg-devel] [PATCH 3/4] avcodec/evc_parse: remove pow() and log2() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of > Michael Niedermayer > Sent: czwartek, 5 pa=BCdziernika 2023 00:59 > To: FFmpeg development discussions and patches > Subject: [FFmpeg-devel] [PATCH 3/4] avcodec/evc_parse: remove pow() and > log2() > = > The use of float based functions is both unneeded and wrong due to > unpredictable rounding > = > Signed-off-by: Michael Niedermayer > --- > libavcodec/evc_parse.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > = > diff --git a/libavcodec/evc_parse.c b/libavcodec/evc_parse.c index > 5ab33166cf3..20b6849041a 100644 > --- a/libavcodec/evc_parse.c > +++ b/libavcodec/evc_parse.c > @@ -176,7 +176,8 @@ int ff_evc_derive_poc(const EVCParamSets *ps, const > EVCParserSliceHeader *sh, > poc->PicOrderCntVal =3D 0; > poc->DocOffset =3D -1; > } else { > - int SubGopLength =3D (int)pow(2.0, sps->log2_sub_gop_length); > + int SubGopLength =3D 1 << sps->log2_sub_gop_length; > + > if (tid =3D=3D 0) { > poc->PicOrderCntVal =3D poc->prevPicOrderCntVal + SubGopLength; > poc->DocOffset =3D 0; > @@ -191,15 +192,16 @@ int ff_evc_derive_poc(const EVCParamSets *ps, const > EVCParserSliceHeader *sh, > poc->prevPicOrderCntVal +=3D SubGopLength; > ExpectedTemporalId =3D 0; > } else > - ExpectedTemporalId =3D 1 + (int)log2(poc->DocOffset); > + ExpectedTemporalId =3D 1 + av_log2(poc->DocOffset); > + > while (tid !=3D ExpectedTemporalId) { > poc->DocOffset =3D (poc->DocOffset + 1) % SubGopLeng= th; > if (poc->DocOffset =3D=3D 0) > ExpectedTemporalId =3D 0; > else > - ExpectedTemporalId =3D 1 + (int)log2(poc->DocOffset); > + ExpectedTemporalId =3D 1 + > + av_log2(poc->DocOffset); > } > - PocOffset =3D (int)(SubGopLength * ((2.0 * poc->DocOffse= t + 1) / > (int)pow(2.0, tid) - 2)); > + PocOffset =3D (int)(SubGopLength * ((2.0 * poc->DocOffset > + + 1) / (1 << tid) - 2)); > poc->PicOrderCntVal =3D poc->prevPicOrderCntVal + PocOffset; > } > } > -- > 2.17.1 > = Reviewed. Looks good. It can be merged. > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://protect2.fireeye.com/v1/url?k=3Db3e7a91c-d29c0395-b3e62253- > 74fe48600034-766db145edef46dd&q=3D1&e=3D130227c8-f092-4124-aef7- > bcb9009528da&u=3Dhttps%3A%2F%2Fffmpeg.org%2Fmailman%2Flistinfo%2Fffmp > eg-devel > = > To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org > with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".