From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0618D481D2 for ; Sun, 12 Nov 2023 14:57:45 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CF33168C805; Sun, 12 Nov 2023 16:57:41 +0200 (EET) Received: from mout-p-102.mailbox.org (mout-p-102.mailbox.org [80.241.56.152]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id AAD9D68CA9B for ; Sun, 12 Nov 2023 16:57:34 +0200 (EET) Received: from smtp2.mailbox.org (smtp2.mailbox.org [10.196.197.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4SSwdl6XJdz9slT for ; Sun, 12 Nov 2023 15:57:31 +0100 (CET) Message-ID: <00ca1ae5-8673-4bdf-8a73-4d4b634ad468@gyani.pro> Date: Sun, 12 Nov 2023 20:27:27 +0530 MIME-Version: 1.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20231108045534.1529-1-ffmpeg@gyani.pro> From: Gyan Doshi In-Reply-To: <20231108045534.1529-1-ffmpeg@gyani.pro> Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libsvtav1: add version guard for external param X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2023-11-08 10:25 am, Gyan Doshi wrote: > Setting of external param 'force_key_frames' was added in 7bcc1b4eb8. > It is available since v1.1.0 but ffmpeg allows linking against v0.9.0. Plan to push tomorrow, barring objections. Regards, Gyan > --- > libavcodec/libsvtav1.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c > index 8d2c7f3be4..862192945b 100644 > --- a/libavcodec/libsvtav1.c > +++ b/libavcodec/libsvtav1.c > @@ -250,6 +250,7 @@ static int config_enc_params(EbSvtAv1EncConfiguration *param, > if (avctx->gop_size > 1) > param->intra_period_length = avctx->gop_size - 1; > > +#if SVT_AV1_CHECK_VERSION(1, 1, 0) > // In order for SVT-AV1 to force keyframes by setting pic_type to > // EB_AV1_KEY_PICTURE on any frame, force_key_frames has to be set. Note > // that this does not force all frames to be keyframes (it only forces a > @@ -260,6 +261,7 @@ static int config_enc_params(EbSvtAv1EncConfiguration *param, > // to be updated to set force_key_frames accordingly. > if (avctx->gop_size == 1) > param->force_key_frames = 1; > +#endif > > if (avctx->framerate.num > 0 && avctx->framerate.den > 0) { > param->frame_rate_numerator = avctx->framerate.num; _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".