From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6E1F04B7C7 for ; Thu, 13 Jun 2024 13:50:02 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4754F68D9F7; Thu, 13 Jun 2024 16:50:00 +0300 (EEST) Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E61C868D8D3 for ; Thu, 13 Jun 2024 16:49:53 +0300 (EEST) Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-579e1bf599aso109961a12.3 for ; Thu, 13 Jun 2024 06:49:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718286593; x=1718891393; darn=ffmpeg.org; h=thread-index:content-language:content-transfer-encoding :mime-version:message-id:date:subject:in-reply-to:references:to:from :from:to:cc:subject:date:message-id:reply-to; bh=ou5mrMiiacvo/XgziuAEp1a1i3fAASfMFGGGkqBRiS0=; b=H3GRiU/ChY4rlejnO8hTXNBlIrTj6nxCAbhR8eAGfHx8xMVRVUK3m3lDU4+PcZ1wc7 kCouycbzLluhNWPXjY3MuII9HWcm1BHY2g76Za0rUE5v9C9NqLxcM8Ip4tRnfekaN1UR P+AEeMzcTBhkx9IYSkm0LbICDsq8l4IceVOf/CxEsx0LVsVZLGAw4xyAkvwYTGFf7fzx umeXgVMCyQTRcdaU5R7M2tN9U3Ga16McSoqInmOPPY5+aUtJuOvIjnKionCj0Ujvn6E8 q/W1WmAgDl4ljLIDnDUpLnFD/aOGi94xx5dcbtzjv0meGuAF0Xfjw24I4h5H/epNyjn6 Exuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718286593; x=1718891393; h=thread-index:content-language:content-transfer-encoding :mime-version:message-id:date:subject:in-reply-to:references:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ou5mrMiiacvo/XgziuAEp1a1i3fAASfMFGGGkqBRiS0=; b=XK+uCxKfVARtgL/Xuk1eFeNTvHk5hf0dauwTlT+b3fB5OlPvT1GXSD2hTiaDK3rbx9 N93/YYxjLEGEDTHMp5VnVqTXOoauL4QpTkSmfgosQpfCZShbD2eLiukrNdmb2PO1M5dR RG69EKxZMLRbFlGZsmxz1Lih7E332yf+XP82r+s6YnR0vxWkeFFZvj/DiL7UGmDmqeje f6ZiNB7gRc+SBavdUwxoHUKO5hGOwBfhXKykI5cHNw7hlOFzePLRUrZ0CQgeEOefs1fw hIbGKYPBGtO38JP8YjsgFKe46VTtfE5bCS/sIMLPh49qYbGkz2OYgTUu22kULm33R4eH k0vg== X-Gm-Message-State: AOJu0YxnoqS/wnmRhvvjEdcH9e8qz2mAbUXFcK9jm4HpO7kp20u8Yu/p pCTMjxuoYY2IrIGPDlAGy56j4tqfK6WB3Ap0O8w+v5uYPwmbMITQWgLZEQ== X-Google-Smtp-Source: AGHT+IFl2DQHg3YKkNUpY5ekxiNiD0X+acOayCOz6a4y5JG0u77TYwbe6K1iIuE8/ciOo7zltgX/NA== X-Received: by 2002:a50:9b4e:0:b0:57c:6d24:26e8 with SMTP id 4fb4d7f45d1cf-57cbc22b75dmr259062a12.4.1718286592992; Thu, 13 Jun 2024 06:49:52 -0700 (PDT) Received: from Mishu ([2a02:2f0f:830c:c700:a4f7:3c24:5d9d:9f1e]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-57cb743b032sm931052a12.92.2024.06.13.06.49.51 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Jun 2024 06:49:52 -0700 (PDT) From: To: "'FFmpeg development discussions and patches'" References: <000c01daa54d$8a0eedf0$9e2cc9d0$@gmail.com> <20240530213132.GE2821752@pb2> <008e01dab529$e5510630$aff31290$@gmail.com> <20240603224202.GD2821752@pb2> <001001dabbce$083f3c70$18bdb550$@gmail.com> <20240611171808.GP2821752@pb2> <005401dabd01$f66608f0$e3321ad0$@gmail.com> <1f77eae3-b3f2-477b-afe1-e31dc56917fa@noa-archive.com> <00c701dabd83$d33e1e80$79ba5b80$@gmail.com> <1fc50e5a-2400-40ff-92d9-b97889fd441e@noa-archive.com> In-Reply-To: <1fc50e5a-2400-40ff-92d9-b97889fd441e@noa-archive.com> Date: Thu, 13 Jun 2024 16:49:51 +0300 Message-ID: <00c801dabd98$90dfb6b0$b29f2410$@gmail.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Content-Language: ro Thread-Index: AQF53sdsVM9iibY6Rm6BSu+PKGSxTgKF963BAWal2xYCbz23lQJMz4PFAttEFQACFSpRXQGdKO3YAZLscbUBW0vj+rH2Tt4A Subject: Re: [FFmpeg-devel] [PATCH v3] area changed: scdet filter X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of Tobias > Rapp > Sent: joi, 13 iunie 2024 16:18 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v3] area changed: scdet filter > > On 13/06/2024 13:21, radu.taraibuta@gmail.com wrote: > > >> -----Original Message----- > >> From: ffmpeg-devel On Behalf Of > >> Tobias Rapp > >> Sent: joi, 13 iunie 2024 12:52 > >> To:ffmpeg-devel@ffmpeg.org > >> Subject: Re: [FFmpeg-devel] [PATCH v3] area changed: scdet filter > >> > >> On 12/06/2024 21:51,radu.taraibuta@gmail.com wrote: > >> > >> [...] > >> > >>> diff --git a/doc/filters.texi b/doc/filters.texi index > >>> bfa8ccec8b..53814e003b 100644 > >>> --- a/doc/filters.texi > >>> +++ b/doc/filters.texi > >>> @@ -21797,6 +21797,22 @@ Default value is @code{10.}. > >>> @item sc_pass, s > >>> Set the flag to pass scene change frames to the next filter. > >>> Default value is @code{0} > >>> You can enable it if you want to get snapshot of scene change > >>> frames only. > >>> + > >>> +@item mode > >>> +Set the scene change detection method. Default value is @code{-1} > >>> +Available values are: > >>> + > >>> +@table @samp > >>> +@item -1 > >>> +Legacy mode for sum of absolute linear differences. Compare frame > >>> with previous only and no delay. > >>> + > >>> +@item 0 > >>> +Sum of absolute linear differences. Compare frame with both > >>> +previous > >>> and next which introduces a 1 frame delay. > >>> + > >>> +@item 1 > >>> +Sum of mean of cubic root differences. Compare frame with both > >>> previous and next which introduces a 1 frame delay. > >>> + > >>> +@end table > >>> @end table > >>> > >>> @anchor{selectivecolor} > >> Out of curiosity: How do these three modes roughly compare (CPU) > >> performance wise? > > Mode -1 is virtually equal with mode 0 (no frame clone speedup of mode 0 is > mostly theoretical). Mode 1 is roughly 40% slower, depending on input, it > could benefit from ASM. > > > >> I'd prefer if mode "-1" could be used for the default case, and the > >> three modes get explicit values 0/1/2. > > So you want four possible values for mode where the default -1 is the same as > one of the others? > > Yes. This pattern is also used for the "shaping" option of the ass filter, for > example.It allows users to make it explicit that the filter should choose a > default (which may vary between versions). Scdet filter doesn't choose a mode. The default has to be current "Legacy" for backward compatibility. I will renumber modes to 0/1/2 to avoid confusion with an "auto" (-1) option. > >> Regarding naming I think that the "Legacy" mode still has its > >> usecases in the future. Naming it something like "simple" would not > >> imply that it is deprecated in general, but rather that it has lower > >> precision (and is possibly faster). > >> > > OK, I will rename "Legacy" mode so it doesn't look deprecated to somebody > that can't allow 1 frame delay. Otherwise it shouldn't be used. > > Thanks. > > Regards, Tobias > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org > with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".