Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: <radu.taraibuta@gmail.com>
To: "'FFmpeg development discussions and patches'" <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v3] area changed: scdet filter
Date: Thu, 13 Jun 2024 16:49:51 +0300
Message-ID: <00c801dabd98$90dfb6b0$b29f2410$@gmail.com> (raw)
In-Reply-To: <1fc50e5a-2400-40ff-92d9-b97889fd441e@noa-archive.com>

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Tobias
> Rapp
> Sent: joi, 13 iunie 2024 16:18
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH v3] area changed: scdet filter
> 
> On 13/06/2024 13:21, radu.taraibuta@gmail.com wrote:
> 
> >> -----Original Message-----
> >> From: ffmpeg-devel<ffmpeg-devel-bounces@ffmpeg.org>  On Behalf Of
> >> Tobias Rapp
> >> Sent: joi, 13 iunie 2024 12:52
> >> To:ffmpeg-devel@ffmpeg.org
> >> Subject: Re: [FFmpeg-devel] [PATCH v3] area changed: scdet filter
> >>
> >> On 12/06/2024 21:51,radu.taraibuta@gmail.com  wrote:
> >>
> >> [...]
> >>
> >>> diff --git a/doc/filters.texi b/doc/filters.texi index
> >>> bfa8ccec8b..53814e003b 100644
> >>> --- a/doc/filters.texi
> >>> +++ b/doc/filters.texi
> >>> @@ -21797,6 +21797,22 @@ Default value is @code{10.}.
> >>>   @item sc_pass, s
> >>>   Set the flag to pass scene change frames to the next filter.
> >>> Default value is @code{0}
> >>>   You can enable it if you want to get snapshot of scene change
> >>> frames only.
> >>> +
> >>> +@item mode
> >>> +Set the scene change detection method. Default value is @code{-1}
> >>> +Available values are:
> >>> +
> >>> +@table @samp
> >>> +@item -1
> >>> +Legacy mode for sum of absolute linear differences. Compare frame
> >>> with previous only and no delay.
> >>> +
> >>> +@item 0
> >>> +Sum of absolute linear differences. Compare frame with both
> >>> +previous
> >>> and next which introduces a 1 frame delay.
> >>> +
> >>> +@item 1
> >>> +Sum of mean of cubic root differences. Compare frame with both
> >>> previous and next which introduces a 1 frame delay.
> >>> +
> >>> +@end table
> >>>   @end table
> >>>
> >>>   @anchor{selectivecolor}
> >> Out of curiosity: How do these three modes roughly compare (CPU)
> >> performance wise?
> > Mode -1 is virtually equal with mode 0 (no frame clone speedup of mode 0
is
> mostly theoretical). Mode 1 is roughly 40% slower, depending on input, it
> could benefit from ASM.
> >
> >> I'd prefer if mode "-1" could be used for the default case, and the
> >> three modes get explicit values 0/1/2.
> > So you want four possible values for mode where the default -1 is the
same as
> one of the others?
> 
> Yes. This pattern is also used for the "shaping" option of the ass filter,
for
> example.It allows users to make it explicit that the filter should choose
a
> default (which may vary between versions).

Scdet filter doesn't choose a mode. The default has to be current "Legacy"
for backward compatibility.
I will renumber modes to 0/1/2 to avoid confusion with an "auto" (-1)
option.

> >> Regarding naming I think that the "Legacy" mode still has its
> >> usecases in the future. Naming it something like "simple" would not
> >> imply that it is deprecated in general, but rather that it has lower
> >> precision (and is possibly faster).
> >>
> > OK, I will rename "Legacy" mode so it doesn't look deprecated to
somebody
> that can't allow 1 frame delay. Otherwise it shouldn't be used.
> 
> Thanks.
> 
> Regards, Tobias
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org
> with subject "unsubscribe".

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2024-06-13 13:50 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-13 15:52 [FFmpeg-devel] [PATCH] " radu.taraibuta
2024-05-19 16:05 ` radu.taraibuta
2024-05-28  7:51   ` radu.taraibuta
2024-05-28 13:16     ` Paul B Mahol
2024-05-30 21:31 ` Michael Niedermayer
2024-06-02 20:17   ` radu.taraibuta
2024-06-03 22:42     ` Michael Niedermayer
2024-06-11  7:07       ` [FFmpeg-devel] [PATCH v2] " radu.taraibuta
2024-06-11 17:18         ` Michael Niedermayer
2024-06-12 19:51           ` [FFmpeg-devel] [PATCH v3] " radu.taraibuta
2024-06-12 23:52             ` Michael Niedermayer
2024-06-13  7:28               ` radu.taraibuta
2024-06-13  9:52             ` Tobias Rapp
2024-06-13 11:21               ` radu.taraibuta
2024-06-13 13:18                 ` Tobias Rapp
2024-06-13 13:49                   ` radu.taraibuta [this message]
2024-06-13 18:16                     ` [FFmpeg-devel] [PATCH v4] " radu.taraibuta
2024-06-14  7:22                       ` Tobias Rapp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='00c801dabd98$90dfb6b0$b29f2410$@gmail.com' \
    --to=radu.taraibuta@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git