From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id DC47B4B7BC
	for <ffmpegdev@gitmailbox.com>; Thu, 13 Jun 2024 11:21:35 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D1E3C68D9C8;
	Thu, 13 Jun 2024 14:21:32 +0300 (EEST)
Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com
 [209.85.208.50])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 01FFE68D953
 for <ffmpeg-devel@ffmpeg.org>; Thu, 13 Jun 2024 14:21:25 +0300 (EEST)
Received: by mail-ed1-f50.google.com with SMTP id
 4fb4d7f45d1cf-57c74085d57so113594a12.3
 for <ffmpeg-devel@ffmpeg.org>; Thu, 13 Jun 2024 04:21:25 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1718277685; x=1718882485; darn=ffmpeg.org;
 h=thread-index:content-language:content-transfer-encoding
 :mime-version:message-id:date:subject:in-reply-to:references:to:from
 :from:to:cc:subject:date:message-id:reply-to;
 bh=mPnRyJ14mpoaseFjDJetHzgyaYWv+c6pcY/mMdeuTyU=;
 b=Nd6vRRkfocmm8L2xieE5sWd4RUKhUeKejUn+WtWK7O84G1FcOFiBblHRMNwJJ0g2Lc
 c1Z7ETN14VMbRFaA30Xq8j2vdncQhBAaR2Aww211jgqavVwZzYuFwDoy8AFVArNFZoo7
 x+M371dPobeDZLOS9M6AqyPgMeU50lKbG2htj/REPYKTOsIwEBPvmsAU5WaG38ANr3Ae
 1wKbXx0/HVMkzeK4r+DlYt/jKhDXMXfsaECcw/tbl/O2VVsoA91/tE3lFEYilSD7hC4k
 CX5Tg9zOqZyiUtgGff1BMZwipcehZXSlxW+g250HHmSPii5XCh6d4UAGnSFuWfF+Ct5v
 meyQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1718277685; x=1718882485;
 h=thread-index:content-language:content-transfer-encoding
 :mime-version:message-id:date:subject:in-reply-to:references:to:from
 :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
 bh=mPnRyJ14mpoaseFjDJetHzgyaYWv+c6pcY/mMdeuTyU=;
 b=tuM/dWVbIH30thUDEwsb4v6v4hV7ldqLUE72vI+rC5l43TxeJfhzalLBnO+gyYoMXP
 fytoVuQpua1n4XwDBanTIb6XkGJySjZulYbCwv2LLUhXGDmfsc9PQjv+8TUz62Dnpl5s
 GIY0WA+cSDrHeRcQrz6xNMmgQtJ4WzPDuIbdEj321RZyC0iYVZDEsyxb4/IILWvQ+x61
 1vQ9gT5q2hW9XXvUxLNTCI/zF8YByZf8JR+v0oilLqF29v6Zk71TZswJc0r1JbwHeoRg
 Yfh7HQeoJNreEsmfJ7rbVBdDzC9X6shoccGDOFU0uOjtFwK7IJb9UqNAisup5Z0TqaHT
 ndJQ==
X-Gm-Message-State: AOJu0YzxFQQSjxaAcAESL9j8Q8gMPOtv7BfJwiG2z8NxiN6ccb4dmw/7
 IeIV2gqHTVncfbML3iRYKNAE53ILLJKXN3da4UskeUfwbd7P71fEEewboQ==
X-Google-Smtp-Source: AGHT+IFI7mP1/fkKtcXuLRIdi7Q6+3rFzPwl/4cHSKgvTKGOLs+LlYg+8ypIE71HbfNtIlNH937g0Q==
X-Received: by 2002:a50:aa94:0:b0:57c:61b3:bdc1 with SMTP id
 4fb4d7f45d1cf-57cbc21968amr47076a12.3.1718277685003; 
 Thu, 13 Jun 2024 04:21:25 -0700 (PDT)
Received: from Mishu ([2a02:2f0f:830c:c700:a4f7:3c24:5d9d:9f1e])
 by smtp.gmail.com with ESMTPSA id
 4fb4d7f45d1cf-57cb722dad1sm794183a12.0.2024.06.13.04.21.23
 for <ffmpeg-devel@ffmpeg.org>
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 13 Jun 2024 04:21:24 -0700 (PDT)
From: <radu.taraibuta@gmail.com>
To: "'FFmpeg development discussions and patches'" <ffmpeg-devel@ffmpeg.org>
References: <000c01daa54d$8a0eedf0$9e2cc9d0$@gmail.com>
 <20240530213132.GE2821752@pb2> <008e01dab529$e5510630$aff31290$@gmail.com>
 <20240603224202.GD2821752@pb2> <001001dabbce$083f3c70$18bdb550$@gmail.com>
 <20240611171808.GP2821752@pb2> <005401dabd01$f66608f0$e3321ad0$@gmail.com>
 <1f77eae3-b3f2-477b-afe1-e31dc56917fa@noa-archive.com>
In-Reply-To: <1f77eae3-b3f2-477b-afe1-e31dc56917fa@noa-archive.com>
Date: Thu, 13 Jun 2024 14:21:23 +0300
Message-ID: <00c701dabd83$d33e1e80$79ba5b80$@gmail.com>
MIME-Version: 1.0
X-Mailer: Microsoft Outlook 16.0
Content-Language: ro
Thread-Index: AQF53sdsVM9iibY6Rm6BSu+PKGSxTgKF963BAWal2xYCbz23lQJMz4PFAttEFQACFSpRXQGdKO3Ysg2RZuA=
Subject: Re: [FFmpeg-devel] [PATCH v3] area changed: scdet filter
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/00c701dabd83$d33e1e80$79ba5b80$@gmail.com/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>


> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Tobias
> Rapp
> Sent: joi, 13 iunie 2024 12:52
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH v3] area changed: scdet filter
> 
> On 12/06/2024 21:51, radu.taraibuta@gmail.com wrote:
> 
> [...]
> 
> > diff --git a/doc/filters.texi b/doc/filters.texi index
> > bfa8ccec8b..53814e003b 100644
> > --- a/doc/filters.texi
> > +++ b/doc/filters.texi
> > @@ -21797,6 +21797,22 @@ Default value is @code{10.}.
> >  @item sc_pass, s
> >  Set the flag to pass scene change frames to the next filter. Default
> > value is @code{0}
> >  You can enable it if you want to get snapshot of scene change frames
> > only.
> > +
> > +@item mode
> > +Set the scene change detection method. Default value is @code{-1}
> > +Available values are:
> > +
> > +@table @samp
> > +@item -1
> > +Legacy mode for sum of absolute linear differences. Compare frame
> > with previous only and no delay.
> > +
> > +@item 0
> > +Sum of absolute linear differences. Compare frame with both previous
> > and next which introduces a 1 frame delay.
> > +
> > +@item 1
> > +Sum of mean of cubic root differences. Compare frame with both
> > previous and next which introduces a 1 frame delay.
> > +
> > +@end table
> >  @end table
> >
> >  @anchor{selectivecolor}
> 
> Out of curiosity: How do these three modes roughly compare (CPU)
> performance wise?

Mode -1 is virtually equal with mode 0 (no frame clone speedup of mode 0 is mostly theoretical). Mode 1 is roughly 40% slower, depending on input, it could benefit from ASM.

> I'd prefer if mode "-1" could be used for the default case, and the three modes
> get explicit values 0/1/2. 

So you want four possible values for mode where the default -1 is the same as one of the others?

>Regarding naming I think that the "Legacy" mode still
> has its usecases in the future. Naming it something like "simple" would not
> imply that it is deprecated in general, but rather that it has lower precision
> (and is possibly faster).
> 
OK, I will rename "Legacy" mode so it doesn't look deprecated to somebody that can't allow 1 frame delay. Otherwise it shouldn't be used.


_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".