From: "Xiang, Haihao" <haihao.xiang-at-intel.com@ffmpeg.org>
To: "ffmpeg-devel@ffmpeg.org" <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] hwcontext_opencl: choose the first device if multiple devices are available
Date: Tue, 30 Jan 2024 06:32:20 +0000
Message-ID: <00beea2d6282b1e824b9811cde69ce5f7a982fba.camel@intel.com> (raw)
In-Reply-To: <03dd09b71a0c1de6a99533636820c2477a88bdcd.camel@intel.com>
On Di, 2024-01-23 at 02:52 +0000, Xiang, Haihao wrote:
> On Ma, 2024-01-22 at 20:32 +0000, Mark Thompson wrote:
> > On 17/01/2024 07:36, Xiang, Haihao wrote:
> > > From: Haihao Xiang <haihao.xiang@intel.com>
> > >
> > > This makes '-init_hw_device opencl' work in a multiple-device system.
> >
> > Under what circumstances is this more useful than the existing behaviour
> > which
> > prompts the user to select the device they intend?
>
> @item -init_hw_device
> @var{type}[=@var{name}][:@var{device}[,@var{key=value}...]]
>
> My understanding is that only @var{type} is mandatory, @var{device} (and
> others)
> is optional, indeed '-init_hw_device opencl' works well in a single-device
> system, however the same command doesn't work in a multiple-device system. It
> is
> not a good experience for me.
>
> >
> > There is no particular ordering to devices, the first one is just random.
> > Having your process fail with an opaque message (because the device picked
> > lacks some operation) or run many times slower than expected (because the
> > smallest device happened to be first in the list) or do something different
> > on
> > a machine which looks the same (because it has an extra driver for something
> > else) rather than just saying up front that there are multiple devices and
> > the
> > user needs to pick seems worse to me, since it is much harder to see where
> > the
> > problem is.
>
> I understand your concern, how about making the default works while prompting
> a
> warning about the device selection ?
Hi Mark,
Do you have more comments ?
Thanks
Haihao
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2024-01-30 6:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-17 7:36 Xiang, Haihao
2024-01-22 20:32 ` Mark Thompson
2024-01-23 2:52 ` Xiang, Haihao
2024-01-30 6:32 ` Xiang, Haihao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00beea2d6282b1e824b9811cde69ce5f7a982fba.camel@intel.com \
--to=haihao.xiang-at-intel.com@ffmpeg.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git