Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: add compile time check for outputRecoveryPointSEI for HEVC

From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: add compile time check for outputRecoveryPointSEI for HEVC
Date: Tue, 4 Feb 2025 10:57:29 -0300
Message-ID: <00b43a0a-75d1-4102-9e1b-1bd54e441b57@gmail.com> (raw)
In-Reply-To: <c4b9bdb4-8425-e315-7e7b-d26c54151fa1@martin.st>

[-- Attachment #1.1.1: Type: text/plain, Size: 969 bytes --]

On 2/4/2025 10:52 AM, Martin Storsjö wrote:
> On Tue, 4 Feb 2025, James Almer wrote:
> 
>>> Thanks, this does indeed seem to fix compilation in my setup.
>>
>> Applied.
>>
>> Why don't don't just update the headers? Is it a system package 
>> provided by your distro?
> 
> I guess I could, but as long as I don't have a pressing need to, just 
> staying with the current version is easiest. Do the headers major 
> version need to match the installed drivers/proprietary nvidia libs? (In 
> my setup, the drivers/nvidia libs are distributed entirely separately - 
> touching that bit is a lot of effort.)

No, they don't need to match afaik. The headers are meant to be ABI 
backwards compatible (hence all the reserved fields).

I was just wondering if the headers were provided by your distro or not 
(Given they are compile time deps and not runtime), and looking now at 
the package lists in some, i see they are, so disregard my question.

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".