From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8A2D643DD3 for ; Fri, 12 Aug 2022 06:57:28 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9F9EB68B959; Fri, 12 Aug 2022 09:57:24 +0300 (EEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6101D68B92E for ; Fri, 12 Aug 2022 09:57:17 +0300 (EEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20220812065713euoutp02b837f6400ad4cf64a6eb725398a15d37~Khp_-To0A1691916919euoutp02t for ; Fri, 12 Aug 2022 06:57:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20220812065713euoutp02b837f6400ad4cf64a6eb725398a15d37~Khp_-To0A1691916919euoutp02t DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1660287433; bh=WIv3PIsYklCsZadaS+t5IbmCooeiczTIdKEz5fGBa+g=; h=From:To:In-Reply-To:Subject:Date:References:From; b=TKThzmASBfgEH3gqfijxHNDT0AW5RdlgCp9Vi+NP7td9FBtvOWNLiwx/poj5v68BH bOfVCWt0budgzci+t86ur+cX7WLwKqNvyS2KUAdIytu4fAvWS21riZEXYlK9RIbH75 1BmdPbeLjCFIbrbLHXnaxKZADl0/EW2NNaFnHTmc= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20220812065713eucas1p2b7f6c6a25b6880d8161db229c8cc8e76~Khp_5OrzM0126701267eucas1p2O for ; Fri, 12 Aug 2022 06:57:13 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 54.C2.09664.9C9F5F26; Fri, 12 Aug 2022 07:57:13 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20220812065712eucas1p26e1af2dc9e8ab0fc36bdb5aa709cec66~Khp_i0Mn80352703527eucas1p2o for ; Fri, 12 Aug 2022 06:57:12 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20220812065712eusmtrp1da161f73eb24c74935312284ab69dec6~Khp_iJWpl2259022590eusmtrp1n for ; Fri, 12 Aug 2022 06:57:12 +0000 (GMT) X-AuditID: cbfec7f2-d81ff700000025c0-bd-62f5f9c9633e Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 1F.DD.09038.8C9F5F26; Fri, 12 Aug 2022 07:57:12 +0100 (BST) Received: from AMDN3260 (unknown [106.210.132.171]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20220812065712eusmtip219bc3a5eb6f048353ec840f815d421d8~Khp_TFYAx1781417814eusmtip2I for ; Fri, 12 Aug 2022 06:57:12 +0000 (GMT) From: =?utf-8?Q?Dawid_Kozinski/Robot_SDK_=28PLT=29_/?= =?utf-8?Q?SRPOL/Staff_Engineer/=EC=82=BC=EC=84=B1=EC=A0=84=EC=9E=90?= To: "'FFmpeg development discussions and patches'" In-Reply-To: <20220811210550.GG2088045@pb2> Date: Fri, 12 Aug 2022 08:57:12 +0200 Message-ID: <009901d8ae18$bfb8d840$3f2a88c0$@samsung.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQDsDOjYe+BpTXB7J0pJL/sFx9/mQgFZJya3AdrJNISvanby4A== Content-Language: pl X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrJIsWRmVeSWpSXmKPExsWy7djPc7onf35NMvh2kN3i26czzA6MHn8W bWYJYIzisklJzcksSy3St0vgyph88iBTQYtcRdOmQ8wNjA8luhg5OSQETCSOnpvI2sXIxSEk sIJR4vfHrWwQziQmiVX9x5ggnIlMEkvfzWWDadm0ehUjRGI5o8SxbVOYIZw2Jon+3evBHDaB mYwSc7+uYQRpERHwkehev54VxOYU0JZYMGUymC0skCHRt3QzM4jNIqAq8aH9G5jNK2ApMXf/ eyYIW1Di5MwnLCA2s4C8xPa3c5ghzlCQ+Pl0GSvEfCeJ9i3vmCBqRCRuPGoBO09CYCqHxNpV J4EcDiDHRWL5Nh6IXmGJV8e3sEPYMhKnJ/ewQJQUSxzqd4AwayQO/UiHqLCWeNt4HGwIs4Cm xPpd+hBhR4kdXSfYIKr5JG68FYTYzycxadt0Zogwr0RHmxCEqSLR1ykG0Sgl8XTZHOYJjEqz kDw4C8mDs5A8Mgth7QJGllWM4qmlxbnpqcWGeanlesWJucWleel6yfm5mxiBqeH0v+OfdjDO ffVR7xAjEwfjIUYJDmYlEd6yRZ+ThHhTEiurUovy44tKc1KLDzFKc7AoifMmZ25IFBJITyxJ zU5NLUgtgskycXBKNTDVFjg+/uJzu3/F61PRP6dnaLe+Yjxt0Xg8Xanb8dj6OUciSoVMNzT1 qVTGX7ll8ahcSjTOzl2q4od+6b3WM+WH63MW91zafEt+t/SvWNuN8ZtnbtzUX3Pzqv6r/mzN LdntMm/CNvO/fMBjub1Y1GXzzpnz93sohiyeeKt24q59e4QnK0zTz99c3LBriV/OhgOuF+Lu fK38cUXs21mnaRwnLi1qWv3c+pvY7S1ObZ/m8el/XXd5EYulV+zn5hffT7/fJ6zOvOLLNq54 3ZIalgzZ2ks/tZmnzMwvnFJcuPhU5n77rxvLA7O2yDjpdcX/8vH5Vf9+6R2J4Nlxq76fiF9Y +Kf21tbCtNAqQ67nvi0HlViKMxINtZiLihMBNGipV3wDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpgkeLIzCtJLcpLzFFi42I5/e/4Pd0TP78mGZw/r2vx7dMZZgdGjz+L NrMEMEbp2RTll5akKmTkF5fYKkUbWhjpGVpa6BmZWOoZGpvHWhmZKunb2aSk5mSWpRbp2yXo ZUw+eZCpoEWuomnTIeYGxocSXYycHBICJhKbVq9i7GLk4hASWMooMXHpc0aIhJTE0qWLoGxh iT/XuthAbCGBFiaJ8/cyQBrYBKYzSpw82McEkhAR8JHoXr+eFWLSKkaJ6ZNus4MkOAW0JRZM mcwKYgsLpElMfnKQBcRmEVCV+ND+jRnE5hWwlJi7/z0ThC0ocXLmE7AaZqDepzefQtnyEtvf zmGGuEhB4ufTZawQi50k2re8Y4KoEZG48aiFcQKj0Cwko2YhGTULyahZSFoWMLKsYhRJLS3O Tc8tNtIrTswtLs1L10vOz93ECIyKbcd+btnBuPLVR71DjEwcjIcYJTiYlUR4yxZ9ThLiTUms rEotyo8vKs1JLT7EaAr020RmKdHkfGBc5pXEG5oZmBqamFkamFqaGSuJ83oWdCQKCaQnlqRm p6YWpBbB9DFxcEo1MK25v+7hu+xTbGm9qx4ltv8+UqsQUBwRF+74JkKIZ6Wcx4Y1MS/nxF9W yNlxJfac7ZnVU19NldS6oXaEe4399kfqfVf2SBSKC0nezHl3w2bNnd619quzN8yzSb39NyR1 ntsrHc5YfUu3HWvLr/1M/Xit2Gnfe0uOCcpse9hfqUnbNX69lsDpVxBn+cvnDcOT/woHZG6W PT5aNcta3urlvfkvWaIWpa/38udnWqEaMCVP+c/C83KZW66F8+k4i+SYS164+q9k+qplmuw6 u/d/z9B0bdp6yyNBJU77cPneg7WVB6Y88f3AtWr167AUnR1+lTpLT20KSNzsV+X3ZlUU39wz 3Oqp7/9defVcMHrPjTtKLMUZiYZazEXFiQAAQGEHEwMAAA== X-CMS-MailID: 20220812065712eucas1p26e1af2dc9e8ab0fc36bdb5aa709cec66 X-Msg-Generator: CA X-RootMTR: 20220811123648eucas1p1336fd2c107be031a4a274057bf20084f X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20220811123648eucas1p1336fd2c107be031a4a274057bf20084f References: <006a01d8ad7f$05f788f0$11e69ad0$@samsung.com> <20220811210550.GG2088045@pb2> Subject: Re: [FFmpeg-devel] [PATCH 2/2] Provided support for MPEG-5 EVC (Essential Video Coding) codec X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Hi Michael, After I'd applied my patches onto master ffmpeg branch then I ran ffmpeg FATE but FATE didn't report any issues. I followed the steps described on https://ffmpeg.org/fate.html make fate-rsync SAMPLES=fate-suite/ make fate SAMPLES=fate-suite/ Then I checked tests/ref/fate/source file but it didn't contain any reports about issues inside. It looks like follows: Files without standard license headers: libavcodec/file_open.c libavcodec/ilbcdata.h libavcodec/ilbcdec.c libavcodec/interplayacm.c libavcodec/log2_tab.c libavcodec/reverse.c libavdevice/file_open.c libavdevice/reverse.c libavfilter/af_arnndn.c libavfilter/file_open.c libavfilter/log2_tab.c libavformat/file_open.c libavformat/golomb_tab.c libavformat/log2_tab.c libswresample/log2_tab.c libswscale/log2_tab.c tools/uncoded_frame.c tools/yuvcmp.c Headers without standard inclusion guards: compat/djgpp/math.h compat/float/float.h compat/float/limits.h tools/decode_simple.h Use of av_clip() where av_clip_uintp2() could be used: Use of av_clip() where av_clip_intp2() could be used: I'm not able to reproduce the issue pointed out by you. Tell me please if I do something the wrong way. Any hints will be appreciated. -----Original Message----- From: ffmpeg-devel On Behalf Of Michael Niedermayer Sent: Thursday, August 11, 2022 11:06 PM To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 2/2] Provided support for MPEG-5 EVC (Essential Video Coding) codec On Thu, Aug 11, 2022 at 02:36:47PM +0200, Dawid Kozinski wrote: > - Added muxer for EVC format (MP4, raw) > - Added demuxer for EVC format (MP4) > - Added evc extension to the list of extensions for ff_mov_demuxer > - Added information to moov atom [...] > diff --git a/libavformat/evc.h b/libavformat/evc.h > new file mode 100644 > index 0000000000..d7b93d521d > --- /dev/null > +++ b/libavformat/evc.h > @@ -0,0 +1,147 @@ > +/* > + * EVC helper functions for muxers > + * Copyright (c) 2022 Dawid Kozinski > + * > + * This file is part of FFmpeg. > + * > + * FFmpeg is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. > + * > + * FFmpeg is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with FFmpeg; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA > + */ > + > +#ifndef AVFORMAT_EVC_H > +#define AVFORMAT_EVC_H [...] > +#endif // AVFORMAT_EVC_H > \ No newline at end of file fate-source is not happy about this: --- ./tests/ref/fate/source 2022-07-29 22:42:50.354493777 +0200 +++ tests/data/fate/source 2022-08-11 22:54:59.715488573 +0200 @@ -21,6 +21,7 @@ compat/djgpp/math.h compat/float/float.h compat/float/limits.h +libavformat/evc.h tools/decode_simple.h Use of av_clip() where av_clip_uintp2() could be used: Use of av_clip() where av_clip_intp2() could be used: Test source failed. Look at tests/data/fate/source.err for details. tests/Makefile:304: recipe for target 'fate-source' failed make: *** [fate-source] Error 1 [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".