Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: "Xiang, Haihao" <haihao.xiang-at-intel.com@ffmpeg.org>
To: "ffmpeg-devel@ffmpeg.org" <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 2/5] doc/examples/qsv_transcode: Simplify loop
Date: Wed, 24 Apr 2024 05:25:11 +0000
Message-ID: <008eee96e8d1dec9381530899c24fbcdf49afa6b.camel@intel.com> (raw)
In-Reply-To: <20240424014522.4015429-2-michael@niedermayer.cc>

On Wo, 2024-04-24 at 03:45 +0200, Michael Niedermayer wrote:
> Fixes: CID1428858(2/2) Logically dead code
> 
> Sponsored-by: Sovereign Tech Fund
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  doc/examples/qsv_transcode.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/doc/examples/qsv_transcode.c b/doc/examples/qsv_transcode.c
> index 8e7d2899f12..a4440a3403f 100644
> --- a/doc/examples/qsv_transcode.c
> +++ b/doc/examples/qsv_transcode.c
> @@ -335,10 +335,8 @@ static int dec_enc(AVPacket *pkt, const AVCodec
> *enc_codec, char *optstr)
>  
>  fail:
>          av_frame_free(&frame);
> -        if (ret < 0)
> -            return ret;
>      }
> -    return 0;
> +    return ret;
>  }
>  
>  int main(int argc, char **argv)

LGTM

Thanks
Haihao





_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2024-04-24  5:25 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-24  1:45 [FFmpeg-devel] [PATCH 1/5] doc/examples/demux_decode: " Michael Niedermayer
2024-04-24  1:45 ` [FFmpeg-devel] [PATCH 2/5] doc/examples/qsv_transcode: " Michael Niedermayer
2024-04-24  5:25   ` Xiang, Haihao [this message]
2024-04-24 21:05     ` Michael Niedermayer
2024-04-24  1:45 ` [FFmpeg-devel] [PATCH 3/5] doc/examples/vaapi_transcode: " Michael Niedermayer
2024-04-24  6:39   ` mypopy
2024-04-24 21:06     ` Michael Niedermayer
2024-04-24  1:45 ` [FFmpeg-devel] [PATCH 4/5] doc/examples/qsv_transcode: Simplify str_to_dict() loop Michael Niedermayer
2024-04-24  5:18   ` Xiang, Haihao
2024-04-24 21:07     ` Michael Niedermayer
2024-04-24  1:45 ` [FFmpeg-devel] [PATCH 5/5] doc/examples/qsv_transcode: Initialize pointer before free Michael Niedermayer
2024-04-24  5:19   ` Xiang, Haihao
2024-05-09  1:06 ` [FFmpeg-devel] [PATCH 1/5] doc/examples/demux_decode: Simplify loop Michael Niedermayer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=008eee96e8d1dec9381530899c24fbcdf49afa6b.camel@intel.com \
    --to=haihao.xiang-at-intel.com@ffmpeg.org \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git