Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: "Dawid Kozinski/Multimedia \(PLT\) /SRPOL/Staff Engineer/Samsung Electronics" <d.kozinski@samsung.com>
To: "'FFmpeg development discussions and patches'" <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 6/9] avcodec/libxevd: Remove useless AVClass
Date: Wed, 6 Mar 2024 11:38:04 +0100
Message-ID: <005d01da6fb2$5f142af0$1d3c80d0$@samsung.com> (raw)
In-Reply-To: <AS8P250MB0744812BC907FEF4E91025738F592@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>





> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
> Andreas Rheinhardt
> Sent: wtorek, 27 lutego 2024 20:59
> To: ffmpeg-devel@ffmpeg.org
> Cc: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> Subject: [FFmpeg-devel] [PATCH 6/9] avcodec/libxevd: Remove useless
AVClass
> 
> This decoder does not have options.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  libavcodec/libxevd.c | 12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff --git a/libavcodec/libxevd.c b/libavcodec/libxevd.c index
> de0739a80c..5075936a0e 100644
> --- a/libavcodec/libxevd.c
> +++ b/libavcodec/libxevd.c
> @@ -50,8 +50,6 @@
>   * The structure stores all the states associated with the instance of
Xeve MPEG-
> 5 EVC decoder
>   */
>  typedef struct XevdContext {
> -    const AVClass *class;
> -
>      XEVD id;            // XEVD instance identifier @see xevd.h
>      XEVD_CDSC cdsc;     // decoding parameters @see xevd.h
> 
> @@ -471,15 +469,6 @@ static av_cold int libxevd_close(AVCodecContext
> *avctx)
>      return 0;
>  }
> 
> -#define OFFSET(x) offsetof(XevdContext, x) -#define VD
> AV_OPT_FLAG_VIDEO_PARAM | AV_OPT_FLAG_DECODING_PARAM
> -
> -static const AVClass libxevd_class = {
> -    .class_name = "libxevd",
> -    .item_name  = av_default_item_name,
> -    .version    = LIBAVUTIL_VERSION_INT,
> -};
> -
>  const FFCodec ff_libxevd_decoder = {
>      .p.name             = "evc",
>      .p.long_name        = NULL_IF_CONFIG_SMALL("EVC / MPEG-5 Essential
Video
> Coding (EVC)"),
> @@ -489,7 +478,6 @@ const FFCodec ff_libxevd_decoder = {
>      FF_CODEC_RECEIVE_FRAME_CB(libxevd_receive_frame),
>      .close              = libxevd_close,
>      .priv_data_size     = sizeof(XevdContext),
> -    .p.priv_class       = &libxevd_class,
>      .p.capabilities     = AV_CODEC_CAP_DR1 | AV_CODEC_CAP_DELAY |
>                            AV_CODEC_CAP_OTHER_THREADS |
> AV_CODEC_CAP_AVOID_PROBING,
>      .p.profiles         = NULL_IF_CONFIG_SMALL(ff_evc_profiles),
> --
> 2.40.1
> 
It has been checked. Looks good.

> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://protect2.fireeye.com/v1/url?k=bf2f1a4e-e0b33364-bf2e9101-
> 000babe598f7-5400e6cfb92c61da&q=1&e=f85ba7c0-e001-488d-9c87-
> 565dfbde8ea3&u=https%3A%2F%2Fffmpeg.org%2Fmailman%2Flistinfo%2Fffmp
> eg-devel
> 
> To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org
> with subject "unsubscribe".

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2024-03-06 10:38 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20240227194657eucas1p1332e4d035ca55a684ef190a5ea1946ee@eucas1p1.samsung.com>
2024-02-27 19:48 ` [FFmpeg-devel] [PATCH 1/9] avcodec/libxevd: Remove FF_CODEC_CAP_SETS_PKT_DTS cap Andreas Rheinhardt
2024-02-27 19:58   ` [FFmpeg-devel] [PATCH 2/9] avcodec/libxevd: Set AV_CODEC_CAP_DR1 Andreas Rheinhardt
2024-03-06 10:37     ` Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics
2024-02-27 19:58   ` [FFmpeg-devel] [PATCH 3/9] avcodec/libxevd: Avoid cloning AVPacket Andreas Rheinhardt
2024-02-27 19:58   ` [FFmpeg-devel] [PATCH 4/9] avcodec/libxevd: Deduplicate code Andreas Rheinhardt
2024-02-27 19:58   ` [FFmpeg-devel] [PATCH 5/9] avcodec/libxevd: Reindent after the previous commit Andreas Rheinhardt
2024-02-27 19:58   ` [FFmpeg-devel] [PATCH 6/9] avcodec/libxevd: Remove useless AVClass Andreas Rheinhardt
2024-03-06 10:38     ` Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics [this message]
2024-02-27 19:58   ` [FFmpeg-devel] [PATCH 7/9] avcodec/libxevd: Use CODEC_LONG_NAME() Andreas Rheinhardt
2024-03-06 10:38     ` Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics
2024-02-27 19:58   ` [FFmpeg-devel] [PATCH 8/9] avcodec/libxevd: Improve included headers a bit Andreas Rheinhardt
2024-02-27 19:58   ` [FFmpeg-devel] [PATCH 9/9] avcodec/libxevd: Fix "if (ret = ff_foo() < 0)" precedence problem Andreas Rheinhardt
2024-02-29  9:36   ` [FFmpeg-devel] [PATCH 1/9] avcodec/libxevd: Remove FF_CODEC_CAP_SETS_PKT_DTS cap Andreas Rheinhardt
2024-03-06 10:38     ` Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics
2024-03-06 10:37   ` Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='005d01da6fb2$5f142af0$1d3c80d0$@samsung.com' \
    --to=d.kozinski@samsung.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git