From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 97F92402C8 for ; Sun, 19 Mar 2023 14:25:01 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DB84368C36F; Sun, 19 Mar 2023 16:24:57 +0200 (EET) Received: from mail-ot1-f43.google.com (mail-ot1-f43.google.com [209.85.210.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0671C68C285 for ; Sun, 19 Mar 2023 16:24:51 +0200 (EET) Received: by mail-ot1-f43.google.com with SMTP id f17-20020a9d7b51000000b00697349ab7e7so5448248oto.9 for ; Sun, 19 Mar 2023 07:24:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679235889; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=ZP5ylKkaikMw9IRwr/MQ1ogIvRMByIrBV3XORLMrqyY=; b=lx8BQ4HOEbufELCcgNYfc+m8YqbKeoSIzybH3ufdY5PPJszCqxDacIAOTzdAH26xwB qbuWLhMfnU2YYUEBr1gBNUGnyj6YmlSf4MyWDblJYG9aRsrfGufCsYWqOSfaExDxFCeG WqkUF5+7jv8oMmG2qJYhInxzf6jOlhdXGNPAegYcRQfMYk4ABBdL2k1JU9kC38OWYNP7 Td1XJKshqWJ685gPQn3W0m8T2ah4zFCX78enMUsc+cfS9D4Crp94RAXFmKyHRPkV/qgS +/g0MpiiTqwXhacUluaKXqMKjs1Lvp0bbYxvxfmZUGHEOOJC9rMy/wdA/PitIdf3VExG h+ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679235889; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZP5ylKkaikMw9IRwr/MQ1ogIvRMByIrBV3XORLMrqyY=; b=X4VepjWDVfSqF3g5zOJTFmez9lZ3CYLj5zQC1pdhsOZ0Y4Qz490VqTMBVi7hxdYStX qsiI3lii0JklKaZnQz3W1raSeOwJF2H9KzjzZAPnR7QEumtXfuLk5eweo/YeZle1Xw7y 1U/qdtgDbqxlygnqwYbyWvQKRti6ZTBTvT9HPnc1pkXeR2kWb4nh6tj4RprN5kLs0YIh KQ2DZiC2dYUVrrr3GVav7rDvYg/maek3IOzNhVUuH96xuNFu/uKE1bYd+q+XqeloDVyG gV2e0wU2LGq5wwpuEx/Gnm4zBIIHTZP2681IoANXee/02N2Nhv9RlRh/sMFBH2f0JAxL 7iZw== X-Gm-Message-State: AO0yUKWzY7QrOFIw/63meMlTxn6xHvsiA8WpHvv72MvPSTTIcuFok2Sh s0MPbwGfTBONoWovVsnkI0LFq5F1I2Q= X-Google-Smtp-Source: AK7set+TIlSZ5OeCvkkY0Usf8d+PeS3JaMJ43F0H8q1XbMWKisMqD7LxcWEdrSqUqptQ15CpENHnsA== X-Received: by 2002:a9d:618b:0:b0:69f:b37:c911 with SMTP id g11-20020a9d618b000000b0069f0b37c911mr1925644otk.17.1679235889093; Sun, 19 Mar 2023 07:24:49 -0700 (PDT) Received: from [192.168.0.14] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id p45-20020a4a95f0000000b0051fdb2cba97sm2892337ooi.7.2023.03.19.07.24.47 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 19 Mar 2023 07:24:48 -0700 (PDT) Message-ID: <004d743a-bc6e-3d06-6f18-2f4c237548bc@gmail.com> Date: Sun, 19 Mar 2023 11:24:54 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 To: ffmpeg-devel@ffmpeg.org References: <20230319141514.28134-1-michael@niedermayer.cc> <20230319141514.28134-2-michael@niedermayer.cc> Content-Language: en-US From: James Almer In-Reply-To: <20230319141514.28134-2-michael@niedermayer.cc> Subject: Re: [FFmpeg-devel] [PATCH 2/2] avfilter/vf_uspp: add AV_CODEC_FLAG_RECON_FRAME support X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/19/2023 11:15 AM, Michael Niedermayer wrote: > about 50% faster (based on command line fps) You should not allocate the 256 decoders if the encoder is a AV_CODEC_FLAG_RECON_FRAME one, as they will not be used. Doing so would save memory and speed up initialization. > > Signed-off-by: Michael Niedermayer > --- > libavfilter/vf_uspp.c | 41 ++++++++++++++++++++++++++++------------- > 1 file changed, 28 insertions(+), 13 deletions(-) > > diff --git a/libavfilter/vf_uspp.c b/libavfilter/vf_uspp.c > index f60eb230a2..9318410089 100644 > --- a/libavfilter/vf_uspp.c > +++ b/libavfilter/vf_uspp.c > @@ -231,16 +231,25 @@ static int filter_1phase(AVFilterContext *ctx, void *arg, int i, int nb_jobs) > return ret; > } > > - ret = avcodec_send_packet(p->avctx_dec[i], pkt); > - av_packet_unref(pkt); > - if (ret < 0) { > - av_log(p->avctx_dec[i], AV_LOG_ERROR, "Error sending a packet for decoding\n"); > - return ret; > - } > - ret = avcodec_receive_frame(p->avctx_dec[i], p->frame_dec[i]); > - if (ret < 0) { > - av_log(p->avctx_dec[i], AV_LOG_ERROR, "Error receiving a frame from decoding\n"); > - return ret; > + if (p->avctx_enc[i]->flags & AV_CODEC_FLAG_RECON_FRAME) { > + av_packet_unref(pkt); > + ret = avcodec_receive_frame(p->avctx_enc[i], p->frame_dec[i]); > + if (ret < 0) { > + av_log(p->avctx_dec[i], AV_LOG_ERROR, "Error receiving a frame from encoding\n"); > + return ret; > + } > + } else { > + ret = avcodec_send_packet(p->avctx_dec[i], pkt); > + av_packet_unref(pkt); > + if (ret < 0) { > + av_log(p->avctx_dec[i], AV_LOG_ERROR, "Error sending a packet for decoding\n"); > + return ret; > + } > + ret = avcodec_receive_frame(p->avctx_dec[i], p->frame_dec[i]); > + if (ret < 0) { > + av_log(p->avctx_dec[i], AV_LOG_ERROR, "Error receiving a frame from decoding\n"); > + return ret; > + } > } > > offset = (BLOCK-x1) + (BLOCK-y1) * p->frame_dec[i]->linesize[0]; > @@ -397,6 +406,10 @@ static int config_input(AVFilterLink *inlink) > avctx_enc->max_b_frames = 0; > avctx_enc->pix_fmt = inlink->format; > avctx_enc->flags = AV_CODEC_FLAG_QSCALE | AV_CODEC_FLAG_LOW_DELAY; > + if (enc->capabilities & AV_CODEC_CAP_ENCODER_RECON_FRAME) { > + avctx_enc->flags |= AV_CODEC_FLAG_RECON_FRAME; > + av_dict_set(&opts, "no_bitstream", "1", 0); > + } > avctx_enc->strict_std_compliance = FF_COMPLIANCE_EXPERIMENTAL; > avctx_enc->global_quality = 123; > avctx_dec->thread_count = > @@ -408,9 +421,11 @@ static int config_input(AVFilterLink *inlink) > av_assert0(avctx_enc->codec); > > > - ret = avcodec_open2(avctx_dec, dec, NULL); > - if (ret < 0) > - return ret; > + if (!(enc->capabilities & AV_CODEC_CAP_ENCODER_RECON_FRAME)) { > + ret = avcodec_open2(avctx_dec, dec, NULL); > + if (ret < 0) > + return ret; > + } > > if (!(uspp->frame[i] = av_frame_alloc())) > return AVERROR(ENOMEM); _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".