From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 27D7F44F7B for ; Tue, 13 Dec 2022 12:22:22 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6F88568BD5B; Tue, 13 Dec 2022 14:22:19 +0200 (EET) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0442E68BC91 for ; Tue, 13 Dec 2022 14:22:12 +0200 (EET) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20221213122209euoutp017ce6ddfdeb273e9965a18f13961ac3f9~wWbzeYRau2065320653euoutp01R for ; Tue, 13 Dec 2022 12:22:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20221213122209euoutp017ce6ddfdeb273e9965a18f13961ac3f9~wWbzeYRau2065320653euoutp01R DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1670934129; bh=EpppJWHRpH5y5w50B7ikpCGlDYXJS2UYIxS3ukR2V+I=; h=From:To:In-Reply-To:Subject:Date:References:From; b=sz5gVJ3Zs7wvkZJqMyvvE83U80CWIdiPVij/IL08T0Qsy+eQG3jeXGd1CFfjuSN5+ 4EMP8GdregxovanE4EdWeJEFIuBTduGMkGHC76dVtlmrETutcBKEK4bIEQF5InOvg4 QOPl/zlbVvN3HI1VoLFUx0eJhcQ3PKFHmUD8MPUo= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20221213122209eucas1p188359337c103a5924be3db59813d64ac~wWbzVucLx1496614966eucas1p1K for ; Tue, 13 Dec 2022 12:22:09 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id EE.ED.09549.17E68936; Tue, 13 Dec 2022 12:22:09 +0000 (GMT) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20221213122209eucas1p18ae7417283f277e16fdc7f887cd548bb~wWbzC0t9n1607816078eucas1p14 for ; Tue, 13 Dec 2022 12:22:09 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20221213122209eusmtrp216a8f1905ece2652cd5a9048f9119fd4~wWbzCRyIn2858428584eusmtrp2X for ; Tue, 13 Dec 2022 12:22:09 +0000 (GMT) X-AuditID: cbfec7f5-f47ff7000000254d-e5-63986e71c59c Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 07.53.08916.07E68936; Tue, 13 Dec 2022 12:22:08 +0000 (GMT) Received: from AMDN5164 (unknown [106.210.132.171]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20221213122208eusmtip2947bfd1d2d5fda1191db969b4280b6a6~wWbyxzDmm3059530595eusmtip24 for ; Tue, 13 Dec 2022 12:22:08 +0000 (GMT) From: "Dawid Kozinski/Multimedia \(PLT\) /SRPOL/Staff Engineer/Samsung Electronics" To: "'FFmpeg development discussions and patches'" In-Reply-To: Date: Tue, 13 Dec 2022 13:22:08 +0100 Message-ID: <003b01d90eed$852039e0$8f60ada0$@samsung.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQKjVush30qSSK7Gl6v7BBM1GKVN9wKbDru6Ac3FsssBfFK5rQHfTkADAcgEf4QCO4PiGKx47SZw Content-Language: pl X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrFIsWRmVeSWpSXmKPExsWy7djPc7qFeTOSDS6e57H49ukMswOjx59F m1kCGKO4bFJSczLLUov07RK4MhY92sRYsCe84vT9eWwNjLuDuxg5OSQETCSW3n3I3MXIxSEk sIJRoufeWxYIZxKTxLKP/5kgnIlMEqumrWOGabn27QwrRGI5o8TWtb1Q/W1MEo/69rKBVLEJ 5Ek8/rwWrENEwEeie/16VhCbU0BFYv2+12C2sECqxLHOqywgNouAqsSyxYsYQWxeAUuJXxeW sUDYghInZz4Bs5kF9CSenZoFZWtLLFv4GuoiBYmfT5exQuyKkuiesAOqRkTixqMWRoiaXg6J 9edkIWwXibcP3rBA2MISr45vYYewZST+75wP9DIHkF0scajfAcKskTj0Ix2iwlribeNxqImO Eq82TmOBKOGTuPFWEGIpn8SkbdOZIcK8Eh1tQhCmikRfpxhEo5TE02VzmCcwKs1C8uEsJB/O QvLhLCSfLGBkWcUonlpanJueWmycl1quV5yYW1yal66XnJ+7iRGYHE7/O/51B+OKVx/1DjEy cTAeYpTgYFYS4VXVmJYsxJuSWFmVWpQfX1Sak1p8iFGag0VJnHfFlI5kIYH0xJLU7NTUgtQi mCwTB6dUA5PmuWKXX9JvP+rqa/6JXPD87A1n5tcv3i686lc1+2zBz23XpxQUPY9fY7RYp/ni jpJX2+1szpptS2sTuxinbhpb/v7h89oNd9oSVRjZM5i41L8xdMxv8p2mIp5ruXApw/6z750u Jhxx/C35WyXbuslMgeHxl2uv92+doea3KVm5urNfZu/Vl7w9lY8UVy/61zuz8xurfkcZ+zqu 4wnGhvpCaleF+mc359bWbcxa3ODCm6dbHlveH+V2VuRgpIbhC17xx28z085NX19+L9Zki/cW pvjogFVR2daRKbey3xS21fG3psjVOp/KY+p5zs203zS2sa74tGn1gX1XJ0+af5C/z5x512Uz HqsP6s/PKLEUZyQaajEXFScCAP0AH8J9AwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrPLMWRmVeSWpSXmKPExsVy+t/xe7oFeTOSDSacNbf49ukMswOjx59F m1kCGKP0bIryS0tSFTLyi0tslaINLYz0DC0t9IxMLPUMjc1jrYxMlfTtbFJSczLLUov07RL0 Mn7vOM9asNOy4tCJ2YwNjF81uxg5OSQETCSufTvD2sXIxSEksJRR4sTdmywQCSmJpUsXMULY whJ/rnWxgdhCAi1MEp9b2EFsNoEcibWzJzKB2CICPhLd69dDDVrMJLFk7TpWkASngIrE+n2v wWxhgWSJB7cWgi1gEVCVWLYYYgGvgKXErwvLWCBsQYmTM5+A2cwCBhJLFv5igrC1JZYtfM0M cZCCxM+ny1ghFkdJdE/YAVUvInHjUQvjBEahWUhGzUIyahaSUbOQtCxgZFnFKJJaWpybnlts qFecmFtcmpeul5yfu4kRGBPbjv3cvINx3quPeocYmTgYDzFKcDArifCqakxLFuJNSaysSi3K jy8qzUktPsRoCvTbRGYp0eR8YFTmlcQbmhmYGpqYWRqYWpoZK4nzehZ0JAoJpCeWpGanphak FsH0MXFwSjUwJZXFR2/+88h4rc2F/u0aijo+H598uz71c0Q//wMt3Z8v703kYRC4FzwxIUKM iSu7MTZ9y8N2Uetv2/c2+Sy9quwSddn8RcVBIeFvU80DumzsPW5VC2e+X5lVJWr9Kn7C5MIs n2Y5u4DrP/pMFx5I27dqUkV4T8qSveezVffIGRyrsg04ErfmnLPzQ49dy6siXsSyJ/3YGfO5 5Ml9500PxArOhWvPMTXSe61StE3Sx+G36Nqrd0wn3jkmue6KvoYHu+uhtwLvnztytzg8i+2d 1Oe5JGOqh94rF81JXOb/HZKfs52du/uY5Rr5Xas1LHilpi+Q/Fm384N1R9+R2KRHrjsfnLvk kHV/RfDVLd0iSizFGYmGWsxFxYkAfVP0aBIDAAA= X-CMS-MailID: 20221213122209eucas1p18ae7417283f277e16fdc7f887cd548bb X-Msg-Generator: CA X-RootMTR: 20221024074233eucas1p125b43125cce202641bf48d0f174a39a1 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20221024074233eucas1p125b43125cce202641bf48d0f174a39a1 References: <20221024074221.217-1-d.kozinski@samsung.com> <5612537e-7e68-ee4c-17cd-30a42980915c@gmail.com> <20221027164524.GL4048421@pb2> Subject: Re: [FFmpeg-devel] [PATCH v14 9/9] avcodec/evc: Changes in Changelog and MAINTAINERS files X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: We made some changes in our EVC wrapper implementation and would like to submit new patches to patchwork, but it's still unclear to me how to deal with the MAINTAINERS file. = Should I leave the following lines: + libxevd.c Dawid Kozinski + libxeve.c, Dawid Kozinski + evc.c, evc.h Dawid Kozinski + evcdec.c Dawid Kozinski + evc_parser.c Dawid Kozinski or should I remove them? We are expecting a clear and consistent standpoint on this matter. -----Original Message----- From: ffmpeg-devel On Behalf Of Lynne Sent: pi=B1tek, 28 pa=BCdziernika 2022 23:08 To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH v14 9/9] avcodec/evc: Changes in Changelog and MAINTAINERS files Oct 27, 2022, 18:45 by michael@niedermayer.cc: > On Tue, Oct 25, 2022 at 01:17:15PM +0200, Lynne wrote: > >> >> >> >> Oct 24, 2022, 18:29 by jamrial@gmail.com: >> >> > On 10/24/2022 12:56 PM, Lynne wrote: >> > >> >> Oct 24, 2022, 09:42 by d.kozinski@samsung.com: >> >> >> >>> - Changelog update >> >>> - MAINTAINERS update >> >>> >> >>> Signed-off-by: Dawid Kozinski >> >>> --- >> >>> Changelog | 3 ++- >> >>> MAINTAINERS | 5 +++++ >> >>> 2 files changed, 7 insertions(+), 1 deletion(-) >> >>> >> >>> diff --git a/Changelog b/Changelog index ec9de1bd85..19e9ae3b1f = >> >>> 100644 >> >>> --- a/Changelog >> >>> +++ b/Changelog >> >>> @@ -45,6 +45,8 @@ version 5.1: >> >>> - remap_opencl filter >> >>> - added chromakey_cuda filter >> >>> - added bilateral_cuda filter >> >>> +- eXtra-fast Essential Video Encoder (XEVE) >> >>> +- eXtra-fast Essential Video Decoder (XEVD) >> >>> version 5.0: >> >>> @@ -92,7 +94,6 @@ version 5.0: >> >>> - anlmf audio filter >> >>> - IMF demuxer (experimental) >> >>> - >> >>> version 4.4: >> >>> - AudioToolbox output device >> >>> - MacCaption demuxer >> >>> diff --git a/MAINTAINERS b/MAINTAINERS index = >> >>> eebfa5cfb7..df8d8eca73 100644 >> >>> --- a/MAINTAINERS >> >>> +++ b/MAINTAINERS >> >>> @@ -200,6 +200,8 @@ Codecs: >> >>> libvpx* James Zern >> >>> libxavs.c Stefan Gehrer >> >>> libxavs2.c Huiwen Ren >> >>> + libxevd.c Dawid Kozinski >> >>> + libxeve.c, Dawid Kozinski >> >>> libzvbi-teletextdec.c Marton Balint >> >>> lzo.h, lzo.c Reimar Doeffinger >> >>> mdec.c Michael Niedermayer >> >>> @@ -420,6 +422,9 @@ Muxers/Demuxers: >> >>> dv.c Roman Shaposhnik >> >>> electronicarts.c Peter Ross >> >>> epafdec.c Paul B Mahol >> >>> + evc.c, evc.h Dawid Kozinski >> >>> + evcdec.c Dawid Kozinski >> >>> + evc_parser.c Dawid Kozinski >> >>> ffm* Baptiste Coudurier >> >>> flic.c Mike Melanson >> >>> flvdec.c Michael Niedermayer >> >>> >> >> >> >> Nak, that list is only for those with push access, and no other = >> >> changes may be made in the same patch. >> >> >> > >> > No, it's the other way around. Those in this list may be eligible for push access. >> > Being listed here gives them the right to NAK a patch made for a module they maintain, as well as their approval being (ideally) a requirement before making changes to it. >> > >> >> Nope. Michael will give anyone on the list push access. >> > > I have the feeling you dont trust me > if thats the issue, 2 lists will not fix that > I trust you more than others. But in this case, I simply don't understand. > The idea is that each developer who takes care of a bit of the code = > base (reviewing patches, approving them, fixing issues, adding = > features, ...) has the same rights as others. > That is git write, the list is the MAINAINERs list. > > Its not really true that everyone in that file has write access = > because some people where forgotten and never asked, some simply dont = > know git well enough, some explicitly said they do not want git write, = > some sent a lot of messy patches and gave me pause so i didnt offer it and they also didnt ask. > The list should be pretty close though, these are all exceptions not the rule. > The maintainers list used to be what jamrial said it was - an informal list of those with good knowledge on a piece of code to make a review, independent of whether they had push access or not. This is also how users/casual patch senders treated it as - they added their name if they felt like they would like to be consulted on. The list is always a bit outdated, and that's okay. You started treating it as a formal list of those with commit access, and it's been somewhat chaotic. Users still think it's an informal list, developers still think it's an informal list, only you seem to think it should be more formal. When a user submits a patch, I wonder if they're asking for push access or do they simply want to be consulted on for future patches? More often than not, it's the latter. I think there should be 2 lists, and if someone wants push access, they should just send a patch requesting it directly rather than using the vague maintainer term that no one pays attention to. If someone thinks they should have push access and ask, then they probably need it. The maintainers list could continue to be treated the same way it's been treated. > I fail to see the problem, btw. > A Problem would be if someoe does something that requires to remove = > his git write or that requires us to think about "should we close that write account" > (and yes i ignore here cases where core developers dont get along, = > thats not a issue for a maintainer/git write list) If we do not hit a = > situation where we consider closing an account then IMO we havnt = > really had a problem with giving write access out too liberal. > The other side OTOH certainly has occured, people sending patches over = > and over again, pinging over and over again and finally the patch is = > found to be ok and applied. That would point more toward too little = > write permission, or at least not the right person having write = > access, or a lack of incentives to review and apply patches > I really don't think push access should be removed from someone inactive, but I also don't think it should be given to someone with zero commits just because their patches never got a response, like with this patch. For such a large and wanted feature, it'll get merged by one of us eventually. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".