From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
by master.gitmailbox.com (Postfix) with ESMTPS id 1BB044B9E3
for <ffmpegdev@gitmailbox.com>; Tue, 1 Apr 2025 06:45:45 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E5B57687D04;
Tue, 1 Apr 2025 09:45:40 +0300 (EEST)
Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com
[210.118.77.12])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1BB30687C84
for <ffmpeg-devel@ffmpeg.org>; Tue, 1 Apr 2025 09:45:33 +0300 (EEST)
Received: from eucas1p1.samsung.com (unknown [182.198.249.206])
by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id
20250401064531euoutp02b0422f47b25208ccbdf29ae094231721~yHtsOhjGU3231132311euoutp02v
for <ffmpeg-devel@ffmpeg.org>; Tue, 1 Apr 2025 06:45:31 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com
20250401064531euoutp02b0422f47b25208ccbdf29ae094231721~yHtsOhjGU3231132311euoutp02v
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com;
s=mail20170921; t=1743489931;
bh=Ow3s/a+5U6NxRvIFFYee7zF7qGaeb3aHDXK0mlJswyo=;
h=From:To:In-Reply-To:Subject:Date:References:From;
b=gDm9moOLzYFzxfkG+AiOa4R0AsopX+rpvn9I6Hdqpob7fqSuWyvUlR+QGad2rcxdi
RVjWcr/5/3HbTfmUUQNH+XJCWTsq8mS3zcE6xAf8baouv+FrIRHkwPfM/XuFZi1ocD
lhXqKr7xhO/y2kLrS/DAdON2Xc4yyMoqPmkFFCks=
Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by
eucas1p2.samsung.com (KnoxPortal) with ESMTP id
20250401064531eucas1p2a5966ed36255d0a901d5a07b4f874169~yHtsByyf_2238522385eucas1p2-
for <ffmpeg-devel@ffmpeg.org>; Tue, 1 Apr 2025 06:45:31 +0000 (GMT)
Received: from eucas1p2.samsung.com ( [182.198.249.207]) by
eusmges2new.samsung.com (EUCPMTA) with SMTP id DB.70.20409.B8B8BE76; Tue, 1
Apr 2025 07:45:31 +0100 (BST)
Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by
eucas1p2.samsung.com (KnoxPortal) with ESMTPA id
20250401064531eucas1p2549b6777a6c96800888d3eeb9f2343db~yHtrjPZyI2238522385eucas1p2_
for <ffmpeg-devel@ffmpeg.org>; Tue, 1 Apr 2025 06:45:31 +0000 (GMT)
Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by
eusmtrp1.samsung.com (KnoxPortal) with ESMTP id
20250401064531eusmtrp135229fc122e8b8d7555d2dff3296ab13~yHtriyxKd1500115001eusmtrp1i
for <ffmpeg-devel@ffmpeg.org>; Tue, 1 Apr 2025 06:45:31 +0000 (GMT)
X-AuditID: cbfec7f4-c39fa70000004fb9-b5-67eb8b8b4609
Received: from eusmtip2.samsung.com ( [203.254.199.222]) by
eusmgms1.samsung.com (EUCPMTA) with SMTP id 17.8F.19920.B8B8BE76; Tue, 1
Apr 2025 07:45:31 +0100 (BST)
Received: from AMDN5164 (unknown [106.210.132.171]) by eusmtip2.samsung.com
(KnoxPortal) with ESMTPA id
20250401064530eusmtip2f921e7cdf0bbe5055eaefa4b65a2b773~yHtrRnJ3q2562225622eusmtip2l
for <ffmpeg-devel@ffmpeg.org>; Tue, 1 Apr 2025 06:45:30 +0000 (GMT)
From: "Dawid Kozinski/Multimedia \(PLT\) /SRPOL/Staff Engineer/Samsung
Electronics" <d.kozinski@samsung.com>
To: "'FFmpeg development discussions and patches'" <ffmpeg-devel@ffmpeg.org>
In-Reply-To: <DUZSPRMB0005E9D2805D5522C26A4C7B8FA72@DUZSPRMB0005.EURP250.PROD.OUTLOOK.COM>
Date: Tue, 1 Apr 2025 08:45:30 +0200
Message-ID: <002f01dba2d1$a9472c00$fbd58400$@samsung.com>
MIME-Version: 1.0
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQHF2oAu15rrUi+CwSmODPULzFghIQGhlNt9AYdc83qzoKPj0A==
Content-Language: pl
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrBIsWRmVeSWpSXmKPExsWy7djP87rd3a/TDfrOqFh8+3SG2YHR48+i
zSwBjFFcNimpOZllqUX6dglcGc+/drMVHBKpeDP/NHMD42KBLkZODgkBE4lZZw6ydjFycQgJ
rGCUuLlvHSOEM4lJYsK+GcwQzkQmiRWdn9hhWuZMOcoGkVjOKDG5+xeU08YksXH6LEaQKjaB
PInHn9cyg9giAj4S3evXs4LYnAJREjdab4LFhQUqJNZMX8/SxcjBwSKgIrHxHhNImFfAUuLp
zvtsELagxMmZT1hAbGYBeYntb+cwQxyhIPHz6TJWiPFOEh83/GKEqBGRuPGoBewFCYGJHBIr
f19igWhwkbjydgaULSzx6vgWqG9kJE5P7gG7QUKgWOJQvwOEWSNx6Ec6RIW1xNvG44wgYWYB
TYn1u/Qhwo4S8x60sUFU80nceCsIcQCfxKRt05khwrwSHW1CEKaKRF+nGESjlMTTZXOYJzAq
zULy4SwkH85C8skshLULGFlWMYqnlhbnpqcWG+WllusVJ+YWl+al6yXn525iBCaG0/+Of9nB
uPzVR71DjEwcjIcYJTiYlUR4I76+TBfiTUmsrEotyo8vKs1JLT7EKM3BoiTOu2h/a7qQQHpi
SWp2ampBahFMlomDU6qBqepZuPnXZYl+3d94JgbtE/Cz9DnI+tlrg8L7whR5H76U/J1p7f/3
bhL9MdNddj+b5vlVjDOWVc9b/VODWeZOXyHreg1Zq8xtOxtXrVpcru01V2x2zJzSJ4xJr1iL
Fy0+YKW+Kja2Jrc6qThnts9L358L7rq+tTg/tfP9vNCq+G9PZjRuLnv1cdliZotC76CMJczc
mf8+idS07WCMLXNsXRX9Ri5zZtKZ9A4BZ83HWeq/NP/Pb9bkmL2jO1TddvuxqOg9kWdFfi6p
a4yVdV0UnNPP4Kf97eGyXD1evR4v7xflDlEz3R27Hkcffba3YHZMyM+s3X1zlzZvTJPdW7CN
i3uZ5XL3vMTfUZcKCvcpsRRnJBpqMRcVJwIAlvKcWXsDAAA=
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrDLMWRmVeSWpSXmKPExsVy+t/xe7rd3a/TDe4dY7H49ukMswOjx59F
m1kCGKP0bIryS0tSFTLyi0tslaINLYz0DC0t9IxMLPUMjc1jrYxMlfTtbFJSczLLUov07RL0
Mp5/7WYrOCRS8Wb+aeYGxsUCXYycHBICJhJzphxlA7GFBJYySrzu1IWIS0ksXbqIEcIWlvhz
rQuohguopoVJYu+ZVewgCTaBHIm1sycygdgiAj4S3evXs0IU3WWUaNg8ASzBKRAlcaP1JjOI
LSxQJvF0XjfQJA4OFgEViY33wEp4BSwlnu68zwZhC0qcnPmEBaSEWUBPom0j2A3MAvIS29/O
YYa4R0Hi59NlrBBrnSQ+bvgFVSMiceNRC+MERqFZSCbNQpg0C8mkWUg6FjCyrGIUSS0tzk3P
LTbUK07MLS7NS9dLzs/dxAiMhm3Hfm7ewTjv1Ue9Q4xMHIyHGCU4mJVEeCO+vkwX4k1JrKxK
LcqPLyrNSS0+xGgK9NhEZinR5HxgPOaVxBuaGZgamphZGphamhkrifO6XT6fJiSQnliSmp2a
WpBaBNPHxMEp1cC0/d8yyecGgsrZvlbnFl4/McU0XMPX6G+o12L7dxUJ+YW3VKv3FWQx2KRf
VfhWKRBwc/6minCP/YzPON4t6pwZuYOT6X3lowsLr+f/f6h+jVGEl2vO7bMKeQLOmU1/9IxE
3JayxN28sS80+eNdk4P3lk6/tzr5t4JTbeT1y9f0j0e+8p/b39fxTtX9dMa//18XZDPmZ5yI
dnx9peCh903pg9nWDs9ezVR+N5N34qUlzzTUOy++uDz7do7pyReR9jlMucXr73yTrk87s6SB
7a50secEMV6PttiK3MchUlcPV600quwvT5Fcd8nprx//5hDrLsb9t/VPWT4L4nlrICFz9Vnz
oljb7y3zFy2fs3aXEktxRqKhFnNRcSIAtvjcUQ8DAAA=
X-CMS-MailID: 20250401064531eucas1p2549b6777a6c96800888d3eeb9f2343db
X-Msg-Generator: CA
X-RootMTR: 20250325075648eucas1p191d4e82df18831d08b9e7f09dbca5a20
X-EPHeader: CA
CMS-TYPE: 201P
X-CMS-RootMailID: 20250325075648eucas1p191d4e82df18831d08b9e7f09dbca5a20
References: <CGME20250325075648eucas1p191d4e82df18831d08b9e7f09dbca5a20@eucas1p1.samsung.com>
<20250325075643.1273491-1-d.kozinski@samsung.com>
<DUZSPRMB0005E9D2805D5522C26A4C7B8FA72@DUZSPRMB0005.EURP250.PROD.OUTLOOK.COM>
Subject: Re: [FFmpeg-devel] [PATCH v1] avcodec/evc_decoder: Fix pixel format
handling in export_stream_params function
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/002f01dba2d1$a9472c00$fbd58400$@samsung.com/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>
> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
> Andreas Rheinhardt
> Sent: wtorek, 25 marca 2025 09:18
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH v1] avcodec/evc_decoder: Fix pixel
format
> handling in export_stream_params function
>
> Dawid Kozinski:
> > Signed-off-by: Dawid Kozinski <d.kozinski@samsung.com>
> > ---
> > libavcodec/libxevd.c | 12 ++++++++----
> > 1 file changed, 8 insertions(+), 4 deletions(-)
> >
> > diff --git a/libavcodec/libxevd.c b/libavcodec/libxevd.c index
> > 520fdab7d8..483700c81e 100644
> > --- a/libavcodec/libxevd.c
> > +++ b/libavcodec/libxevd.c
> > @@ -152,16 +152,20 @@ static int export_stream_params(const XevdContext
> *xectx, AVCodecContext *avctx)
> > }
> > switch(color_space) {
> > case XEVD_CS_YCBCR400_10LE:
> > - avctx->pix_fmt = AV_PIX_FMT_GRAY10LE;
> > + case XEVD_CS_SET(XEVD_CF_YCBCR400, 10, 1): //
> XEVD_CS_YCBCR400_10BE
> > + avctx->pix_fmt = AV_PIX_FMT_GRAY10;
> > break;
> > case XEVD_CS_YCBCR420_10LE:
> > - avctx->pix_fmt = AV_PIX_FMT_YUV420P10LE;
> > + case XEVD_CS_SET(XEVD_CF_YCBCR420, 10, 1): //
> XEVD_CS_YCBCR420_10BE
> > + avctx->pix_fmt = AV_PIX_FMT_YUV420P10;
> > break;
> > case XEVD_CS_YCBCR422_10LE:
> > - avctx->pix_fmt = AV_PIX_FMT_YUV422P10LE;
> > + case XEVD_CS_SET(XEVD_CF_YCBCR422, 10, 1): //
> XEVD_CS_YCBCR422_10BE
> > + avctx->pix_fmt = AV_PIX_FMT_YUV422P10;
> > break;
> > case XEVD_CS_YCBCR444_10LE:
> > - avctx->pix_fmt = AV_PIX_FMT_YUV444P10LE;
> > + case XEVD_CS_SET(XEVD_CF_YCBCR444, 10, 1): //
> XEVD_CS_YCBCR444_10BE
> > + avctx->pix_fmt = AV_PIX_FMT_YUV444P10;
> > break;
> > default:
> > av_log(avctx, AV_LOG_ERROR, "Unknown color space\n");
>
> This patch maps both BE and LE formats to FFmpeg's corresponding native
> endian formats. This is wrong.
I've made fixes and I'd like to know if you have any further comments
regarding this change.
If not, I would kindly request that it be merged.
>
> - Andreas
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://protect2.fireeye.com/v1/url?k=f6892c97-970239ad-f688a7d8-
> 74fe4860008a-8439094af49407cb&q=1&e=cc888bcc-836f-4cab-acb4-
> a2034e7875c6&u=https%3A%2F%2Fffmpeg.org%2Fmailman%2Flistinfo%2Fffmp
> eg-devel
>
> To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org
> with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".