From: "Tomas Härdin" <git@haerdin.se>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: support of 2 fields in 1 AVPacket
Date: Mon, 05 Feb 2024 15:28:36 +0100
Message-ID: <000f2f8441e82016b7db84cc0c83dfa2210ab675.camel@haerdin.se> (raw)
In-Reply-To: <833aac91-f25b-4c63-ac4a-689894d2d337@gmail.com>
sön 2024-02-04 klockan 23:25 -0300 skrev James Almer:
> On 2/3/2024 7:00 AM, Tomas Härdin wrote:
> > fre 2024-02-02 klockan 16:55 +0100 skrev Jerome Martinez:
> > > Before this patch, the FFmpeg MXF parser correctly detects
> > > content
> > > with
> > > 2 fields in 1 AVPacket as e.g. interlaced 720x486 but the FFmpeg
> > > JPEG
> > > 2000 decoder reads the JPEG 2000 SIZ header without understanding
> > > that
> > > the indicated height is the height of 1 field only so overwrites
> > > the
> > > frame size info with e.g. 720x243, and also completely discards
> > > the
> > > second frame, which lead to the decoding of only half of the
> > > stored
> > > content as "progressive" 720x243 flagged interlaced.
> >
> > Is the decoder really the right place to do this? Surely this
> > happens
> > with more codecs than just j2k. Isnt it also a parser's job to do
> > this
> > kind of stuff?
>
> An AVParser must not split (or assemble) a packet in a form that is
> not
> meant to be encapsulated in a container.
This is two independent packets that are concatenated. A bsf changes
the bits, right? Whereas in this case no changes in the actual data is
necessary. Parsers are typically used to split raw essence into
packets, right? This is a similar case.
A use-case for this kind of splitting could be upping EditRate to
60000/1001 (SampleRate still being 60000/1001), allowing for field-
level editing. The resulting MXF would still be SEPARATE_FIELDS. This
is mode F1 in the table that pal posted.
This ties into the work Anton is doing on interlacing I suspect.
/Tomas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-02-05 14:28 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-02 15:55 Jerome Martinez
2024-02-03 10:00 ` Tomas Härdin
2024-02-03 10:51 ` Jerome Martinez
2024-02-03 19:58 ` Tomas Härdin
2024-02-03 20:04 ` Tomas Härdin
2024-02-04 0:20 ` Pierre-Anthony Lemieux
2024-02-05 0:19 ` Tomas Härdin
2024-02-15 15:02 ` Jerome Martinez
2024-02-16 0:02 ` Vittorio Giovara
2024-02-16 2:17 ` Kieran Kunhya
2024-02-18 23:14 ` Tomas Härdin
2024-02-19 11:08 ` Tomas Härdin
2024-02-19 11:19 ` Jerome Martinez
2024-02-16 10:32 ` Anton Khirnov
2024-02-18 23:43 ` Marton Balint
2024-02-19 8:22 ` Hendrik Leppkes
2024-02-19 16:14 ` Devin Heitmueller
2024-02-19 11:05 ` Tomas Härdin
2024-02-19 11:07 ` Tomas Härdin
2024-02-05 2:25 ` James Almer
2024-02-05 14:28 ` Tomas Härdin [this message]
2024-02-20 15:07 ` [FFmpeg-devel] [PATCH v2] " Jerome Martinez
2024-02-21 13:11 ` Tomas Härdin
2024-02-21 14:27 ` Jerome Martinez
2024-02-24 12:26 ` Tomas Härdin
2024-02-25 4:14 ` [FFmpeg-devel] [PATCH v3] " Jerome Martinez
2024-03-01 22:29 ` Tomas Härdin
2024-03-03 17:07 ` Jerome Martinez
2024-04-24 11:20 ` [FFmpeg-devel] [PATCH v2] " Jerome Martinez
2024-04-24 22:54 ` Tomas Härdin
2024-04-25 0:59 ` Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=000f2f8441e82016b7db84cc0c83dfa2210ab675.camel@haerdin.se \
--to=git@haerdin.se \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git