From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 03F134C1A7 for ; Wed, 30 Jul 2025 13:57:44 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id D706868C746; Wed, 30 Jul 2025 16:57:39 +0300 (EEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id B04FD68A9C5 for ; Wed, 30 Jul 2025 16:57:32 +0300 (EEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20250730135730euoutp028256b0b36e71a01c394acee1f313d0dc~XDBHgph3w2041920419euoutp02O for ; Wed, 30 Jul 2025 13:57:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20250730135730euoutp028256b0b36e71a01c394acee1f313d0dc~XDBHgph3w2041920419euoutp02O DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1753883850; bh=59bqZcLXzLJW5Mv0PSoL+baEKgpP3WLb+sNfYfOLwO4=; h=From:To:In-Reply-To:Subject:Date:References:From; b=jR+tNSjO9bBSQlVqKdk+rLMVIAwcdjvsHfvC7cCMGICORmQa0acaaRdTOAd6qhZMj jgwxMOQwKqyAD5DpHTa9xmMG+t4PVflKzTh7v78aTpc5S/c0QEIF0uX2kSJCVT0O+J esALQHI6ETz+aFPNxu0Rd09BhefBICX2UyV7cWtM= Received: from eusmtip1.samsung.com (unknown [203.254.199.221]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20250730135730eucas1p2287fe771501f9a9448af77e8917e2103~XDBHG4cxo1954019540eucas1p2i for ; Wed, 30 Jul 2025 13:57:30 +0000 (GMT) Received: from AMDN6874 (unknown [106.210.134.167]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20250730135730eusmtip1f60f4a6bf00152863ce5194d5d714cf1~XDBG72KFQ1092710927eusmtip16 for ; Wed, 30 Jul 2025 13:57:30 +0000 (GMT) From: To: "'FFmpeg development discussions and patches'" In-Reply-To: <20250729234036.GO29660@pb2> Date: Wed, 30 Jul 2025 15:57:29 +0200 Message-ID: <000801dc0159$e3f89af0$abe9d0d0$@samsung.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQFJ59gAV3Js+CRwPCuIWpUqEOy0iwH47leDAd68woQBFJpfhAGikxYWtTpsoVA= Content-Language: pl X-CMS-MailID: 20250730135730eucas1p2287fe771501f9a9448af77e8917e2103 X-Msg-Generator: CA X-RootMTR: 20250723111444eucas1p269c4d196163d9a6009467ae2727041fd X-EPHeader: CA X-CMS-RootMailID: 20250723111444eucas1p269c4d196163d9a6009467ae2727041fd References: <20250723111349.1032083-1-d.frankiewic@samsung.com> <20250728151559.GA29660@pb2> <000601dc0068$8b689d00$a239d700$@samsung.com> <20250729234036.GO29660@pb2> Subject: Re: [FFmpeg-devel] [PATCH] avcodec/apv: align APV color format support with latest liboapv version X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: -----Original Message----- From: ffmpeg-devel On Behalf Of Michael Niedermayer Sent: Wednesday, July 30, 2025 1:41 AM To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avcodec/apv: align APV color format support with latest liboapv version >On Tue, Jul 29, 2025 at 11:09:52AM +0200, d.frankiewic@samsung.com wrote: >> -----Original Message----- >> From: ffmpeg-devel On Behalf Of >> Michael Niedermayer >> Sent: Monday, July 28, 2025 5:16 PM >> To: FFmpeg development discussions and patches >>> >> Subject: Re: [FFmpeg-devel] [PATCH] avcodec/apv: align APV color >> format support with latest liboapv version >> >> >On Wed, Jul 23, 2025 at 01:13:49PM +0200, Dariusz Frankiewicz wrote: >> >> Signed-off-by: Dariusz Frankiewicz >> >> --- >> >> configure | 2 +- >> >> libavcodec/liboapvenc.c | 24 ++++++++++++++++++++++++ >> >> 2 files changed, 25 insertions(+), 1 deletion(-) >> >> >> >> diff --git a/configure b/configure >> >> index ac143f2fea..5527c20578 100755 >> >> --- a/configure >> >> +++ b/configure >> >> @@ -6983,7 +6983,7 @@ enabled jni && { [ $target_os = >> "android" ] && check_headers jni.h >> >> enabled ladspa && require_headers "ladspa.h dlfcn.h" >> >> enabled lcms2 && require_pkg_config lcms2 "lcms2 >= 2.13" >> lcms2.h cmsCreateContext >> >> enabled libaom && require_pkg_config libaom "aom >= 2.0.0" >> aom/aom_codec.h aom_codec_version >> >> -enabled liboapv && require_pkg_config liboapv "oapv >= >> 0.1.13.1" "oapv/oapv.h" oapve_encode >> >> +enabled liboapv && require_pkg_config liboapv "oapv >= >> 0.2.0.0" "oapv/oapv.h" oapve_encode > >> enabled libaribb24 && { check_pkg_config libaribb24 "aribb24 > >> 1.0.3" "aribb24/aribb24.h" arib_instance_new || >> >> { enabled gpl && require_pkg_config >> libaribb24 aribb24 "aribb24/aribb24.h" arib_instance_new; } || >> >> die "ERROR: libaribb24 requires >> >> version higher than 1.0.3 or --enable-gpl."; } diff --git >> >> a/libavcodec/liboapvenc.c b/libavcodec/liboapvenc.c index >> >> e62ef57d21..7f9fbf6929 100644 >> >> --- a/libavcodec/liboapvenc.c >> >> +++ b/libavcodec/liboapvenc.c >> >> @@ -102,9 +102,27 @@ static inline int get_color_format(enum >> AVPixelFormat pix_fmt) >> >> int cf = OAPV_CF_UNKNOWN; >> >> >> >> switch (pix_fmt) { >> >> + case AV_PIX_FMT_GRAY10: >> >> + cf = OAPV_CF_YCBCR400; >> >> + break; >> >> case AV_PIX_FMT_YUV422P10: >> >> cf = OAPV_CF_YCBCR422; >> >> break; >> >> + case AV_PIX_FMT_YUV422P12: >> >> + cf = OAPV_CF_YCBCR422; >> >> + break; >> >> + case AV_PIX_FMT_YUV444P10: >> >> + cf = OAPV_CF_YCBCR444; >> >> + break; >> >> + case AV_PIX_FMT_YUV444P12: >> >> + cf = OAPV_CF_YCBCR444; >> >> + break; >> >> + case AV_PIX_FMT_YUVA444P10: >> >> + cf = OAPV_CF_YCBCR4444; >> >> + break; >> >> + case AV_PIX_FMT_YUVA444P12: >> >> + cf = OAPV_CF_YCBCR4444; >> >> + break; >> >> default: >> >> av_assert0(cf != OAPV_CF_UNKNOWN); >> >> } >> > >> >does it make sense to continue supporting older versions ? >> >or is there no distribution that uses a version prior 0.2.0.0 ? >> > >> >thx >> >> Those colorspaces are supported from 0.2.0.0 version of OpenAPV so >> bumping version is required to make them work with library. >> There are no official distributions that are using OpenAPV old >> versions so it shouldn't be a problem. >> I think that we can fully switch to 0.2.0.0 as dependency. > >ok > >thx > > [...] >-- >Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > >I have never wished to cater to the crowd; for what I know they do not approve, and what they approve I do not know. -- Epicurus Can we merge this patch, or something need to be improved? _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".