From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A75E94636F for ; Thu, 15 Jun 2023 12:06:32 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8547068C516; Thu, 15 Jun 2023 15:06:31 +0300 (EEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A34B868C49F for ; Thu, 15 Jun 2023 15:06:24 +0300 (EEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20230615120623euoutp02417e2c01e893cc62e93d8522ccd32fd9~o06kK52GG1763317633euoutp02j for ; Thu, 15 Jun 2023 12:06:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20230615120623euoutp02417e2c01e893cc62e93d8522ccd32fd9~o06kK52GG1763317633euoutp02j DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1686830783; bh=zku8eFSEt4ptWeA3hBQOkya9MvGKLC9QDBgyPLPBy8Q=; h=From:To:In-Reply-To:Subject:Date:References:From; b=dpT68RPKI9G84Whrj3uBdkP1UBwh33npw7TRMm10+crmmNMD+2ulCavqZKf6D0z0b WdvA8VGWI49LdUUvRvAYdoWOUFn2cIAn7nER5hOHtoc1UelcFQYAALjXyvm8VnT4YZ NNPGyTT4iMYtZB7nZip4T7gzHWDZNbXWv19cADYo= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20230615120623eucas1p2d6e147c79b28fb3a867471cde204ae02~o06kFhmPK2846728467eucas1p2o for ; Thu, 15 Jun 2023 12:06:23 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 09.F4.11320.FBEFA846; Thu, 15 Jun 2023 13:06:23 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20230615120623eucas1p1844b748d02cb91f78625d17df9e18f9f~o06jz2fbg1014610146eucas1p1h for ; Thu, 15 Jun 2023 12:06:23 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20230615120623eusmtrp258322d39e7740172718001fbc75c3ea7~o06jzNwTu2153221532eusmtrp2M for ; Thu, 15 Jun 2023 12:06:23 +0000 (GMT) X-AuditID: cbfec7f4-993ff70000022c38-c8-648afebfb7fe Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 67.6F.10549.EBEFA846; Thu, 15 Jun 2023 13:06:22 +0100 (BST) Received: from AMDN5164 (unknown [106.120.40.55]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20230615120622eusmtip1f1a970f7839db002fdf9f561be85fef2~o06jiYWAi0418004180eusmtip1L for ; Thu, 15 Jun 2023 12:06:22 +0000 (GMT) From: "Dawid Kozinski/Multimedia \(PLT\) /SRPOL/Staff Engineer/Samsung Electronics" To: "'FFmpeg development discussions and patches'" In-Reply-To: Date: Thu, 15 Jun 2023 14:06:22 +0200 Message-ID: <000701d99f81$cd4c7d80$67e57880$@samsung.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQKH7qO7+v4kdXpHV44wqH1Cz1zk8gGZiIBTAaJGb18Cqi0aba3/9mdQ Content-Language: pl X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrBIsWRmVeSWpSXmKPExsWy7djPc7r7/3WlGLyZLmjx7dMZZgdGjz+L NrMEMEZx2aSk5mSWpRbp2yVwZZxd2sRe8N2wYv6WN+wNjIcNuhg5OSQETCTu3XzD2MXIxSEk sIJR4vK3qywQziQmiQcn+5khnIlMEjMOHWXqYuQAa5lzShqkW0hgOaNE/+IUiJoWJomeJXuZ QBJsAnkSjz+vZQaxRQR8JLrXr2cFsTkFbCV2z3gNZgsLFEj8e/qWDcRmEVCVePl+F1g9r4Cl xN8b1xkhbEGJkzOfsIDYzAJ6Es9OzYKytSWWLXzNDPGCgsTPp8tYQW4TEXCTmDhDA6JEROLG oxawzyQEZnJI/N79GareReLxoW9QtrDEq+Nb2CFsGYn/O+dD/VgscajfAcKskTj0Ix2iwlri beNxRgjbUeLIr2csECV8EjfeCkJs5ZOYtG06M0SYV6KjTQjCVJHo6xSDaJSSeLpsDvMERqVZ SD6cheTDWUg+nIXklQWMLKsYxVNLi3PTU4uN8lLL9YoTc4tL89L1kvNzNzECE8Ppf8e/7GBc /uqj3iFGJg7GQ4wSHMxKIrzLTnSlCPGmJFZWpRblxxeV5qQWH2KU5mBREufVtj2ZLCSQnliS mp2aWpBaBJNl4uCUamDamXv/x52Sp+ZuSpve2+8KVr3dPPutX/XE+zaxG3dout6//ZSh9sd9 jjvvvjCbbF4gMLHt6cslNkYnik/+ijk48ZUxt/Sh8A+CN87d35hezDtz89nk1x6Gf39etNVk uLt90Q+OpwZbtY4xf84T/Lc7afbil5qZwVG/Gv9xh5+sD6xU3nhuQuiFFUE70k50iz62TNm9 aQ5TikPUF9sElakiucxqfee7sz7ODPlnYrBaVX5P9JyUw/q/LBYE/dHztGXhnXCFKUvq2Wsb K9GFCzO/nks5eOe6+Le+X490VvR4rUjYvYpvzfaHxtJrTkfV6O1QO33jk8+WdWkmE5L3t4j+ mXJlymuHX2nHfuz7/dPLokaJpTgj0VCLuag4EQAiTCbZewMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrHLMWRmVeSWpSXmKPExsVy+t/xu7r7/nWlGDy5Z27x7dMZZgdGjz+L NrMEMEbp2RTll5akKmTkF5fYKkUbWhjpGVpa6BmZWOoZGpvHWhmZKunb2aSk5mSWpRbp2yXo ZSw83c5YcEKhYu2bE2wNjOckuhg5OCQETCTmnJLuYuTiEBJYyihxbudGti5GTqC4lMTSpYsY IWxhiT/XutggipqYJP4tms8MkmATyJFYO3siE4gtIuAj0b1+PStE0R1GiTu9U9lBEpwCthK7 Z7xmBbGFBfIkup5tAWtmEVCVePl+F5jNK2Ap8ffGdUYIW1Di5MwnLCA2s4CBxJKFv5ggbG2J ZQtfM0NcpCDx8+kyVpAPRATcJCbO0IAoEZG48aiFcQKj0Cwkk2YhmTQLyaRZSFoWMLKsYhRJ LS3OTc8tNtQrTswtLs1L10vOz93ECIyIbcd+bt7BOO/VR71DjEwcjIcYJTiYlUR4l53oShHi TUmsrEotyo8vKs1JLT7EaAr02kRmKdHkfGBM5pXEG5oZmBqamFkamFqaGSuJ83oWdCQKCaQn lqRmp6YWpBbB9DFxcEo1MMW/mp5VfjxeLLOV5XHbkve/blVy9O5lqD4isNQ5qVrf8/7yfoVD J+8sFstxVJ/drp6qaJj6Y07brONCj8/xHSzVdjujJL3H//R35ppNuS0vVkouuL9L3Vwz7oWT q4nLL55VnHJO33Y4BNxN2TJNM3fOiRe7zmhomF6f6n9TJrzzmrXvO+slX/0Wd/7eyHkhMqr2 271N3R+3nVrpphez4qQHz2ZLLiXHWrnmLTZyB1c9LOc5w5vDpZ+YsUp28W9F3dsJmlKbKy/s /87LUfzk/4r2E8ULeNdMTniZt9qipNfyi8ejPaIr8zof7Hl9IXpH+KSVe9oWzLi9/Xf/OqaN 7xTMTvziTm2qNpKYp3erdbMSS3FGoqEWc1FxIgBiqfgUEQMAAA== X-CMS-MailID: 20230615120623eucas1p1844b748d02cb91f78625d17df9e18f9f X-Msg-Generator: CA X-RootMTR: 20230612123038eucas1p1c481a42fcbf3ae39b3dd756dcedc64e6 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20230612123038eucas1p1c481a42fcbf3ae39b3dd756dcedc64e6 References: <20230612123027.1865-1-d.kozinski@samsung.com> <20230614002326.GK1391451@pb2> Subject: Re: [FFmpeg-devel] [PATCH v24 6/9] avformat/mov_muxer: Extended MOV muxer to handle EVC video content X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of James > Almer > Sent: =B6roda, 14 czerwca 2023 03:00 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v24 6/9] avformat/mov_muxer: Extended > MOV muxer to handle EVC video content > = > On 6/13/2023 9:23 PM, Michael Niedermayer wrote: > > On Mon, Jun 12, 2023 at 02:30:27PM +0200, Dawid Kozinski wrote: > >> - Changes in mov_write_video_tag function to handle EVC elementary > >> stream > >> - Provided structure EVCDecoderConfigurationRecord that specifies the > >> decoder configuration information for ISO/IEC 23094-1 video content > >> > >> Signed-off-by: Dawid Kozinski > >> --- > >> libavformat/Makefile | 2 +- > >> libavformat/evc.c | 422 > ++++++++++++++++++++++++++++++++++++++++ > >> libavformat/evc.h | 44 +++++ > >> libavformat/isom_tags.c | 2 + > >> libavformat/movenc.c | 33 ++++ > >> 5 files changed, 502 insertions(+), 1 deletion(-) > >> create mode 100644 libavformat/evc.c > >> create mode 100644 libavformat/evc.h > >> > >> diff --git a/libavformat/Makefile b/libavformat/Makefile index > >> 6e4231fda2..d3503196e3 100644 > >> --- a/libavformat/Makefile > >> +++ b/libavformat/Makefile > >> @@ -364,7 +364,7 @@ OBJS-$(CONFIG_MOV_DEMUXER) +=3D mov.o > mov_chan.o mov_esds.o \ > >> OBJS-$(CONFIG_MOV_MUXER) +=3D movenc.o av1.o avc.o hevc.o > vpcc.o \ > >> movenchint.o mov_chan.o rtp.o \ > >> movenccenc.o movenc_ttml.o rawutils.o \ > >> - dovi_isom.o > >> + dovi_isom.o evc.o > >> OBJS-$(CONFIG_MP2_MUXER) +=3D rawenc.o > >> OBJS-$(CONFIG_MP3_DEMUXER) +=3D mp3dec.o replaygain.o > >> OBJS-$(CONFIG_MP3_MUXER) +=3D mp3enc.o rawenc.o id3v2enc.o > >> diff --git a/libavformat/evc.c b/libavformat/evc.c new file mode > >> 100644 index 0000000000..431cb107e3 > >> --- /dev/null > >> +++ b/libavformat/evc.c > >> @@ -0,0 +1,422 @@ > >> +/* > >> + * EVC helper functions for muxers > >> + * Copyright (c) 2022 Dawid Kozinski > >> + * > >> + * This file is part of FFmpeg. > >> + * > >> + * FFmpeg is free software; you can redistribute it and/or > >> + * modify it under the terms of the GNU Lesser General Public > >> + * License as published by the Free Software Foundation; either > >> + * version 2.1 of the License, or (at your option) any later version. > >> + * > >> + * FFmpeg is distributed in the hope that it will be useful, > >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of > >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > GNU > >> + * Lesser General Public License for more details. > >> + * > >> + * You should have received a copy of the GNU Lesser General Public > >> + * License along with FFmpeg; if not, write to the Free Software > >> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA > >> +02110-1301 USA */ > > > > [...] > > > >> + nalu_type =3D ff_evc_get_nalu_type(data, bytes_to_read, pb); > > > > functions shared between libavcodec and libavformat need an > > av*/avpriv* prefix otherwise linking will fail with shared libs as ff* > > isnt exported > = > It's small enough that it can go in the header instead. That way we save one > unnecessary exported symbol. Same with ff_evc_read_nal_unit_length(). Done (v26) > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://protect2.fireeye.com/v1/url?k=3D5297bb74-33ec11fc-5296303b- > 74fe4860018a-ffe4f237f8ba290d&q=3D1&e=3D351d993e-ef97-4840-aeb8- > 4fd043541ed8&u=3Dhttps%3A%2F%2Fffmpeg.org%2Fmailman%2Flistinfo%2Fffmp > eg-devel > = > To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org > with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".