From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E8C5C46321 for ; Thu, 15 Jun 2023 09:41:11 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2F1B568C49B; Thu, 15 Jun 2023 12:41:10 +0300 (EEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id ADA4668C306 for ; Thu, 15 Jun 2023 12:41:03 +0300 (EEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20230615094101euoutp0214a359b1b62d4f289703a84d38776f8b~oy7pZOr-e2117921179euoutp02e for ; Thu, 15 Jun 2023 09:41:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20230615094101euoutp0214a359b1b62d4f289703a84d38776f8b~oy7pZOr-e2117921179euoutp02e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1686822061; bh=qyzUDuR4Es1xY9Ly8huzfUW7v9UZ0p4jdFtnFOiXfv8=; h=From:To:In-Reply-To:Subject:Date:References:From; b=JdVPG3NJ7PejXAzIWGgSQS7RBkLvhuQJtmHgXJtW9EjI8r++KxT36368J7+4Fm2va dSntPohzQWiHeq/poMGJRTQiGjncKwIW2r0c6A9oM7t6/RLVKVuOzkBmXaqZKv8/qm LHjw6i/N0CWsONvgwL54frDWKChfB9s5YiTPKHj8= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20230615094101eucas1p28a14e3a2a1a5997beb1b26d468f7bbfc~oy7pM-8Jp2989929899eucas1p2z for ; Thu, 15 Jun 2023 09:41:01 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 9D.3B.37758.DACDA846; Thu, 15 Jun 2023 10:41:01 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20230615094100eucas1p247a3e96ba058f270d7bbf86049140867~oy7ou9Zj32995429954eucas1p2y for ; Thu, 15 Jun 2023 09:41:00 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20230615094100eusmtrp163fbb3921445d039abb52373cb970ca6~oy7oufyIQ3220632206eusmtrp1h for ; Thu, 15 Jun 2023 09:41:00 +0000 (GMT) X-AuditID: cbfec7f5-7ffff7000002937e-e2-648adcad4196 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id DB.F8.10549.CACDA846; Thu, 15 Jun 2023 10:41:00 +0100 (BST) Received: from AMDN5164 (unknown [106.120.40.55]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20230615094100eusmtip1e5a93b0215aeed22b2ec6866cc8a7cc9~oy7ofKGQa1944119441eusmtip1V for ; Thu, 15 Jun 2023 09:41:00 +0000 (GMT) From: "Dawid Kozinski/Multimedia \(PLT\) /SRPOL/Staff Engineer/Samsung Electronics" To: "'FFmpeg development discussions and patches'" In-Reply-To: <20230614002326.GK1391451@pb2> Date: Thu, 15 Jun 2023 11:41:00 +0200 Message-ID: <000501d99f6d$7e8cd230$7ba67690$@samsung.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQKH7qO7+v4kdXpHV44wqH1Cz1zk8gGZiIBTAaJGb1+uFR5rYA== Content-Language: pl X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrBIsWRmVeSWpSXmKPExsWy7djPc7pr73SlGBzuErf49ukMswOjx59F m1kCGKO4bFJSczLLUov07RK4Mo6tySt4rF/xZP9/lgbGrXpdjJwcEgImEovePGLsYuTiEBJY wSjx7+JaFghnEpPEwt4rrBDORCaJ/h9/GWFa9q5rg2pZzihx+t8bZginhUmi7cZxsCo2gTyJ x5/XMoPYIgI+Et3r17OC2JwC2hJNnZvBbGGBAol/T9+ygdgsAqoSS2ZPAuvlFbCUOHTwATOE LShxcuYTFhCbWUBP4tmpWVC2tsSyha+ZIS5SkPj5dBkrxC4nifb73WwQNSISNx61QF09kUNi 8b+yLkYOINtF4sIWeYiwsMSr41vYIWwZidOTe1ggSoolDvU7QJg1Eod+pENUWEu8bTwONdBR 4sivZ1DVfBI33gpC7OSTmLRtOjNEmFeio00IwlSR6OsUg2iUkni6bA7zBEalWUgenIXkwVlI HpyF5JEFjCyrGMVTS4tz01OLjfNSy/WKE3OLS/PS9ZLzczcxAhPD6X/Hv+5gXPHqo94hRiYO xkOMEhzMSiK8y050pQjxpiRWVqUW5ccXleakFh9ilOZgURLn1bY9mSwkkJ5YkpqdmlqQWgST ZeLglGpgWpPcOKHk8/mC9rWsD14m/58ZamZbsMir6856g+o7yj43FKPX+S4/snTVlbmr9sy5 1pKldSnTXuR8yr75S9Xfs51exmilf3q6eXN1xoVLe9Qb4iUfcudmaviYh3J0zRJvSr1iOO1D 2KJFn4TC/kn8SMwNOlShFCUvf7Be47ZojXtbY9EzW51vn7pmSl+7vjlUbi9nUsXpg15Sx9Sn pXHr8POWeiSvO3Pm+Y63rMnbHU4VfpJ4ZPJz4t41iadreVk+3Bd9HzflTk+6rKpyzamNPncY 73Z8WMPHF/r57DHfz3rnwx/xRX00TXpbU3ZuFtMOCdftRs6T+e5+vFJxdoXu5W32CycyiQgf 2GmyJSXFTYmlOCPRUIu5qDgRAP3uNZZ7AwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrHLMWRmVeSWpSXmKPExsVy+t/xu7pr7nSlGDRvNLH49ukMswOjx59F m1kCGKP0bIryS0tSFTLyi0tslaINLYz0DC0t9IxMLPUMjc1jrYxMlfTtbFJSczLLUov07RL0 MlZeUS54KVfxZPZBxgbGr2JdjJwcEgImEnvXtTF2MXJxCAksZZRY27KADSIhJbF06SJGCFtY 4s+1LrC4kEATk8SPz54gNptAjsTa2ROZQGwRAR+J7vXrWSEGrWaUmLf9HjNIglNAW6KpczMr iC0skCfR9WwLWJxFQFViyexJYAt4BSwlDh18wAxhC0qcnPmEBcRmFjCQWLLwFxOErS2xbOFr ZoiDFCR+Pl3GCrHYSaL9fjcbRI2IxI1HLYwTGIVmIRk1C8moWUhGzULSsoCRZRWjSGppcW56 brGhXnFibnFpXrpecn7uJkZgRGw79nPzDsZ5rz7qHWJk4mA8xCjBwawkwrvsRFeKEG9KYmVV alF+fFFpTmrxIUZToN8mMkuJJucDYzKvJN7QzMDU0MTM0sDU0sxYSZzXs6AjUUggPbEkNTs1 tSC1CKaPiYNTqoFpVpaLxsUCY1WGXTZa/hZXu3m1jQRZbj+S2KVkXc+u01NzmOelM6+L8NJr s8PvOszYuW/iN2nTW4qTY7czXTmmKW/SE3/7X8/3PWELX/J+4N3Ldcefw2etrMKrjQvPnTJv ZuL/Ffvg3F2T7p43Z44KPwn/1h8UePqN7szH10Xa65gPLDU2YvjHe/jFQk4xP94PcX5821wj bLm95VZMKb1j8+DmT8UFguVcbzuen9LdcUH/yPFNdhfLuM5+TCq3+dC7o+BkLs9xqSqDLbu0 eKUXvivurVS8Ic+lq/fQ1ot73QId30mrj2xp0zN52BIx6+CTvbwPMg04ZCMbf5sXsaQxp95k Tt92UmQDY+eSs/eUWIozEg21mIuKEwFGrZKXEQMAAA== X-CMS-MailID: 20230615094100eucas1p247a3e96ba058f270d7bbf86049140867 X-Msg-Generator: CA X-RootMTR: 20230612123038eucas1p1c481a42fcbf3ae39b3dd756dcedc64e6 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20230612123038eucas1p1c481a42fcbf3ae39b3dd756dcedc64e6 References: <20230612123027.1865-1-d.kozinski@samsung.com> <20230614002326.GK1391451@pb2> Subject: Re: [FFmpeg-devel] [PATCH v24 6/9] avformat/mov_muxer: Extended MOV muxer to handle EVC video content X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of > Michael Niedermayer > Sent: =B6roda, 14 czerwca 2023 02:23 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH v24 6/9] avformat/mov_muxer: Extended > MOV muxer to handle EVC video content > = > On Mon, Jun 12, 2023 at 02:30:27PM +0200, Dawid Kozinski wrote: > > - Changes in mov_write_video_tag function to handle EVC elementary > > stream > > - Provided structure EVCDecoderConfigurationRecord that specifies the > > decoder configuration information for ISO/IEC 23094-1 video content > > > > Signed-off-by: Dawid Kozinski > > --- > > libavformat/Makefile | 2 +- > > libavformat/evc.c | 422 ++++++++++++++++++++++++++++++++++++++++ > > libavformat/evc.h | 44 +++++ > > libavformat/isom_tags.c | 2 + > > libavformat/movenc.c | 33 ++++ > > 5 files changed, 502 insertions(+), 1 deletion(-) create mode 100644 > > libavformat/evc.c create mode 100644 libavformat/evc.h > > > > diff --git a/libavformat/Makefile b/libavformat/Makefile index > > 6e4231fda2..d3503196e3 100644 > > --- a/libavformat/Makefile > > +++ b/libavformat/Makefile > > @@ -364,7 +364,7 @@ OBJS-$(CONFIG_MOV_DEMUXER) +=3D mov.o > mov_chan.o mov_esds.o \ > > OBJS-$(CONFIG_MOV_MUXER) +=3D movenc.o av1.o avc.o hev= c.o > vpcc.o \ > > movenchint.o mov_chan.o rtp.o \ > > movenccenc.o movenc_ttml.o rawutils.o \ > > - dovi_isom.o > > + dovi_isom.o evc.o > > OBJS-$(CONFIG_MP2_MUXER) +=3D rawenc.o > > OBJS-$(CONFIG_MP3_DEMUXER) +=3D mp3dec.o replaygain.o > > OBJS-$(CONFIG_MP3_MUXER) +=3D mp3enc.o rawenc.o id3v2enc.o > > diff --git a/libavformat/evc.c b/libavformat/evc.c new file mode > > 100644 index 0000000000..431cb107e3 > > --- /dev/null > > +++ b/libavformat/evc.c > > @@ -0,0 +1,422 @@ > > +/* > > + * EVC helper functions for muxers > > + * Copyright (c) 2022 Dawid Kozinski > > + * > > + * This file is part of FFmpeg. > > + * > > + * FFmpeg is free software; you can redistribute it and/or > > + * modify it under the terms of the GNU Lesser General Public > > + * License as published by the Free Software Foundation; either > > + * version 2.1 of the License, or (at your option) any later version. > > + * > > + * FFmpeg is distributed in the hope that it will be useful, > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > > + * Lesser General Public License for more details. > > + * > > + * You should have received a copy of the GNU Lesser General Public > > + * License along with FFmpeg; if not, write to the Free Software > > + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA > > +02110-1301 USA */ > = > [...] > = > > + nalu_type =3D ff_evc_get_nalu_type(data, bytes_to_read, pb); > = > functions shared between libavcodec and libavformat need an av*/avpriv* > prefix otherwise linking will fail with shared libs as ff* isnt exported > = Michael, thank you for your code review. I've just pushed new patchset (v25) that fixes prefixes for functions shared between libavcoded and libavformat. > = > [...] > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > = > Many that live deserve death. And some that die deserve life. Can you give it to > them? Then do not be too eager to deal out death in judgement. For even the > very wise cannot see all ends. -- Gandalf _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".