[FFmpeg-devel] [PATCH] libavcodec/libxev: Update EVC codec naming

[FFmpeg-devel] [PATCH] libavcodec/libxev: Update EVC codec naming

[Dariusz Frankiewicz]

Make consistency between encoder and decoder implementation.

Signed-off-by: Dariusz Frankiewicz <d.frankiewic@samsung.com>
---
 libavcodec/libxevd.c | 2 +-
 libavcodec/libxeve.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/libavcodec/libxevd.c b/libavcodec/libxevd.c
index 520fdab7d8..51303ec71d 100644
--- a/libavcodec/libxevd.c
+++ b/libavcodec/libxevd.c
@@ -469,7 +469,7 @@ static av_cold int libxevd_close(AVCodecContext *avctx)
 }
 
 const FFCodec ff_libxevd_decoder = {
-    .p.name             = "evc",
+    .p.name             = "libxevd",
     CODEC_LONG_NAME("EVC / MPEG-5 Essential Video Coding (EVC)"),
     .p.type             = AVMEDIA_TYPE_VIDEO,
     .p.id               = AV_CODEC_ID_EVC,
diff --git a/libavcodec/libxeve.c b/libavcodec/libxeve.c
index 1d9972619d..40eab08ef2 100644
--- a/libavcodec/libxeve.c
+++ b/libavcodec/libxeve.c
@@ -600,7 +600,7 @@ static const FFCodecDefault libxeve_defaults[] = {
 
 const FFCodec ff_libxeve_encoder = {
     .p.name             = "libxeve",
-    .p.long_name        = NULL_IF_CONFIG_SMALL("libxeve MPEG-5 EVC"),
+    CODEC_LONG_NAME("EVC / MPEG-5 Essential Video Coding (EVC)"),
     .p.type             = AVMEDIA_TYPE_VIDEO,
     .p.id               = AV_CODEC_ID_EVC,
     .init               = libxeve_init,
-- 
2.25.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] libavcodec/libxev: Update EVC codec naming

[Andreas Rheinhardt]

Dariusz Frankiewicz:
> Make consistency between encoder and decoder implementation.
> 
> Signed-off-by: Dariusz Frankiewicz <d.frankiewic@samsung.com>
> ---
>  libavcodec/libxevd.c | 2 +-
>  libavcodec/libxeve.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/libavcodec/libxevd.c b/libavcodec/libxevd.c
> index 520fdab7d8..51303ec71d 100644
> --- a/libavcodec/libxevd.c
> +++ b/libavcodec/libxevd.c
> @@ -469,7 +469,7 @@ static av_cold int libxevd_close(AVCodecContext *avctx)
>  }
>  
>  const FFCodec ff_libxevd_decoder = {
> -    .p.name             = "evc",
> +    .p.name             = "libxevd",

The codec name is used in avcodec_find_decoder_by_name() (and also in
the ffmpeg cli tool). Changing it causes breakage.

>      CODEC_LONG_NAME("EVC / MPEG-5 Essential Video Coding (EVC)"),
>      .p.type             = AVMEDIA_TYPE_VIDEO,
>      .p.id               = AV_CODEC_ID_EVC,
> diff --git a/libavcodec/libxeve.c b/libavcodec/libxeve.c
> index 1d9972619d..40eab08ef2 100644
> --- a/libavcodec/libxeve.c
> +++ b/libavcodec/libxeve.c
> @@ -600,7 +600,7 @@ static const FFCodecDefault libxeve_defaults[] = {
>  
>  const FFCodec ff_libxeve_encoder = {
>      .p.name             = "libxeve",
> -    .p.long_name        = NULL_IF_CONFIG_SMALL("libxeve MPEG-5 EVC"),
> +    CODEC_LONG_NAME("EVC / MPEG-5 Essential Video Coding (EVC)"),
>      .p.type             = AVMEDIA_TYPE_VIDEO,
>      .p.id               = AV_CODEC_ID_EVC,
>      .init               = libxeve_init,

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] libavcodec/libxev: Update EVC codec naming

[Dariusz Frankiewicz/Media Platform (PLT) /SRPOL/Engineer/삼성전자]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
> Andreas Rheinhardt
> Sent: Monday, June 10, 2024 12:52 PM
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH] libavcodec/libxev: Update EVC codec
> naming
> 
> Dariusz Frankiewicz:
> > Make consistency between encoder and decoder implementation.
> >
> > Signed-off-by: Dariusz Frankiewicz <d.frankiewic@samsung.com>
> > ---
> >  libavcodec/libxevd.c | 2 +-
> >  libavcodec/libxeve.c | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/libavcodec/libxevd.c b/libavcodec/libxevd.c index
> > 520fdab7d8..51303ec71d 100644
> > --- a/libavcodec/libxevd.c
> > +++ b/libavcodec/libxevd.c
> > @@ -469,7 +469,7 @@ static av_cold int libxevd_close(AVCodecContext
> > *avctx)  }
> >
> >  const FFCodec ff_libxevd_decoder = {
> > -    .p.name             = "evc",
> > +    .p.name             = "libxevd",
> 
> The codec name is used in avcodec_find_decoder_by_name() (and also in the
> ffmpeg cli tool). Changing it causes breakage.
> 

I tested EVC encoding and decoding and it works correctly after this change.
It looks that maybe in some implementation cases it may be problematic.

Buy anyway I will remove this change and keep only macro usage change.


> >      CODEC_LONG_NAME("EVC / MPEG-5 Essential Video Coding (EVC)"),
> >      .p.type             = AVMEDIA_TYPE_VIDEO,
> >      .p.id               = AV_CODEC_ID_EVC,
> > diff --git a/libavcodec/libxeve.c b/libavcodec/libxeve.c index
> > 1d9972619d..40eab08ef2 100644
> > --- a/libavcodec/libxeve.c
> > +++ b/libavcodec/libxeve.c
> > @@ -600,7 +600,7 @@ static const FFCodecDefault libxeve_defaults[] = {
> >
> >  const FFCodec ff_libxeve_encoder = {
> >      .p.name             = "libxeve",
> > -    .p.long_name        = NULL_IF_CONFIG_SMALL("libxeve MPEG-5 EVC"),
> > +    CODEC_LONG_NAME("EVC / MPEG-5 Essential Video Coding (EVC)"),
> >      .p.type             = AVMEDIA_TYPE_VIDEO,
> >      .p.id               = AV_CODEC_ID_EVC,
> >      .init               = libxeve_init,
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://protect2.fireeye.com/v1/url?k=9299ff12-f312ea2b-9298745d-
> 000babffae10-91beb1eef5249c9b&q=1&e=aaa2678c-be48-4f85-bd88-
> 7e727cab48c9&u=https%3A%2F%2Fffmpeg.org%2Fmailman%2Flistinfo%2Fffmp
> eg-devel
> 
> To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org
> with subject "unsubscribe".

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".