From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C2A0046345 for ; Thu, 15 Jun 2023 07:20:50 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0F5C268C458; Thu, 15 Jun 2023 10:20:48 +0300 (EEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9C1FA68C339 for ; Thu, 15 Jun 2023 10:20:41 +0300 (EEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20230615072040euoutp0229d0cd7870b64b12ae4f7c23457b5089~oxBGNKibu2562425624euoutp02_ for ; Thu, 15 Jun 2023 07:20:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20230615072040euoutp0229d0cd7870b64b12ae4f7c23457b5089~oxBGNKibu2562425624euoutp02_ DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1686813640; bh=IUV+p7JPSnoqXRSBvsNm6soMU46boLqVQqSlKzvAml4=; h=From:To:In-Reply-To:Subject:Date:References:From; b=tMW03Q9k2/xdwLViWNZ9PF01kltwq5c0vKQORkSPZ/sMpAmiVmgO8gMtzUpNjsJYh gXxh6SCiOSUhRBKtYUdOBH6jtg/VIU5a2DVh7bd6tAHnJSBvoUOIwxwLHbdZqZcemT CqiLunti226vGqC1PdsfwkXGYHor7jQdNt2iUrGs= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20230615072040eucas1p208162dc1835a8f41bcb42c10aa6e0131~oxBGICoYo0721607216eucas1p20 for ; Thu, 15 Jun 2023 07:20:40 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id D9.66.42423.7CBBA846; Thu, 15 Jun 2023 08:20:39 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20230615072039eucas1p11ae5ffa1e5d6b0a6301640a4b0db2894~oxBF4ZgjU2565925659eucas1p1B for ; Thu, 15 Jun 2023 07:20:39 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20230615072039eusmtrp2963ee9e94dd2ae70b7c23cb3e7a762a7~oxBF3YPe61395413954eusmtrp2e for ; Thu, 15 Jun 2023 07:20:39 +0000 (GMT) X-AuditID: cbfec7f2-a51ff7000002a5b7-69-648abbc762ec Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 9F.1F.10549.7CBBA846; Thu, 15 Jun 2023 08:20:39 +0100 (BST) Received: from AMDN5164 (unknown [106.120.40.55]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20230615072039eusmtip1c26942fc80ac3ccd87f3511b9f6dd99b~oxBFoO4at2728527285eusmtip1j for ; Thu, 15 Jun 2023 07:20:39 +0000 (GMT) From: "Dawid Kozinski/Multimedia \(PLT\) /SRPOL/Staff Engineer/Samsung Electronics" To: "'FFmpeg development discussions and patches'" In-Reply-To: Date: Thu, 15 Jun 2023 09:20:38 +0200 Message-ID: <000001d99f59$e31ec2d0$a95c4870$@samsung.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQKH7qO7+v4kdXpHV44wqH1Cz1zk8gGZiIBTAaJGb18Cqi0aba3/pkoQ Content-Language: pl X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrFIsWRmVeSWpSXmKPExsWy7djP87rHd3elGByfZm3x7dMZZgdGjz+L NrMEMEZx2aSk5mSWpRbp2yVwZcx7PZu14Ih5xaVlC1kaGP+YdjFycEgImEjcmsfexcjFISSw glFiyfY3UM4kJonbO4+zQTgTmSSuv9jB3MXICdZxfP4bZojEckaJv1d2QLW0MEk8OvmPDaSK TSBP4vHntWAdIgI+Et3r17OC2JwCthK7Z7wGs4UFCiT+PX0LVs8ioCqx8sYZdhCbV8BSYvXk 7ywQtqDEyZlPwGxmAT2JZ6dmQdnaEssWvoa6SEHi59NlrBC73CS6rv5ghKgRkbjxqIUR5DgJ gYkcEsufbmWEaHCRWP7uEBOELSzx6vgWdghbRuL/zvlMkIApljjU7wBh1kgc+pEOUWEt8bbx ONQUR4kjv56xQJTwSdx4KwixlU9i0rbpzBBhXomONiEIU0Wir1MMolFK4umyOcwTGJVmIXlx FpIXZyF5cRaSVxYwsqxiFE8tLc5NTy02zEst1ytOzC0uzUvXS87P3cQITA6n/x3/tINx7quP eocYmTgYDzFKcDArifA+1WhPEeJNSaysSi3Kjy8qzUktPsQozcGiJM6rbXsyWUggPbEkNTs1 tSC1CCbLxMEp1cA0LWp1cFrxtUlilfv4U9bYnTtzWLpct14/YlLDncW+QQ+lVMUF8tNid+zU EH0Yq3mL6eZttlq/hLnyr1bN2eAcLeWimTHZ3VKz+dusg5MWrTVivH5sXcqhneVP9vBEHpoQ 1TzHQu1Y5MTJV722vHHSNoowckhP/b7kZMjCwiehFXa1y95wPIz6LZS2mbFqt9OlrzdS3+74 80rsBmdDT2DCj31xArKlpuvez3PaNPvcRoHy25mLdgdO9N6YucDWh8HrqbLYqe/Pfq3tYPvH M6clicc727k4n6XIyy9ObEGtnWSnma9Nmt6ZB8yO/lufZKl/6St6crbU2SPjX6HnmWPbfq6r zK5kcllaK6nyMEiJpTgj0VCLuag4EQDV4bGOfQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpgkeLIzCtJLcpLzFFi42I5/e/4Xd3ju7tSDCYf0bT49ukMswOjx59F m1kCGKP0bIryS0tSFTLyi0tslaINLYz0DC0t9IxMLPUMjc1jrYxMlfTtbFJSczLLUov07RL0 Mr4f+M1ScE2lYuqjxywNjI0yXYycHBICJhLH579h7mLk4hASWMoo8fbbKVaIhJTE0qWLGCFs YYk/17rYIIqamCS+HmpgBkmwCeRIrJ09kQnEFhHwkehev54VougOo8Sd3qnsIAlOAVuJ3TNe g00VFsiT6Hq2BayZRUBVYuWNM2A1vAKWEqsnf2eBsAUlTs58AmYzCxhILFn4iwnC1pZYtvA1 M8RFChI/ny5jhVjsJtF19QcjRI2IxI1HLYwTGIVmIRk1C8moWUhGzULSsoCRZRWjSGppcW56 brGhXnFibnFpXrpecn7uJkZgVGw79nPzDsZ5rz7qHWJk4mA8xCjBwawkwvtUoz1FiDclsbIq tSg/vqg0J7X4EKMp0G8TmaVEk/OBcZlXEm9oZmBqaGJmaWBqaWasJM7rWdCRKCSQnliSmp2a WpBaBNPHxMEp1cDEwNbje1Z3b9HjLx4h/a9XnXTP9LxXUpO1LSaXZd6CoEVR7zMK9twP4Q9P eLe760ZI8I0ZjdsXVL1vYvkxJXXd3F271O4yGE/ps/iflTXn4NYZZn9nHX6/7MFhyVzp42sT pp9U8v3D7nd+W3OB5Kcrs7wrvcNevOF/fEegrbpTe2Fz4wG15B2V/050ffHbJT+hpfbyagXr mXM3Z91Z330xWHWTl3Be1SfryY8XKL+qiVT/s7Cp2eTl6jNyj95y/1j21fVlrts+288P3/V+ m6m5uIfxu1uOTsvSmLWhfXm7fxbO73AqPcL5cu+VJ+ppfOLb5ZsEOy8z1jV/yTksKR4Wmnv1 7ubruWwvJM+W75KxU2Ipzkg01GIuKk4EAPySc3kTAwAA X-CMS-MailID: 20230615072039eucas1p11ae5ffa1e5d6b0a6301640a4b0db2894 X-Msg-Generator: CA X-RootMTR: 20230612123038eucas1p1c481a42fcbf3ae39b3dd756dcedc64e6 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20230612123038eucas1p1c481a42fcbf3ae39b3dd756dcedc64e6 References: <20230612123027.1865-1-d.kozinski@samsung.com> <20230614002326.GK1391451@pb2> Subject: Re: [FFmpeg-devel] [PATCH v24 6/9] avformat/mov_muxer: Extended MOV muxer to handle EVC video content X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of James > Almer > Sent: =B6roda, 14 czerwca 2023 03:00 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v24 6/9] avformat/mov_muxer: Extended > MOV muxer to handle EVC video content > = > On 6/13/2023 9:23 PM, Michael Niedermayer wrote: > > On Mon, Jun 12, 2023 at 02:30:27PM +0200, Dawid Kozinski wrote: > >> - Changes in mov_write_video_tag function to handle EVC elementary > >> stream > >> - Provided structure EVCDecoderConfigurationRecord that specifies the > >> decoder configuration information for ISO/IEC 23094-1 video content > >> > >> Signed-off-by: Dawid Kozinski > >> --- > >> libavformat/Makefile | 2 +- > >> libavformat/evc.c | 422 > ++++++++++++++++++++++++++++++++++++++++ > >> libavformat/evc.h | 44 +++++ > >> libavformat/isom_tags.c | 2 + > >> libavformat/movenc.c | 33 ++++ > >> 5 files changed, 502 insertions(+), 1 deletion(-) > >> create mode 100644 libavformat/evc.c > >> create mode 100644 libavformat/evc.h > >> > >> diff --git a/libavformat/Makefile b/libavformat/Makefile index > >> 6e4231fda2..d3503196e3 100644 > >> --- a/libavformat/Makefile > >> +++ b/libavformat/Makefile > >> @@ -364,7 +364,7 @@ OBJS-$(CONFIG_MOV_DEMUXER) +=3D mov.o > mov_chan.o mov_esds.o \ > >> OBJS-$(CONFIG_MOV_MUXER) +=3D movenc.o av1.o avc.o hevc.o > vpcc.o \ > >> movenchint.o mov_chan.o rtp.o \ > >> movenccenc.o movenc_ttml.o rawutils.o \ > >> - dovi_isom.o > >> + dovi_isom.o evc.o > >> OBJS-$(CONFIG_MP2_MUXER) +=3D rawenc.o > >> OBJS-$(CONFIG_MP3_DEMUXER) +=3D mp3dec.o replaygain.o > >> OBJS-$(CONFIG_MP3_MUXER) +=3D mp3enc.o rawenc.o id3v2enc.o > >> diff --git a/libavformat/evc.c b/libavformat/evc.c new file mode > >> 100644 index 0000000000..431cb107e3 > >> --- /dev/null > >> +++ b/libavformat/evc.c > >> @@ -0,0 +1,422 @@ > >> +/* > >> + * EVC helper functions for muxers > >> + * Copyright (c) 2022 Dawid Kozinski > >> + * > >> + * This file is part of FFmpeg. > >> + * > >> + * FFmpeg is free software; you can redistribute it and/or > >> + * modify it under the terms of the GNU Lesser General Public > >> + * License as published by the Free Software Foundation; either > >> + * version 2.1 of the License, or (at your option) any later version. > >> + * > >> + * FFmpeg is distributed in the hope that it will be useful, > >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of > >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > GNU > >> + * Lesser General Public License for more details. > >> + * > >> + * You should have received a copy of the GNU Lesser General Public > >> + * License along with FFmpeg; if not, write to the Free Software > >> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA > >> +02110-1301 USA */ > > > > [...] > > > >> + nalu_type =3D ff_evc_get_nalu_type(data, bytes_to_read, pb); > > > > functions shared between libavcodec and libavformat need an > > av*/avpriv* prefix otherwise linking will fail with shared libs as ff* > > isnt exported > = > It's small enough that it can go in the header instead. That way we save one > unnecessary exported symbol. Same with ff_evc_read_nal_unit_length(). Thank you for your code review. I've just pushed new patchset containig fixes for all the issues metnioned in this email and changes following Paul's review. Unfortunately I did that before I saw your last email and Michael Neidermayer's last email. So it seems that I still have some work to do like changing prefixes frmom ff_* to av_* for functions shared between libavcodec and libavformat, and moving int ff_evc_get_nalu_type(), ff_evc_read_nal_unit_length() implementations from evc_parse.c file to evc+parse.h. > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://protect2.fireeye.com/v1/url?k=3D5297bb74-33ec11fc-5296303b- > 74fe4860018a-ffe4f237f8ba290d&q=3D1&e=3D351d993e-ef97-4840-aeb8- > 4fd043541ed8&u=3Dhttps%3A%2F%2Fffmpeg.org%2Fmailman%2Flistinfo%2Fffmp > eg-devel > = > To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org > with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".