From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 0BBB54B9AA for ; Sun, 28 Sep 2025 11:19:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1759058341; h=date : to : message-id : references : mime-version : in-reply-to : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=HkTc7iqC/odZKSKjxvJM9Di9HmsR3eWmSieDrKLbV9A=; b=fQ8Z7skzsnN7txAKp8Voy3J5kqK1uZES4tgI8LPEIrHYqTV1/NQNTprxjk9omH/+xgFgK JBobjTUE6HM9nknHon3azz1xJFP/yhx2TWTzLaYzljb3QZ73C0spyltxPyMQs10fXJHyzBl biJ3NOyj+8ud8DR5WudL8iEI/1lGEQvGmGYRgdDOdUk+owstPX+IvmMf332UZGyW0zUsai7 yt8/PS0gEH+Fub5wDswmiwuswbUPDGyPxnLlJIQmP7/g45fXo85BhYubja1gFmAXX6OuieM 78a/2y5/SetstL3IhwewuAf67V/h1X0oYseczX3Du/w23wJrg9aw6oF6+07g== Received: from [172.19.0.4] (unknown [172.19.0.4]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 8367968ED9E; Sun, 28 Sep 2025 14:19:01 +0300 (EEST) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1759058338; b=jj1H+FIohVGqviYT1EMk3kJeVMeeuyF1qc2GOQgWgtfUxtUIOwLemREUh0BD+q/oxU76X 8N8nwB/eiPyA2m8CHHnFLvbQ1+jftrkFSrH1Vxm6gom1AOdgAo8XwIV18I23QzXOj8JZ7nc G5HOrW9sDJozLYLb6EwrhAGigRAsoHaibPUNmp7P/bPmpz0RiydoVctsuXausQiwHcDEkjX H+z9xhbKUWqNH6/GGTG0EKvq2UN/3xVRWLbRWQuZt/RRlcYPJyouYt+tKKwrS8nIuAoAJMS i6dPBs+4ddnzA+u536C8Vr2piz8Rqog+wa9htt2RNY9jVnpu9LU+j/KDzECg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1759058338; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=7PaYWflIBpMY6lFRGijzy9iGODQsHcoHLE1gjwOAk08=; b=Uyc437zXCjesZI+0nMh197N791AMIqfFwKbXwg8Vsxz59F7dUA9k7NWhfqNWLDaXk15ht bt8TYaYLHX29wbTCVBXiZkxuBIgL8hPKGQgB5sNrUhQWxjDo1eJbdxhD0SOdm7rMixmJxKT XocdSO49gihPALEKJlvf4aPYNMuATu2PT++efhlSkquPnV9l86qi2GYkVffWiRvJBSw6+TM 8q44U7b1FLfcRKIXVHrw+U/xjBnRgOsb3PWiTpZkk8DO6G5phD3AfxLvf7TPY4cYz8lJHs1 8XVZvDyy6U5AufK0aGiMIDnkYRsx+9Ekybt5nEeuqMa0YIpcTPx2ijZB4q+A== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=fail; arc=none; dmarc=none Authentication-Results: ffmpeg.org; dkim=fail; arc=none (Message is not ARC signed); dmarc=none Received: from nef.ens.fr (nef2.ens.fr [129.199.96.40]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id CD4D668ED57; Sun, 28 Sep 2025 14:18:39 +0300 (EEST) X-ENS-nef-client: 129.199.129.80 ( name = phare.normalesup.org ) Received: from phare.normalesup.org (phare.normalesup.org [129.199.129.80]) by nef.ens.fr (8.14.4/1.01.28121999) with ESMTP id 58SBIVH7014269 ; Sun, 28 Sep 2025 13:18:31 +0200 Received: by phare.normalesup.org (Postfix, from userid 1001) id 761F42EFE4; Sun, 28 Sep 2025 13:18:31 +0200 (CEST) Date: Sun, 28 Sep 2025 13:18:31 +0200 To: FFmpeg development discussions and patches Message-ID: References: <175904174886.25.9550971653392209023@bf249f23a2c8> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <175904174886.25.9550971653392209023@bf249f23a2c8> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (nef.ens.fr [129.199.96.32]); Sun, 28 Sep 2025 13:18:31 +0200 (CEST) Message-ID-Hash: LL5AHQB4F47VC2Y7UPO6C37EY64373JC X-Message-ID-Hash: LL5AHQB4F47VC2Y7UPO6C37EY64373JC X-MailFrom: SRS0=lSoF=4H=phare.normalesup.org=george@ffmpeg.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] Re: [PATCH] avfilter: add avfilter_forward_command API for recursive command processing. (PR #20621) List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Nicolas George via ffmpeg-devel Cc: cenzhanquan1 , Nicolas George Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: cenzhanquan1 via ffmpeg-devel (HE12025-09-28): > PR #20621 opened by cenzhanquan1 > URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20621 > Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20621.patch > > This commit introduces a new API that allows commands to be recursively > forwarded through filter graphs, enabling dynamic control of filters > at runtime. > > Key changes: > > 1. Added avfilter_forward_command() function in avfilter.c: > - Supports both forward and reverse command propagation via > AVFILTER_CMD_FLAG_REVERSE flag > - Recursively traverses filter links to find target filters > - Falls back to filter-specific forward_command callback when available > - Properly handles "all" target for broadcasting commands > > 2. Extended AVFilter struct in filters.h: > - Added forward_command callback for filter-specific implementations > - Maintains backward compatibility with existing filters > > 3. New API documentation in avfilter.h: > - Detailed parameter descriptions including pad_idx and flags > - Clear explanation of AVFILTER_CMD_FLAG_REVERSE behavior > - Usage examples for common scenarios > > 4. Added AVFILTER_CMD_FLAG_REVERSE flag: > - Enables reverse traversal from sink to source filters > - Useful for targeting specific filters in complex graphs Thanks for the patch. We normally avoid introducing APIs that nothing uses. If this API is useful, then it probably can be made use of by one of the fftools, most likely ffmpeg itself. Please submit a patch series that also adds this use. Also, please explain what this makes possible that was not already possible with existing functions, in particular simply avfilter_process_command() and avfilter_graph_send_command(). Regards, -- Nicolas George _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org