From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 5A0994BC3C for ; Mon, 29 Sep 2025 22:53:56 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'vRd7V064XgeNfKJfYX41Z12qlPMHVTA9DanmVhmJWYU=', expected b'1ABbxS1oPk/Ekn7JRF+gMo7/Grs2FFuP2MxBSNzZ/DM=')) header.d=googlemail.com header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1759186422; h=mime-version : references : in-reply-to : date : message-id : to : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=IWHgDo8HgoUZ9C/LMTZjr/0d60iHip/F3434fpNvdb8=; b=qRDtkhSiWkDh1vMl19zzQ9ETOZ0KYuh2JouiiXjnva1G4l8NJzcHqSK4Rak3CFbDDPASS As/QOgjvUA53S5WSiNOzI9gnKTQ0qxPIsv4zBZ7QoCYYGE9G2OjVClVUOmr8vwK8beZS/ub JrvS4nCeBP0/1uLka5/YheBYBIOnuvPwll8mtwxksmuWUG0OhpIPxsdmoH9QJALcBSbOLcb XiVhJNqE9v5KpZVbRS74Og6xNMh4BqfSXzfmpq9mYlx7Oh17CCWLCgGqFOYUl2T1IatLqJj 0X8kklG/QsO5OAoOORNuBJeSzpuY3uxBgNxZUb4CuaWRmZhCvo/qIAHH11kw== Received: from [172.19.0.4] (unknown [172.19.0.4]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id D4C6568ED04; Tue, 30 Sep 2025 01:53:42 +0300 (EEST) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1759186419; b=jES8K5JHa3eA0qJCOYwlcI/CVGw+dhabAbn6pR6VDOgrWNZz4cN2dk8yTIrpn0ucjxk9d DgO4dQDb0mXw0ewpdFKlALRs0Msms0zyPx64uuOpwaS95CoABgSiqAflDFqkDAPZ9Tb0fSB YJuklMkFsK0Hoa5BNuwzdb++p2aM1y9rIMf2fUrtFRzsWw9/7F3q0TQHNitoQVEezQQ9kJ2 bq4fbeFPcdEsA+x39lmku6vaATkuXoX+KY7fooNSOByH0RPnZKTv8yrkm0+AMyXjra5p+tt 4RkKL2lO1qM7Gp/cQMWRjwxKUGalMiocb7UY6UXOs8I7JdbGcmHNW2KGEg5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1759186419; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=vRd7V064XgeNfKJfYX41Z12qlPMHVTA9DanmVhmJWYU=; b=fnHAPP9vfbuWO9ysIYYR5w+4HvAv2/Wy/0vw6hP0qmQ/yMwtQl8bXRt4zksdmvwRs+z2R wYarY+JiLhzn5irMwC/89ZW7V+FSa9FUhh5a1uRcpLVsuhSWr/HS9XfMPrbIUA5SaFk/6cn Ac19Od/9qxLO/oZV2wIYTZ0xGGh9sr4zU/duM4mnyq01xubroxTB3R6Y8g06mcbw1Skk6+6 I3BsxJ+rMCDzuvRa/o3T8N43g9xIkvlSslUErYRgxLAaCN1FiVGg5dS3J6w0hKcqI/zn5rm xWs6hnEPkT5yVHSPe5OH20sWrtXGl6fxWfJteaxrqc3W6KE/sV16J/7x0y2A== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=googlemail.com; arc=none; dmarc=pass header.from=googlemail.com policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=googlemail.com; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=googlemail.com policy.dmarc=quarantine Received: from mail-yx1-f43.google.com (mail-yx1-f43.google.com [74.125.224.43]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 954BD68EC5D for ; Tue, 30 Sep 2025 01:53:26 +0300 (EEST) Received: by mail-yx1-f43.google.com with SMTP id 956f58d0204a3-63604582e53so5396018d50.3 for ; Mon, 29 Sep 2025 15:53:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20230601; t=1759186404; x=1759791204; darn=ffmpeg.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=1ABbxS1oPk/Ekn7JRF+gMo7/Grs2FFuP2MxBSNzZ/DM=; b=GWVT2DALxZB6VLYGMvKdFtXqZyHBSEMc+YN9+Me7AWoZvxQb4xyv8Jktviek/9b2B9 aCf3azPDEMGo3L3Fty5v6epjbWWo1eDC7YDLrVkW2xtggt0ZG0I4BN8QF5JfQpEV7O0E DKXYzlJq8Srs0THglxT7nUJ5g6QpRcBy82OccP7Re8uIwv3OlTT5N5XdktORlbmRG+bZ PMhBHmFPpLvtqhfHbMtvHX0NI0+5Qq50k5M6mBHNgtFVZBbO1w+QuOuPxBVGsZRMzu3Y sHBLogNNk11/gXNoOgv6oiIr8biAA9X+gvLoI+Ro7qIiTR80pJ4xMb/gXSqdphUc6qYH B7sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759186404; x=1759791204; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1ABbxS1oPk/Ekn7JRF+gMo7/Grs2FFuP2MxBSNzZ/DM=; b=elNEBtFi1l6DTIxohU13ceoB9D0sT9pRD+MB7B6YF9E/rvIlFFOZ6h7b7BvW4VgZY7 zId3ctu+zDPPl3d3BUSrzDQeU4kDVuJxigABp7iQHO6FPQf7K9UfjzxzumDamnBM14XE 27MbdDb7ai++7ORx1qrnGoqbT7tL+6Ddmc/+njUvHx9WCyfFzxFNXwIztCe7QyTpPais YgZu/WfiIuFl8KFJRdBlgUuwhCIx4jFh6rVPNhyovP9FqHm38gIX9uaGxb22rii0mqQq jTr+4xM2sQZJWJn0/Iqf/+U0Zv6lSDk3wys3ooMGAYFdNyGvmXZlkT3a7hxjXEIc7adF utYw== X-Gm-Message-State: AOJu0YwMw0G8o7BJqM94oPetO69Hx0W/YMPrd1L0+hHM49yCkGmheR5X uZXMXuKev6qPBW4swE/tz/qBP+cfrQNCT8NzLRA4zZsaj0aW/uXi2sXx2TMW+zVq52THrRMijl5 QR1vpa7zGqdOXUAyNoasRemmPksn0/laea3+g X-Gm-Gg: ASbGnctL0xSp7vL7EPc+s+CIm976sYrtVvxvTw/rrO3r9WXo7HdkCCWHQiWMH32iihS BZUa2F44I1/T4ghdze8q51jh0YhHIuHolttbXLanxbTcLz2lss4CgK/khrPwt+FH+INRO4lBXWQ epPwnDhgls9iGA9G7Aq4mccc2EY0h6oBIbgUQAZfmqmhZOjeQsPpHgNpwEmpGQPPxUiBMss6sA6 ek5nkVnWdoOmGERxZ6kHxoAio0mpRasyipGCcS1EcVIaRmrsoX4 X-Google-Smtp-Source: AGHT+IF2M75VFFJjnOaufB0Osh7uosiseEx+WpwQGDQbefzEUNsg/butF3kuGYluy1KU1IHQEGf/9E9Fuf2rP18Vkbg= X-Received: by 2002:a05:690e:15cc:b0:636:dd7:ee30 with SMTP id 956f58d0204a3-6361a72ae04mr19382214d50.5.1759186404478; Mon, 29 Sep 2025 15:53:24 -0700 (PDT) MIME-Version: 1.0 References: <175915826520.25.4263526844597699342@bf249f23a2c8> In-Reply-To: <175915826520.25.4263526844597699342@bf249f23a2c8> Date: Mon, 29 Sep 2025 23:53:14 +0100 X-Gm-Features: AS18NWDYcixjGbfTgyyEIp96_hjoUhED6B8grbbY7r9r49kJpMqJS1OAg-kSYCI Message-ID: To: FFmpeg development discussions and patches Message-ID-Hash: ZNZ2LJNCOK4GPBCMRZOYBYJDLFDQOSZT X-Message-ID-Hash: ZNZ2LJNCOK4GPBCMRZOYBYJDLFDQOSZT X-MailFrom: SRS0=mNOA=4I=googlemail.com=kieran618@ffmpeg.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Content-Filtered-By: Mailman/MimeDel 3.3.10 X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] Re: [PATCH] Miscellaneous aacdec_usac cleanups (PR #20627) List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Kieran Kunhya via ffmpeg-devel Cc: Lynne , Kieran Kunhya Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: On Mon, 29 Sept 2025, 16:04 Lynne via ffmpeg-devel, wrote: > PR #20627 opened by Lynne > URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20627 > Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20627.patch > > Nothing major. > > > >From 485939f5ba2051d3091bb130f0879d3b1ed83e6a Mon Sep 17 00:00:00 2001 > From: Lynne > Date: Tue, 30 Sep 2025 00:02:19 +0900 > Subject: [PATCH 1/2] aacdec_usac: memset uncoded coeffs instead of > iterating > > Microoptimization. > --- > libavcodec/aac/aacdec_usac.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/aac/aacdec_usac.c b/libavcodec/aac/aacdec_usac.c > index c4b821bbba..38d5328029 100644 > --- a/libavcodec/aac/aacdec_usac.c > +++ b/libavcodec/aac/aacdec_usac.c > @@ -670,10 +670,8 @@ static int decode_spectrum_ac(AACDecContext *s, float > coef[1024], > > ff_aac_ac_finish(state, i, N); > > - for (; i < N/2; i++) { > - coef[2*i + 0] = 0; > - coef[2*i + 1] = 0; > - } > + /* Zero out uncoded coeffs */ > + memset(coef + 2*i, 0, N*sizeof(*coef))); > This looks wrong. It is only correct if i is guaranteed to be zero before the for loop. The number of elements to zero is not N*sizeof(...) otherwise. Kieran > _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org